From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C29632F7D for ; Thu, 19 Jul 2018 11:03:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 02:03:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,374,1526367600"; d="scan'208";a="73654440" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.102]) ([10.237.220.102]) by fmsmga001.fm.intel.com with ESMTP; 19 Jul 2018 02:03:56 -0700 To: Stephen Hemminger , sergio.gonzalez.monroy@intel.com Cc: dev@dpdk.org References: <20180718214434.608-1-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: Date: Thu, 19 Jul 2018 10:03:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180718214434.608-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] mem: poison memory when freed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 09:03:59 -0000 On 18-Jul-18 10:44 PM, Stephen Hemminger wrote: > DPDK malloc library allows broken programs to work because > the semantics of zmalloc and malloc are the same. > > This patch changes to a more secure model which will catch > (and crash) programs that reuse memory already freed. > > This supersedes earlier changes to zero memory on free and > avoid zeroing memory in zmalloc. > > Signed-off-by: Stephen Hemminger > --- I would be a bit wary of introducing this change without prior announcement. Currently, rte_malloc'd memory is semantically identical to zmalloc'd memory, which means there may be code that relies on this behavior, even though it's technically incorrect. How about a deprecation notice, and do this in 18.11? -- Thanks, Anatoly