From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
rsanford@akamai.com, thomas@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] timer: allow first subsystem init from secondary
Date: Thu, 9 May 2019 12:44:39 +0100 [thread overview]
Message-ID: <bc282556-36fa-a11f-9083-704acdcf7cf0@intel.com> (raw)
In-Reply-To: <1557353861-31997-1-git-send-email-erik.g.carrillo@intel.com>
On 08-May-19 11:17 PM, Erik Gabriel Carrillo wrote:
> Since memzones can be reserved from secondary processes as well as
> primary processes, if the first call to the timer subsystem init
> function occurs in a secondary process, we should allow it to succeed.
>
> Fixes: c0749f7096c7 ("timer: allow management in shared memory")
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> lib/librte_timer/rte_timer.c | 52 +++++++++++++++++++++++---------------------
> 1 file changed, 27 insertions(+), 25 deletions(-)
>
> diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
> index 9f2e921..c0f5b87 100644
> --- a/lib/librte_timer/rte_timer.c
> +++ b/lib/librte_timer/rte_timer.c
> @@ -25,6 +25,7 @@
> #include <rte_memzone.h>
> #include <rte_malloc.h>
> #include <rte_compat.h>
> +#include <rte_errno.h>
>
> #include "rte_timer.h"
>
> @@ -155,40 +156,41 @@ rte_timer_subsystem_init_v1905(void)
> struct rte_timer_data *data;
> int i, lcore_id;
> static const char *mz_name = "rte_timer_mz";
> + const size_t data_arr_size =
> + RTE_MAX_DATA_ELS * sizeof(*rte_timer_data_arr);
> + bool do_full_init;
>
> if (rte_timer_subsystem_initialized)
> return -EALREADY;
>
> - if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
> - mz = rte_memzone_lookup(mz_name);
> - if (mz == NULL)
> - return -EEXIST;
> +lookup:
> + mz = rte_memzone_lookup(mz_name);
Wouldn't it be better to attempt to reserve outright, and then do a
lookup on EEXIST?
> + if (mz == NULL) {
> + mz = rte_memzone_reserve_aligned(mz_name, data_arr_size,
> + SOCKET_ID_ANY, 0, RTE_CACHE_LINE_SIZE);
> + if (mz == NULL) {
> + if (rte_errno == EEXIST)
> + goto lookup;
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-05-09 11:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 22:17 Erik Gabriel Carrillo
2019-05-08 22:17 ` Erik Gabriel Carrillo
2019-05-09 11:44 ` Burakov, Anatoly [this message]
2019-05-09 11:44 ` Burakov, Anatoly
2019-05-09 19:47 ` Carrillo, Erik G
2019-05-09 19:47 ` Carrillo, Erik G
2019-05-09 19:39 ` [dpdk-dev] [PATCH v2] " Erik Gabriel Carrillo
2019-05-09 19:39 ` Erik Gabriel Carrillo
2019-05-09 19:51 ` Thomas Monjalon
2019-05-09 19:51 ` Thomas Monjalon
2019-05-09 20:08 ` Carrillo, Erik G
2019-05-09 20:12 ` Thomas Monjalon
2019-05-09 20:12 ` Thomas Monjalon
2019-05-09 21:19 ` Carrillo, Erik G
2019-05-09 21:19 ` Carrillo, Erik G
2019-05-09 22:07 ` Thomas Monjalon
2019-05-09 22:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc282556-36fa-a11f-9083-704acdcf7cf0@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=rsanford@akamai.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).