From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02018A0540; Mon, 13 Jul 2020 13:44:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF5A31D658; Mon, 13 Jul 2020 13:44:29 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BE28A1D646 for ; Mon, 13 Jul 2020 13:44:27 +0200 (CEST) IronPort-SDR: GHptf4LQg6E3KciI/ZwzEP/xle8s3++SSDsHz2BBzcToRAfQ0P0awziXj0UZkn21aJSvVNom9a 4aOheMI3XD2w== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="146627769" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="146627769" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 04:44:26 -0700 IronPort-SDR: tewFp6XBlaYOq0J8ugH8qndZeki9ygRy8GqDOTwUQe+L3+k0Jie2CoBYgZTArshnKlCUDs0AQV dPYnHgU+maeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="390151450" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.213.224.143]) ([10.213.224.143]) by fmsmga001.fm.intel.com with ESMTP; 13 Jul 2020 04:44:25 -0700 To: David Marchand Cc: dev , Jerin Jacob Kollanukkaran , Ray Kinsella , Thomas Monjalon , "Ananyev, Konstantin" , Bruce Richardson References: <869034e585604e3cc2f1131219478e634a1d3f64.1594638050.git.vladimir.medvedkin@intel.com> From: "Medvedkin, Vladimir" Message-ID: Date: Mon, 13 Jul 2020 12:44:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 1/8] eal/x86: introduce AVX 512-bit type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/07/2020 12:33, David Marchand wrote: > On Mon, Jul 13, 2020 at 1:11 PM Vladimir Medvedkin > wrote: >> >> New data type to manipulate 512 bit AVX values. >> >> Signed-off-by: Vladimir Medvedkin >> Acked-by: Konstantin Ananyev >> --- >> lib/librte_eal/x86/include/rte_vect.h | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/lib/librte_eal/x86/include/rte_vect.h b/lib/librte_eal/x86/include/rte_vect.h >> index df5a60762..30dcfd5e7 100644 >> --- a/lib/librte_eal/x86/include/rte_vect.h >> +++ b/lib/librte_eal/x86/include/rte_vect.h >> @@ -13,6 +13,7 @@ >> >> #include >> #include >> +#include >> #include "generic/rte_vect.h" >> >> #if (defined(__ICC) || \ >> @@ -90,6 +91,24 @@ __extension__ ({ \ >> }) >> #endif /* (defined(__ICC) && __ICC < 1210) */ >> >> +#ifdef __AVX512F__ >> + >> +#define RTE_X86_ZMM_SIZE (sizeof(__m512i)) >> +#define RTE_X86_ZMM_MASK (ZMM_SIZE - 1) > > Please fix: > #define RTE_X86_ZMM_MASK (RTE_X86_ZMM_SIZE - 1) > Oh, thanks! > >> + >> +typedef union __rte_x86_zmm { >> + __m512i z; >> + ymm_t y[RTE_X86_ZMM_SIZE / sizeof(ymm_t)]; >> + xmm_t x[RTE_X86_ZMM_SIZE / sizeof(xmm_t)]; >> + uint8_t u8[RTE_X86_ZMM_SIZE / sizeof(uint8_t)]; >> + uint16_t u16[RTE_X86_ZMM_SIZE / sizeof(uint16_t)]; >> + uint32_t u32[RTE_X86_ZMM_SIZE / sizeof(uint32_t)]; >> + uint64_t u64[RTE_X86_ZMM_SIZE / sizeof(uint64_t)]; >> + double pd[RTE_X86_ZMM_SIZE / sizeof(double)]; >> +} __rte_aligned(RTE_X86_ZMM_SIZE) __rte_x86_zmm_t; >> + >> +#endif /* __AVX512F__ */ >> + >> #ifdef __cplusplus >> } >> #endif >> -- >> 2.17.1 >> > -- Regards, Vladimir