From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6732A0588; Thu, 16 Apr 2020 15:19:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3A1F1DC85; Thu, 16 Apr 2020 15:19:46 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id A64321DC84 for ; Thu, 16 Apr 2020 15:19:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587043185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=97H4TPmE67Bo7B3AAyyUsncmNT1rAF/hiphoYA3BEsY=; b=CXCUtHBbe5YNaConsUkXxh3823JjZxTV9GjAWvg50nRAieazH25aCMhPZ54LRFtOnb5+b+ bnTPvjR5EYDwdZkHx4LT5/BGsZTxnAy5RIrwXF6oCQ/dcieaWtixW4Rt1kxRATci9G+mYr byMXwPdp3hRlamDuw9T8CN4XKdwldfk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-GQs1lrA2NQq8lvh07byDtA-1; Thu, 16 Apr 2020 09:19:43 -0400 X-MC-Unique: GQs1lrA2NQq8lvh07byDtA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 63DAB18B5F97; Thu, 16 Apr 2020 13:19:42 +0000 (UTC) Received: from [10.36.110.44] (unknown [10.36.110.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9DBB1001920; Thu, 16 Apr 2020 13:19:40 +0000 (UTC) To: Matan Azrad , "dev@dpdk.org" , Xiao Wang Cc: Slava Ovsiienko , Shahaf Shuler References: <1585826793-28709-1-git-send-email-matan@mellanox.com> <1585826793-28709-2-git-send-email-matan@mellanox.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Thu, 16 Apr 2020 15:19:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Matan, On 4/16/20 11:06 AM, Matan Azrad wrote: > Hi Maxime >=20 > Can you point on specific vendor specific counter I suggested? No, I can't, but I think we can expect that other vendors may have other counters they would be interested to dump. Maybe Intel has some counters in the IFC that they could dump. Xiao, any thoughts? > I think all of them come directly from virtio protocols. exceed_max_chain, for example. Doesn't the spec specify that a descriptors chain can be as long as the size of the virtqueue? Here it seems to indicate the device could support less. Also, as the spec evolves, we may have new counters that comes up, so better to have something flexible from the start IMHO to avoid ABI breakages. Maybe we can have some common xstats names for the Virtio related counters define in vdpa lib, and then the vendors can specify more vendor-specific counters if they wish? Thanks, Maxime >=20 > =D7=94=D7=A9=D7=92 =D7=90=D7=AA Outlook =D7=A2=D7=91=D7=95=D7=A8 Android = > ------------------------------------------------------------------------ > *From:* Maxime Coquelin > *Sent:* Wednesday, April 15, 2020 5:36:59 PM > *To:* Matan Azrad ; dev@dpdk.org > *Cc:* Slava Ovsiienko ; Shahaf Shuler > > *Subject:* Re: [PATCH 1/4] vhost: inroduce operation to get vDPA queue > stats > =C2=A0 > Hi Matan, >=20 > On 4/2/20 1:26 PM, Matan Azrad wrote: >> The vDPA device offloads all the datapath of the vhost device to the HW >> device. >>=20 >> In order to expose to the user traffic information this patch introduce >> new API to get traffic statistics per virtio queue. >>=20 >> The statistics are taken directly from the vDPA driver managing the HW >> device. >>=20 >> Signed-off-by: Matan Azrad >> Acked-by: Viacheslav Ovsiienko >> --- >>=C2=A0 doc/guides/rel_notes/release_20_05.rst=C2=A0=C2=A0=C2=A0 |=C2=A0 4= +++ >>=C2=A0 doc/guides/vdpadevs/features/default.ini=C2=A0 |=C2=A0 1 + >>=C2=A0 doc/guides/vdpadevs/features_overview.rst |=C2=A0 3 +++ >>=C2=A0 lib/librte_vhost/rte_vdpa.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 45 ++++++++++++++++++++++++= ++++++- >>=C2=A0 lib/librte_vhost/rte_vhost_version.map=C2=A0=C2=A0=C2=A0 |=C2=A0 1= + >>=C2=A0 lib/librte_vhost/vdpa.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 14 +++= +++++++ >>=C2=A0 6 files changed, 67 insertions(+), 1 deletion(-) >=20 > ... >=20 >> diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h >> index 9a3deb3..d6cbf48 100644 >> --- a/lib/librte_vhost/rte_vdpa.h >> +++ b/lib/librte_vhost/rte_vdpa.h >> @@ -37,6 +37,27 @@ struct rte_vdpa_dev_addr { >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }; >>=C2=A0 }; >>=C2=A0=20 >> +struct rte_vdpa_queue_stats { >> +=C2=A0=C2=A0=C2=A0=C2=A0 /** Number of descriptors received by device *= / >> +=C2=A0=C2=A0=C2=A0=C2=A0 uint64_t received_desc; >> +=C2=A0=C2=A0=C2=A0=C2=A0 /** Number of descriptors completed by the dev= ice */ >> +=C2=A0=C2=A0=C2=A0=C2=A0 uint64_t completed_desc; >> +=C2=A0=C2=A0=C2=A0=C2=A0 /** Number of bad descriptors received by devi= ce */ >> +=C2=A0=C2=A0=C2=A0=C2=A0 uint32_t bad_desc; >> +=C2=A0=C2=A0=C2=A0=C2=A0 /** >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * Number of chained descriptors received= that exceed the max allowed >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * chain by device >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >> +=C2=A0=C2=A0=C2=A0=C2=A0 uint32_t exceed_max_chain; >> +=C2=A0=C2=A0=C2=A0=C2=A0 /** >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * Number of times device tried to read o= r write buffer that is not >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * registered to the device >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >> +=C2=A0=C2=A0=C2=A0=C2=A0 uint32_t invalid_buffer; >> +=C2=A0=C2=A0=C2=A0=C2=A0 /** Number of errors detected by the device */ >> +=C2=A0=C2=A0=C2=A0=C2=A0 uint32_t errors; >> +}; >> + >=20 > I think doing it like that, we risk to keep the rte_vdpa_get_stats API > always experimental, as every vendor will want to add their own counters > and so break the ABI. >=20 > How about implementing something similar to rte_eth_xstat? > As these stats are for debugging purpose, it would give you much more > flexibility in adding new counters as HW or firmwares evolves. >=20 > What do you think? >=20 > Thanks, > Maxime >=20 >>=C2=A0 /** >>=C2=A0=C2=A0 * vdpa device operations >>=C2=A0=C2=A0 */ >> @@ -73,8 +94,11 @@ struct rte_vdpa_dev_ops { >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int (*get_notify_area)(int vid= , int qid, >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uint64_t= *offset, uint64_t *size); >>=C2=A0=20 >> +=C2=A0=C2=A0=C2=A0=C2=A0 /** Get statistics of the queue */ >> +=C2=A0=C2=A0=C2=A0=C2=A0 int (*get_stats)(int did, int qid, struct rte_= vdpa_queue_stats *stats); >> + >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /** Reserved for future extens= ion */ >> -=C2=A0=C2=A0=C2=A0=C2=A0 void *reserved[5]; >> +=C2=A0=C2=A0=C2=A0=C2=A0 void *reserved[4]; >>=C2=A0 }; >>=C2=A0=20 >>=C2=A0 /** >> @@ -200,4 +224,23 @@ struct rte_vdpa_device * >>=C2=A0 __rte_experimental >>=C2=A0 int >>=C2=A0 rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m); >> + >> +/** >> + * @warning >> + * @b EXPERIMENTAL: this API may change without prior notice >> + * >> + * Get vDPA device queue statistics. >> + * >> + * @param did >> + *=C2=A0 device id >> + * @param qid >> + *=C2=A0 queue id >> + * @param stats >> + *=C2=A0 queue statistics pointer. >> + * @return >> + *=C2=A0 0 on success, non-zero on failure. >> + */ >> +__rte_experimental >> +int >> +rte_vdpa_get_stats(int did, uint16_t qid, struct rte_vdpa_queue_stats *= stats); >>=C2=A0 #endif /* _RTE_VDPA_H_ */ >> diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/r= te_vhost_version.map >> index 051d08c..c9dcff4 100644 >> --- a/lib/librte_vhost/rte_vhost_version.map >> +++ b/lib/librte_vhost/rte_vhost_version.map >> @@ -38,6 +38,7 @@ EXPERIMENTAL { >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rte_vdpa_find_device_id; >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rte_vdpa_get_device; >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rte_vdpa_get_device_num; >> +=C2=A0=C2=A0=C2=A0=C2=A0 rte_vdpa_get_stats; >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rte_vhost_driver_attach_vdpa_d= evice; >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rte_vhost_driver_detach_vdpa_d= evice; >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rte_vhost_driver_get_vdpa_devi= ce_id; >> diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c >> index 2b86708..57900fc 100644 >> --- a/lib/librte_vhost/vdpa.c >> +++ b/lib/librte_vhost/vdpa.c >> @@ -227,3 +227,17 @@ struct rte_vdpa_device * >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 free_ind_table(idesc); >>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -1; >>=C2=A0 } >> + >> +int >> +rte_vdpa_get_stats(int did, uint16_t qid, struct rte_vdpa_queue_stats *= stats) >> +{ >> +=C2=A0=C2=A0=C2=A0=C2=A0 struct rte_vdpa_device *vdpa_dev; >> + >> +=C2=A0=C2=A0=C2=A0=C2=A0 vdpa_dev =3D rte_vdpa_get_device(did); >> +=C2=A0=C2=A0=C2=A0=C2=A0 if (!vdpa_dev) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 return -ENODEV; >> + >> +=C2=A0=C2=A0=C2=A0=C2=A0 RTE_FUNC_PTR_OR_ERR_RET(vdpa_dev->ops->get_sta= ts, -ENOTSUP); >> + >> +=C2=A0=C2=A0=C2=A0=C2=A0 return vdpa_dev->ops->get_stats(did, qid, stat= s); >> +} >>=20 >=20 >=20 > =D7=94=D7=A9=D7=92 =D7=90=D7=AA Outlook =D7=A2=D7=91=D7=95=D7=A8 Android =