From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60763A0C58; Thu, 25 Nov 2021 17:52:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DB4B40DF5; Thu, 25 Nov 2021 17:52:15 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 836F140140 for ; Thu, 25 Nov 2021 17:52:13 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10179"; a="298946584" X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="298946584" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2021 08:52:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208";a="539026228" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 25 Nov 2021 08:52:12 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 25 Nov 2021 08:52:12 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 25 Nov 2021 08:52:11 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 25 Nov 2021 08:52:11 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 25 Nov 2021 08:52:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oBNE8zFYWZmG4DyBc6bNAasfXWhGr4gS7RPcItE8Cw+U6tQoEsvXqa57/JpsIe5EJ441+vx6WviLfRY5rul/jehLb+6EjI0Pe4m5AqPmugQ8dkAPN3lCE6a4az98d/6gX+qMPM4JAAoMDx9Cqv4jyA6RD9rpJsRI4zjVBz00e8JoUmb/DtyEx0ZgG8l1Mby1+o9nTIxIKQmzqZPUCNa/UDioYEW6FxHUMbEQvMk4AyXSaz6hHbAZqtdKwlXHKa2IS72n7XlT+Ry9FHpT5nhz2ZVTyMeOnnqUbaJ0KFY+fjPc84ENiAKvJWxiVxwOQlhVJqxTDsKBHSxEgko0ZYxvuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xDMgyNEOzXHbdVbMJurDT4M2ATNWTzSqOYVWQUbBWw0=; b=KSJAFkizyREL9GEBnOEAt0BYc+AHYXwv7m7lzHWuBIC1oZF8p0IcCiLpO72G9H1Ltiw4i0pnZstRP3uEP3FwBK+uSvMQ2b1j4NEsJo1Ff8FomW/SM8XjPw0iEMo1de8xaKb8gG3Egje7VViWlkgw7gFGrFDTExL2rqebU8SdgEG+lm/q0qBf//ZHMlTwo+HuLiK8rtPV2BEEMlkjJqXbeswocNMevAhl+x8R4JIUsRBgElgKYY2gIhN/CcEGray9Px2i/fcO9cTLQiR4ckkh3uV5yE7s6thAJem4eHwneTcgAhtZeHPRsJVnDNtNKoQpCy5ah91EB8pnkwILN1BspQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xDMgyNEOzXHbdVbMJurDT4M2ATNWTzSqOYVWQUbBWw0=; b=aTcdaBjs1O0YsqNrOYpj5faxnWgv90b9j4vOkLeJGRzl6DOWZk+cgRkFxy9WwXYjU9VbruNx2VZU16611Gcj89A991g7Zuwqhvfwg/5lW14i5F2m4CjIytD8ta9tcF8/WfxUPmWD14a2Hn5twi8RbdIoZHWrLcXypzCVCyabvlA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5096.namprd11.prod.outlook.com (2603:10b6:510:3c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Thu, 25 Nov 2021 16:52:10 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.030; Thu, 25 Nov 2021 16:52:10 +0000 Message-ID: Date: Thu, 25 Nov 2021 16:52:04 +0000 Content-Language: en-US From: Ferruh Yigit To: Apeksha Gupta , CC: , , , , , Thomas Monjalon References: <20211113043141.18888-2-apeksha.gupta@nxp.com> <20211115071940.12942-1-apeksha.gupta@nxp.com> <3ed88d13-fd60-60f8-defa-a7b0fab70261@intel.com> Subject: Re: [PATCH v11 0/5] drivers/net: add NXP ENETFEC driver X-User: ferruhy In-Reply-To: <3ed88d13-fd60-60f8-defa-a7b0fab70261@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB9PR05CA0018.eurprd05.prod.outlook.com (2603:10a6:10:1da::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR05CA0018.eurprd05.prod.outlook.com (2603:10a6:10:1da::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.19 via Frontend Transport; Thu, 25 Nov 2021 16:52:08 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc9d089c-05dd-408e-fb39-08d9b033ec17 X-MS-TrafficTypeDiagnostic: PH0PR11MB5096: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 67iNs7TR8tKXBquwBz6hMgExGXlIKRMux/6Q2uN7eFeXVsakb1MpVDPM8zaciCeRJeXMt3t/R8f0yrMV+p6JEEUMOHwaXzTXQmzyUHBPDIQAgX/VQi2fQy1D6B6yI3IiXjYxU+9H7NIQrJ7I8QHFvFD8FQiDVh/0dN4k2wl7zfRBhxZ8ARGkoa5eIw48TIkHydGr9jirfi3ArPLAgXvMDd2J7TOq+SEKQOSw/qx9RLQvmVA4qyuieqI+ja9+g7Ru4j5aTUEHQ/PzMuB+URTCS4Cfg8PebF9HYT43UI3E6Khw0DCjiAzuETY92CD9XvsmAPTWCbEfJInyutCqc9AkXH7qpucwuUVjm0QW4NOEcb73jzdReQzg5GZD7cQPDxEksYrTVQgM9Fta75GlgAF6cUJQ7kK0k4y/+ih5pvGqV+4pYC44QDp32O5zT92NPDlAieg7DvtmJAGIgmx7e83hwF2eqrfNYPmAJFPgBfy/btKSl0etG7zmn0dcNbT1EpG20zYOJFVC8v0E2xew4Sh+ajLcmKVmKvSrzsrAhAjHVxnfohWtnwAo7G0wtIEmDFJhPwempkWZ4fzBjTfDjTHIFKtct1TuCrZkR5EqxjQtuEDOztHkdqpvY7EbysQZoHndpWzlUEe0B/Mc48+nAynk96xnMT6L+H3t4JiA46lFK6CEbYJJpAx/UaOWrZ9gjiJOmAwc1/yVdvceNyc8d8JaF2h6kEo2CbGFcWEQ19HFVZx7unbq8NDMYtQA64iSDml0IFQsQIZDnNlnX6U1kHLC+knkADU3UQyxwE/UrnlT8LdwwMy72719xIdY1zz8VC70eccUPCu+qk3nibNjGFfPsQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(8676002)(86362001)(53546011)(2906002)(316002)(66946007)(16576012)(956004)(6486002)(82960400001)(2616005)(83380400001)(44832011)(508600001)(966005)(31696002)(26005)(31686004)(4326008)(5660300002)(186003)(8936002)(66556008)(66476007)(38100700002)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnJwVnh2RWJ0UUM4bERXTVRjc0kycWZhWFA2RG5RaWZjV2F3NmxmVEJKcVd0?= =?utf-8?B?cWcrdGFsVlV2azZqRFNPdTQ0U1BGSFZVREM3MzJ6VDZ0RzZHdjdLOGVMNUY1?= =?utf-8?B?Y29JSDNCMUtIQjRNZy9hQXhZRVJDWitwdS81Yjk2bUJLeENkUHV1bU5ISVhp?= =?utf-8?B?YVpEWitvTzdNT1FDV0N4WmkwaXIzS0N1ZzVVT05MSVhHaUV3MmYxZ3JJWmpz?= =?utf-8?B?cVd4Z0E1SEt5K1JGaWdkeU1jYUQya2haSnRDSXhoRWNJVFRIWUlCeWJUdDQz?= =?utf-8?B?Zy9MTlVpeU5Bc0tLWkh3aThncWl5UWJWYlhuOHRuZFFycStFNjhkWnV0UFhT?= =?utf-8?B?YW9MTVlZVzZ4a3pscmJxcTVGcUV1OTY2U2hQYTBkSVBDMUdXNFZ3WkZFU0p5?= =?utf-8?B?SWVjZ0YvdUFab2lpSWxIRERZcFFaVTh2ejc5ZG90UU5mOUh3aHZ1TGVaQllv?= =?utf-8?B?RFJ1ajdKRjgyUnQxTUJienRsT25jK0hGZFpZbUlLVG5vTEFjWS9PazVOSjhW?= =?utf-8?B?bFp0YlNESzNHU0MxbjZWTHBTaEZrR3hvS3IrcVJmTUU3aWlUMzllbERpWHV1?= =?utf-8?B?MDZsMkdnNnRsKzFhTnU0QlV1S1JSTzZtc2hUVzZpaHRaa0FxWnNoRG9XSlZG?= =?utf-8?B?ci9XQnhxTFZZQWs4cUw4OFNhLzFRR0djbFJSeW1FYWdTOG5XbTUxaUN1aVdR?= =?utf-8?B?SGVCejR4LzRJYklZM1JvWmNDemZ0WmNFT3NPa3ZVTkFQcUVCcTVQUXg3dXJG?= =?utf-8?B?VHRzZmxndmd1UVNJSGtzSkViMXl6LzJNMGdtRDFIekVQQ2hWZEZ5bWtJa2Vq?= =?utf-8?B?RWp1VlVROWpCRzRQdFVZcnFrSU9PQ2ZaUHlUOWxPR3dUcUg3OFN3YnpzOFpO?= =?utf-8?B?UEk1YmVmQ3lmYmJGam0rTDdjVWp6QlpsSWtPdGFrRS9ab0FNWnlvREFFY09O?= =?utf-8?B?bkFIcm5ZTldLY2wybXFPa2lZb0MrK3pmOHFNSit1SFA0U1lsRHFIY2NNY28y?= =?utf-8?B?YXYvWkFJL0ZnOW1BZnZnY3JWVk1xd0ZNaC90ZVMyTHRmd3VCRDVQeU5DSlEr?= =?utf-8?B?QkVBQlEyMGpxVXg1TzJ4eUVwdGJzL25FdGx5WjBWclBoL1BuSFBGcXJsWGFa?= =?utf-8?B?WlRVb3pZd0t3QmpoYlVHRi9lOTFVWXEwZTQzUy9Uem4vRmZjMi9iZVpFeW5a?= =?utf-8?B?WkhnNDNYYy9FNzlpZWU0K0dSVHE5eFlUbFhzYUMxdUNVUkhTL0ZzV1VrWlE5?= =?utf-8?B?eSt0SHhvTE9RRi9vVWpZL3RwRFZJOVd1dlFPV1hJVHBlaWRlKzFHMUNvTmQ4?= =?utf-8?B?Y1NudGh5bmU2MFE1VkNPUFRkTG5BbmpjWVdzazhLa3pNVXVGTTR5MXRGV1dD?= =?utf-8?B?djJ2RlJxTlNHQVZCQjRUa3RONjhpeDM0NkVJbFVwakFJVWltTnlock9pUloz?= =?utf-8?B?TWcwMU9RelBjeEVpcU5tSFZVYzhSR1djMjdDY3d5QkVsaEgxSkFZMGIxL1c5?= =?utf-8?B?Tld5dU11ZWs2L3VtOE5VcGNQOTl5VmduRHRCMWJHNitGWUtaN1FwZW1GcXFD?= =?utf-8?B?b1ZPc1gvd0pPb2NDYU9rd25wMDJ4UzFJTjBXOTROOHE3M0pTQlNuUWZKbWFV?= =?utf-8?B?MnkwRXhCU3FjZnhuMU9zNEQ2cFM2S0cwQWpCbVJIT01BSVJMcTM3cXdibDhE?= =?utf-8?B?QUlwajNlemFtZGN0L2duMFZic0kyUExFWVRmcmxJNmxZK2w3UUlONVp4ZWsy?= =?utf-8?B?dlhiSnpNbm4xNEpMYWZFU0dhbXhRbGxkaXk4c3hsbEU0M0NZczdtczcwV3d3?= =?utf-8?B?MGdvSnltVmVBekxKa050QTB3aHNGTTgwZ0dBL1pDbkVWMXBsTUQ0VFRNYXZF?= =?utf-8?B?ZWdzVE1ma0ZzWnRWR3VPdi9iK2l5SHZDNWVtQytWRlk4YlpzeVord25yMTE2?= =?utf-8?B?Q25pS1RDSzRXc2Q2Tk9Gai9YaFNMMlFPRHM2MnhGb2dJQW9WVmRGRFZWSTdF?= =?utf-8?B?eEVmZGpnekVoVjZVc29lQVJKSmN1QTErMHRkOXNTTTAyRE9Qbmw4MTB3WnV1?= =?utf-8?B?Vy9vblhkOHNBaDBmZWN4dkpVWUE2OTdicUFJSk1zc2pBWWhhTWlqQ0crUFpH?= =?utf-8?B?QXZhWi9HNFFYdGREKytRbTgrcHc1WWp0NFZ4SjJicVFpYjdqKzRhTUI1NHBy?= =?utf-8?Q?96UBDAPQ1rraa0DtFWUu+ZI=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: dc9d089c-05dd-408e-fb39-08d9b033ec17 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 16:52:10.2731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hT1iessB63PIUKpeImd4jpftftlwLZtlgZCiSar4bwpvT9piYrWv6BzYjLjIhWs+T28GLS8vaeqxb7KECILPmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5096 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/15/2021 3:05 PM, Ferruh Yigit wrote: > On 11/15/2021 7:19 AM, Apeksha Gupta wrote: >> This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet >> Controller) is a network poll mode driver for the inbuilt NIC found in >> the NXP i.MX 8M Mini SoC. >> >> An overview of the enetfec driver with probe and remove are in patch 1. >> Patch 2 design UIO interface so that user space directly communicate with >> a UIO based hardware device. UIO interface mmap the Control and Status >> Registers (CSR) & BD memory in DPDK which is allocated in kernel and this >> gives access to non-cacheble memory for BD. >> >> Patch 3 adds the RX/TX queue configuration setup operations. >> Patch 4 adds enqueue and dequeue support. Also adds some basic features >> like promiscuous enable, basic stats. >> Patch 5 adds checksum and VLAN features. >> >> Apeksha Gupta (5): >>    net/enetfec: introduce NXP ENETFEC driver >>    net/enetfec: add UIO support >>    net/enetfec: support queue configuration >>    net/enetfec: add Rx/Tx support >>    net/enetfec: add features >> > > For series: > Reviewed-by: Ferruh Yigit > > Series applied to dpdk-next-net/main, thanks. > > > meson warning fixed, unnecessary headers removed while merging. > Ignoring the gcc12 build error for now, please remember to visit it later. > Hi Apeksha, Hemant, Is it possible to send a test report for this new PMD [1]? Since this is a new PMD, and only vendor can test it, it will be good to record what features tested on which platform and what is the result. Otherwise we are completely blind on the status of this new piece of code. Some sample test results to help you: http://inbox.dpdk.org/dev/f5980c76-d456-03fc-e1b7-cb5f24c658c9@linux.vnet.ibm.com/ http://inbox.dpdk.org/dev/CAH-L+nOyuL4HdZVmT6GLr370vo9PV8QptCKeHUsupVUpNZ8SPw@mail.gmail.com/ http://inbox.dpdk.org/dev/CAMp7Qk=ROf4ptrWuaWdCV8GnYr1jR3ADAcGHxbNkHYSHzVUtEg@mail.gmail.com/ http://inbox.dpdk.org/dev/b2c7ed47d95a4d09b41308a826bfe0e5@intel.com/ And if possible a tested platform patch would be great, something like following, https://patches.dpdk.org/project/dpdk/patch/20211119181833.121383-1-yanx.xia@intel.com/ [1] http://core.dpdk.org/testing/#release-validation