From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4C7843357; Fri, 17 Nov 2023 19:35:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 418A1402EA; Fri, 17 Nov 2023 19:35:39 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2045.outbound.protection.outlook.com [40.107.220.45]) by mails.dpdk.org (Postfix) with ESMTP id 51BFB40285 for ; Fri, 17 Nov 2023 19:35:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P+T9CfquQ9uyLdVJQI4uWWoiGWVsLOvkvyJrNoceRfCcQgE3xUbJCkBEFdF7yOwn4jt9ugk9UI3qlVLhgB8AN7vonjkbQxDrj0SAOpcBR3RPMwTzDoevIScBAFvElbMHsqHiLfSJ0W+uAHDO5pJ2SnpLcLhBziK2KaiedKiIezC6B8ggXLJl3qSyvJbBhK4cEtEQCkWpzeCXCA+hO7+/Lq9V82ev0zWtS4WIYNtd/3RY140ykNqTbp34m905ibNKkDgXU3faaVmoMqk2IgzqAB5Cj1S+U2u+9Qda6OjtwDbPAW2LORSi8HO60WWZd7zeY9yFJ+cVJwHhSpq8od9CPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TCm5PQJdzRPETNiQeOZ+hDcKM5snI+Nb1Ppt7jG3WjU=; b=Xddb/EVVmHRZAlNsUxX0nyVJnkxuikMBTyyC3vk/VINEqj7F9yr6Z7fz9SBtd9lNgCZe371F3syuIP87v3OgUdQSUydRAwO0vJqmMPbbGl3gQT2t8ClDm6KptnOg/PKZ4DffhMB/tHLNjWNxll3VRIVcVdhMuqFFpGuC0xZ1A+G7sS9u6n1LL0ACM/khzv4Ko42clJAYbnppSaupv78+bjbTBj64Yi3cjYllvwhM3XcfbV175YEdGWeYeqkoSQpO9uO28mxuVJ8JW6ne3C91ECr4q7ycGed8ytM9HIwPeQKMs0cIvvHlaH11PiwrdIybkS2KH9TpchS77C3NF3r6nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TCm5PQJdzRPETNiQeOZ+hDcKM5snI+Nb1Ppt7jG3WjU=; b=3714hrdQoLypt3BFxcUx+E82LqCu2L5GhAmn3n6MmKbow6JE/ExrNk442rpC0AiOl57UqJ+Ce+AXT7JlF/yUf4YZYEh/Nx5x03F9mSpzMpr7ysk12gx0IPEtHQEBORTjXg3i0lDyeq1QqnVn6ROWHm2325w12zX8Moh3lvkKeNQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4278.namprd12.prod.outlook.com (2603:10b6:610:ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Fri, 17 Nov 2023 18:35:35 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7002.022; Fri, 17 Nov 2023 18:35:34 +0000 Message-ID: Date: Fri, 17 Nov 2023 18:34:59 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] net/axgbe: support TSO Content-Language: en-US To: Jesna K E , dev@dpdk.org Cc: Selwin.Sebastian@amd.com References: <20231116160326.76189-1-jesna.k.e@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231116160326.76189-1-jesna.k.e@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR5P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4278:EE_ X-MS-Office365-Filtering-Correlation-Id: 86095aba-d00c-4a4c-56d5-08dbe79bfc5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gltsh0DMAw/LCUVcoyQQgMfAblfM6H8JB+rq7hAzVB457Mw9B6ftF1wVha8KDV5/M7OwFpQ6HE/NghbOKfHxxtCV90vLLZfh539yT8GqEdy1Bv9+3wtJLdb/V+NairxL/BQJB+83xwIBMXfD2LVn7C3WNKZmNyDnS/8Hd/V6MSSXKG5w+4hyvTSjxVSHxfqEtTRP0eu8egq78zRkpM8tdrAjn64x5jvTLh62R1AMRk54odsall6sWz2mT+znBk8kb+pDUcNvkGjBhZCVqWJ2e6JtF/8mXDITydoVZ358+HW3JVc1JoO/gPfQ7aVgd5k0GqH/tWdZzE0vZ/lTr6ZbtsAgBdRnxuLjBM5kGdxV4sBxA9fcytVRAH4DZbFIqHKMtBl/+Sov6cqQT1SK+Yaa4ajV+zO0MiJKgaegSjb00de8pUCu363Eu8LyoPuLHj3Ob1ghjvxdViI4y2Lj3KwRpaa6NkY1UULlDBk3nBj3ObvIg7JVYvkLv7A7Lk5oeH4TOfhB+coxSi/0AeuGlhshoeNeZ+THY6Ru0QNRDpBn9QjHJEAD5TWy2D/6Tj1WlIjhP4c9JDI7MiPKWyWZH+4TPwcBkoq0w3i+4BcDfx06XZosI+K2Ky+QWMWTnqSis1NriKe3FbqHgBu7PO7mvPaFJw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(346002)(366004)(39860400002)(376002)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(26005)(6506007)(4326008)(8676002)(5660300002)(44832011)(8936002)(30864003)(2906002)(2616005)(66476007)(53546011)(6666004)(31696002)(86362001)(66556008)(66946007)(31686004)(38100700002)(478600001)(316002)(6512007)(6486002)(36756003)(41300700001)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3MvamFtenUyREVVZTRhTDlrVXZ5dzRmVCtsNk9MWG1xb3cwbHZ5amZERW95?= =?utf-8?B?TUlkVGtYOU9qSWlwaVN2UVlwSEpVeFZPVFBJSnI5VHRyd0gzdVAzT2VKZ0xw?= =?utf-8?B?NVQydW5qZVhDRUZIOWhNa2VuY3hKMTYrT3BNajJ1NUQ2dTRsU0h3Z0xXK2Jw?= =?utf-8?B?eGNhcFFYVi9LTWxuSWUvaDgwaUdtZjBmU3VFNjBuRWIvNml3M1RWOW5TYmN2?= =?utf-8?B?bjhIYkQyckNySXhPWUtUTVZybS9DWXU5MHdveWVEbDg2UEU1dDJUaDRUeXY3?= =?utf-8?B?ZnBEWXBpbXdrNldWVGdDUnF0eXRidldxMWJ3RXJPVnlZS0JiL1g4YUQxMlZr?= =?utf-8?B?QklLTVNOc250V0UrS2tsalcwOGx4ZFNyZUdyTnpwdmpCMGxSUm5TZG5hMkN0?= =?utf-8?B?TVVNM2FwV0JHUzJLSWw1aDZaOVV2MDNnYlk1cjA3NlRTdDVvc0xYVzJQa0NT?= =?utf-8?B?WU85cDhjVFBuUHNpQzBjRmg0N2U0T1dyd28xY1EwQnJOZ3E2Qm9Sa2EzUzJC?= =?utf-8?B?dm92VnNBa3h1UG93SC9lUzlZUGZVVUZYd21QRmxmM25qaDlTRWR4L2pGcEJN?= =?utf-8?B?VGw5RlFkNVNnUlBZVG02RGVtcFJteWtoUWxWbG5PWHZ6bVpyRWxEVkR3T0xB?= =?utf-8?B?N3A4WU11Z0M4KzhrOGlPQUx2Y1Z0TDY0bmtjdGd5ZlAwb3lseDhUODViSmtX?= =?utf-8?B?MHVWK0J6bCtrQjNxU2xjMHJJOWRURGJ4MWtWeDFDVE9sOW50UDFLaUpCaktp?= =?utf-8?B?QjhlNzBIYkpNMjlQU2N6aU1EVEx6ekNMZXRJcWxtR1hwcm9yRTZFYUR2Qy9k?= =?utf-8?B?MkEzNnhqaGVrV1RHWTY4MmEra0I5SnNsejhqSHBVSnVYcDVnaHBmVnZjaHRT?= =?utf-8?B?cmZ5RGFzQS9FbmJibkNCYWJ0Mmw4QW1RMEpycWdGSHZKQldXdnVNeWxTWW5U?= =?utf-8?B?bk01S0NzU1E3b2ZxMElIWUVyYWVySE1UbTBHOG1ic3A5N05LazBMZmo2ZHVL?= =?utf-8?B?K0xXbHNmMUdqcXU2eFBLOFVMWnlNVTVUR09QZE5ONjZMUDZqS0ZvR0lxdWJ2?= =?utf-8?B?eHBsL1VLU3dzYXppUlAwaDFBRGt2RmVBWDIzNVN3c2hQQndOMGxIYzRYYzda?= =?utf-8?B?M1YzTjVhY1V4WjNpTXkyOGo5SFJzYms2eURwUS9Sb2MvV3dRMWdVbXlYM3pR?= =?utf-8?B?SEt4MHF5Um1mdnNCZmdWSkxvb2tvQnM0UWdvRUFpdmtBalJwQlpEeE45Nmpl?= =?utf-8?B?MytDNHB2M3MwbFpGb1ZnKytTTjBjUGFBMkU1RFJOR3BYbHhRS3owYkVLR1ZG?= =?utf-8?B?SjhGcURDTUpJRjNVUkpNbmVtNW8xSVNvVFAxVWlDcUptY2E1Y0IySmtScU9y?= =?utf-8?B?dVVpVVRuUmhsaytWUFJGUGVGMVZIeHk3cHlBL0tRWjJnR0drVGFQZ0tBYVY0?= =?utf-8?B?NVM4TkNTa2lzcll4SXRoejlXVmRoV3NPTW5oazZLbTRFSkhDdzByWFN4Rm00?= =?utf-8?B?Ni9LR3BzcnF2V1J6dUhtTlNvaStrZkcyUk5YYnUvSFlxZUZZQTNhcDZxanJi?= =?utf-8?B?Y2cvVnZ0Q1VzWllUbzlSNitRWWt3RXF1QjZoa05hYzh3dFlXelRBZFJDZjRm?= =?utf-8?B?YVI2TGxHdjVhTW5KczdZdHRtQXVTR0k1cXlXbThWbTYvRlVkbHpHMlhlSndC?= =?utf-8?B?azJXSnlDMzBMYm5zckFMdWRFTmo5M3hoTEcxSFEvZWpndHY1dnVhN2tOOUtt?= =?utf-8?B?U2Z0RGJEdk91NElWSi9obXhrVmFZY2cyczBhajdqejBDdWd4VnhwakxNM2VP?= =?utf-8?B?SGJyVVY4NXVkNG9ORWxVNnVuY0ZQWWRpejhLOENQeXRYaDBxMnh2YXJveGIx?= =?utf-8?B?SEVQYkxMd2MvYWtOQ09XN3ZZV0U4QjVGQStIZXN6Mkt6TXdDYSs5MnhVNWM5?= =?utf-8?B?N1FVYjlnMjZNQUNVSFVxQml6aFBzYjZqK2NoVjdvY1Zya1pvTjJCMnhlNlhE?= =?utf-8?B?TzIxdUord1J1cGxOK0VuR1N1L3ZmQzdCL1ZBdWp1RVpxaWh1UmFKZCtxWnpV?= =?utf-8?B?Wkh2ZkpyekJKV1AwSUJTVHNGa3FlVkFoOHJEYnZmZTRjQk0ydURFTjF4T1dD?= =?utf-8?Q?VQNA=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86095aba-d00c-4a4c-56d5-08dbe79bfc5b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 18:35:34.8721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gp39pKJMWw5fktVbrtQHpJougdjxmSfVX7cYdCZelQ2jadKJQOAzSs9sLzlykOmi X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4278 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/16/2023 4:03 PM, Jesna K E wrote: > Added TSO support for axgbe PMD. > > Initial Implementation for the TSO feature support > Currently only headers transmitted to > tester receiver side > > Signed-off-by: Jesna K E > --- > doc/guides/nics/features/axgbe.ini | 1 + > drivers/net/axgbe/axgbe_common.h | 12 ++++ > drivers/net/axgbe/axgbe_dev.c | 13 +++++ > drivers/net/axgbe/axgbe_ethdev.c | 3 + > drivers/net/axgbe/axgbe_ethdev.h | 1 + > drivers/net/axgbe/axgbe_rxtx.c | 88 +++++++++++++++++++++++++----- > 6 files changed, 104 insertions(+), 14 deletions(-) > > diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini > index 5e2d6498e5..5c30c967bc 100644 > --- a/doc/guides/nics/features/axgbe.ini > +++ b/doc/guides/nics/features/axgbe.ini > @@ -7,6 +7,7 @@ > Speed capabilities = Y > Link status = Y > Scattered Rx = Y > +TSO = Y > Promiscuous mode = Y > Allmulticast mode = Y > RSS hash = Y > diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_common.h > index a5d11c5832..c30efe4c02 100644 > --- a/drivers/net/axgbe/axgbe_common.h > +++ b/drivers/net/axgbe/axgbe_common.h > @@ -161,6 +161,10 @@ > #define DMA_CH_CARBR_LO 0x5c > #define DMA_CH_SR 0x60 > > +/* Setting MSS register entry bit positions and sizes for TSO */ > +#define DMA_CH_CR_MSS_INDEX 0 > +#define DMA_CH_CR_MSS_WIDTH 14 > + > /* DMA channel register entry bit positions and sizes */ > #define DMA_CH_CR_PBLX8_INDEX 16 > #define DMA_CH_CR_PBLX8_WIDTH 1 > @@ -1232,6 +1236,14 @@ > #define TX_CONTEXT_DESC3_VT_INDEX 0 > #define TX_CONTEXT_DESC3_VT_WIDTH 16 > > +/* TSO related register entry bit positions and sizes*/ > +#define TX_NORMAL_DESC3_TPL_INDEX 0 > +#define TX_NORMAL_DESC3_TPL_WIDTH 18 > +#define TX_NORMAL_DESC3_THL_INDEX 19 > +#define TX_NORMAL_DESC3_THL_WIDTH 4 > +#define TX_CONTEXT_DESC3_OSTC_INDEX 27 > +#define TX_CONTEXT_DESC3_OSTC_WIDTH 1 > + > #define TX_NORMAL_DESC2_HL_B1L_INDEX 0 > #define TX_NORMAL_DESC2_HL_B1L_WIDTH 14 > #define TX_NORMAL_DESC2_IC_INDEX 31 > diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c > index 6a7fddffca..eef453fab0 100644 > --- a/drivers/net/axgbe/axgbe_dev.c > +++ b/drivers/net/axgbe/axgbe_dev.c > @@ -808,6 +808,18 @@ int axgbe_write_rss_lookup_table(struct axgbe_port *pdata) > return 0; > } > > +static void xgbe_config_tso_mode(struct axgbe_port *pdata) > +{ > + unsigned int i; > + struct axgbe_tx_queue *txq; > + > + for (i = 0; i < pdata->eth_dev->data->nb_tx_queues; i++) { > + txq = pdata->eth_dev->data->tx_queues[i]; > + AXGMAC_DMA_IOWRITE_BITS(txq, DMA_CH_TCR, TSE, 1); > + AXGMAC_DMA_IOWRITE_BITS(txq, DMA_CH_CR, MSS, 800); > + } > +} > + > static int axgbe_enable_rss(struct axgbe_port *pdata) > { > int ret; > @@ -1314,6 +1326,7 @@ static int axgbe_init(struct axgbe_port *pdata) > axgbe_config_rx_pbl_val(pdata); > axgbe_config_rx_buffer_size(pdata); > axgbe_config_rss(pdata); > + xgbe_config_tso_mode(pdata); > Driver namespace is 'axgbe', all other functions/variables starts with it, but new additions start with 'xgbe', what do you think rename them as 'axgbe' for consistency. > wrapper_tx_desc_init(pdata); > ret = wrapper_rx_desc_init(pdata); > if (ret) > diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c > index 3717166384..0a4901aabc 100644 > --- a/drivers/net/axgbe/axgbe_ethdev.c > +++ b/drivers/net/axgbe/axgbe_ethdev.c > @@ -12,6 +12,8 @@ > > #include "eal_filesystem.h" > > +#include > + > #ifdef RTE_ARCH_X86 > #include > #else > @@ -1237,6 +1239,7 @@ axgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | > RTE_ETH_TX_OFFLOAD_MULTI_SEGS | > RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > + RTE_ETH_TX_OFFLOAD_TCP_TSO | > RTE_ETH_TX_OFFLOAD_TCP_CKSUM; > > if (pdata->hw_feat.rss) { > diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h > index 7f19321d88..31a583c2c6 100644 > --- a/drivers/net/axgbe/axgbe_ethdev.h > +++ b/drivers/net/axgbe/axgbe_ethdev.h > @@ -583,6 +583,7 @@ struct axgbe_port { > unsigned int tx_osp_mode; > unsigned int tx_max_fifo_size; > unsigned int multi_segs_tx; > + unsigned int tso_tx; > > /* Rx settings */ > unsigned int rx_sf_mode; > diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c > index a9ff291cef..b0cafcbdda 100644 > --- a/drivers/net/axgbe/axgbe_rxtx.c > +++ b/drivers/net/axgbe/axgbe_rxtx.c > @@ -627,6 +627,9 @@ int axgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, > RTE_ETH_TX_OFFLOAD_MULTI_SEGS)) > pdata->multi_segs_tx = true; > > + if ((dev_data->dev_conf.txmode.offloads & > + RTE_ETH_TX_OFFLOAD_TCP_TSO)) > + pdata->tso_tx = true; > > return 0; > } > @@ -827,6 +830,7 @@ static int axgbe_xmit_hw(struct axgbe_tx_queue *txq, > > idx = AXGBE_GET_DESC_IDX(txq, txq->cur); > desc = &txq->desc[idx]; > + PMD_DRV_LOG(DEBUG, "tso:Inside %s /n", __func__); > This log is in datapath, please either convert it to the datapath log, which is removed on compile time if level is not required, or remove it. Looking to the message in the log, it doesn't look like something useful per packet, so I believe it can be removed. > /* Update buffer address and length */ > desc->baddr = rte_mbuf_data_iova(mbuf); > @@ -873,7 +877,6 @@ static int axgbe_xmit_hw(struct axgbe_tx_queue *txq, > AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, OWN, 1); > rte_wmb(); > > - > /* Save mbuf */ > txq->sw_ring[idx] = mbuf; > /* Update current index*/ > @@ -884,6 +887,7 @@ static int axgbe_xmit_hw(struct axgbe_tx_queue *txq, > return 0; > } > > + > Unrelated change, please drop. > /* Tx Descriptor formation for segmented mbuf > * Each mbuf will require multiple descriptors > */ > @@ -899,9 +903,26 @@ axgbe_xmit_hw_seg(struct axgbe_tx_queue *txq, > uint32_t pkt_len = 0; > int nb_desc_free; > struct rte_mbuf *tx_pkt; > + uint64_t l2_len = 0; > + uint64_t l3_len = 0; > + uint64_t l4_len = 0; > + uint64_t total_hdr_len; > + int tso = 0; > + > + /*Parameters required for tso*/ > + l2_len = mbuf->l2_len; > + l3_len = mbuf->l3_len; > + l4_len = mbuf->l4_len; > + total_hdr_len = l2_len + l3_len + l4_len; > + > + if (txq->pdata->tso_tx) > + tso = 1; > + else > + tso = 0; > > - nb_desc_free = txq->nb_desc - (txq->cur - txq->dirty); > + PMD_DRV_LOG(DEBUG, "tso::Inside %s\n", __func__); > Same comment as above for logging. > > + nb_desc_free = txq->nb_desc - (txq->cur - txq->dirty); > if (mbuf->nb_segs > nb_desc_free) { > axgbe_xmit_cleanup_seg(txq); > nb_desc_free = txq->nb_desc - (txq->cur - txq->dirty); > @@ -913,23 +934,27 @@ axgbe_xmit_hw_seg(struct axgbe_tx_queue *txq, > desc = &txq->desc[idx]; > /* Saving the start index for setting the OWN bit finally */ > start_index = idx; > - > tx_pkt = mbuf; > /* Max_pkt len = 9018 ; need to update it according to Jumbo pkt size */ > pkt_len = tx_pkt->pkt_len; > > /* Update buffer address and length */ > - desc->baddr = rte_mbuf_data_iova(tx_pkt); > - AXGMAC_SET_BITS_LE(desc->desc2, TX_NORMAL_DESC2, HL_B1L, > - tx_pkt->data_len); > - /* Total msg length to transmit */ > - AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, FL, > - tx_pkt->pkt_len); > + desc->baddr = rte_pktmbuf_iova_offset(mbuf, 0); > This is exact same with "desc->baddr = rte_mbuf_data_iova(tx_pkt);", right? Is it updated intentional? > + /*For TSO first buffer contains the Header */ > + if (tso) > + AXGMAC_SET_BITS_LE(desc->desc2, TX_NORMAL_DESC2, HL_B1L, > + total_hdr_len); > + else > + AXGMAC_SET_BITS_LE(desc->desc2, TX_NORMAL_DESC2, HL_B1L, > + tx_pkt->data_len); > + rte_wmb(); > + > /* Timestamp enablement check */ > if (mbuf->ol_flags & RTE_MBUF_F_TX_IEEE1588_TMST) > AXGMAC_SET_BITS_LE(desc->desc2, TX_NORMAL_DESC2, TTSE, 1); > > rte_wmb(); > + > /* Mark it as First Descriptor */ > AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, FD, 1); > /* Mark it as a NORMAL descriptor */ > @@ -959,19 +984,55 @@ axgbe_xmit_hw_seg(struct axgbe_tx_queue *txq, > } > rte_wmb(); > > + /*Register settings for TSO*/ > + if (tso) { > + PMD_DRV_LOG(DEBUG, "tso : Inside TSO register settings\n"); > + /* Enable TSO */ > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, TSE, 1); > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, TPL, > + ((mbuf->pkt_len) - total_hdr_len)); > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, THL, > + l4_len); > + } else { > + /* Enable CRC and Pad Insertion */ > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, CPC, 0); > Above changes default, non TSO, configuration, right? I just want to confirm if this is intentional? > + /* Total msg length to transmit */ > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, FL, > + mbuf->pkt_len); > + } > + > /* Save mbuf */ > txq->sw_ring[idx] = tx_pkt; > /* Update current index*/ > txq->cur++; > > + /*For TSO , needs one more descriptor to hold > + * * the Payload > + * * *But while adding another descriptor packets are not transmitted > + */ > Format is wrong in the above comment, but it is also not clear what it means, is it residue from development? > + > + > Extra empty line. > + idx = AXGBE_GET_DESC_IDX(txq, txq->cur); > + desc = &txq->desc[idx]; > + desc->baddr = rte_pktmbuf_iova_offset(mbuf, total_hdr_len); > + AXGMAC_SET_BITS_LE(desc->desc2, > + TX_NORMAL_DESC2, HL_B1L, (mbuf->pkt_len) - total_hdr_len); > Can't use 'mbuf->pkt_len' directly, in case it is segmented mbuf. > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, CTXT, 0); > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, OWN, 1); > + rte_wmb(); > + > + txq->cur++; > Shouldn't above block needs to be only if TSO enables, so with "if (tso) {" condition? > tx_pkt = tx_pkt->next; > > while (tx_pkt != NULL) { > idx = AXGBE_GET_DESC_IDX(txq, txq->cur); > desc = &txq->desc[idx]; > > - /* Update buffer address and length */ > - desc->baddr = rte_mbuf_data_iova(tx_pkt); > + if (tso) > + desc->baddr = rte_pktmbuf_iova_offset(mbuf, total_hdr_len); > This code iterates mbufs in chained mbuf list, and for each iteration 'tx_pkt' is the reference to current mbuf. 'mbuf' pointer is for first mbuf in the list. So above should use 'tx_pkt' to fill the address in descriptor, not 'mbuf', as original code does. And offset should be zero for 'tx_pkt'. It may be good to test chained mbufs with TSO. > + else > + /* Update buffer address and length */ > + desc->baddr = rte_mbuf_data_iova(tx_pkt); > > AXGMAC_SET_BITS_LE(desc->desc2, > TX_NORMAL_DESC2, HL_B1L, tx_pkt->data_len); > @@ -992,7 +1053,7 @@ axgbe_xmit_hw_seg(struct axgbe_tx_queue *txq, > > rte_wmb(); > > - /* Set OWN bit */ > + /* Set OWN bit */ > AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, OWN, 1); > rte_wmb(); > > @@ -1000,7 +1061,6 @@ axgbe_xmit_hw_seg(struct axgbe_tx_queue *txq, > txq->sw_ring[idx] = tx_pkt; > /* Update current index*/ > txq->cur++; > - > tx_pkt = tx_pkt->next; > } > > @@ -1015,7 +1075,6 @@ axgbe_xmit_hw_seg(struct axgbe_tx_queue *txq, > desc = &txq->desc[start_index]; > AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, OWN, 1); > rte_wmb(); > - > return 0; > } > > @@ -1061,6 +1120,7 @@ axgbe_xmit_pkts_seg(void *tx_queue, struct rte_mbuf **tx_pkts, > idx * sizeof(struct axgbe_tx_desc)); > /* Update tail reg with next immediate address to kick Tx DMA channel*/ > AXGMAC_DMA_IOWRITE(txq, DMA_CH_TDTR_LO, tail_addr); > + > txq->pkts += nb_pkt_sent; > return nb_pkt_sent; > } It may be good to drop whitespace changes to prevent noise.