From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44E05A00BE; Thu, 28 May 2020 13:46:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8FC71DB8F; Thu, 28 May 2020 13:46:54 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3AFB91DB56 for ; Thu, 28 May 2020 13:46:53 +0200 (CEST) IronPort-SDR: HnMGtYSjTqsixVAIyNiezwXmThSMHnrtdg6YHgK9+jb2j+wFh7HR8Qxmi2bIasT3tw7fY3JE3u 36+9ftEDLiMg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2020 04:46:52 -0700 IronPort-SDR: K4xywC61S/fFPJucs83cmLhWc6tGvvek4fQ6vwmUKlEfI4xzSlTqVNevua2LXsqqVR4C8Oaewk rpbzusPyDtZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,444,1583222400"; d="scan'208";a="376345173" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.45.206]) ([10.252.45.206]) by fmsmga001.fm.intel.com with ESMTP; 28 May 2020 04:46:50 -0700 To: Dmitry Kozlyuk , dev@dpdk.org Cc: Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Bruce Richardson References: <20200428235015.2820677-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-5-dmitry.kozliuk@gmail.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 28 May 2020 12:46:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200525003720.6410-5-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 04/11] eal/mem: extract common code for memseg list initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 25-May-20 1:37 AM, Dmitry Kozlyuk wrote: > All supported OS create memory segment lists (MSL) and reserve VA space > for them in a nearly identical way. Move common code into EAL private > functions to reduce duplication. > > Signed-off-by: Dmitry Kozlyuk > --- > +eal_memseg_list_alloc(struct rte_memseg_list *msl, int reserve_flags) > +{ > + uint64_t page_sz; > + size_t mem_sz; > + void *addr; > + > + page_sz = msl->page_sz; > + mem_sz = page_sz * msl->memseg_arr.len; > + > + addr = eal_get_virtual_area( > + msl->base_va, &mem_sz, page_sz, 0, reserve_flags); > + if (addr == NULL) { > + if (rte_errno == EADDRNOTAVAIL) > + RTE_LOG(ERR, EAL, "Cannot reserve %llu bytes at [%p] - " > + "please use '--" OPT_BASE_VIRTADDR "' option\n", > + (unsigned long long)mem_sz, msl->base_va); Do all OS's support this EAL option? > + else > + RTE_LOG(ERR, EAL, "Cannot reserve memory\n"); > + return -1; > + } > + msl->base_va = addr; > + msl->len = mem_sz; > + > + RTE_LOG(DEBUG, EAL, "VA reserved for memseg list at %p, size %zx\n", > + addr, mem_sz); > + > > -#define MEMSEG_LIST_FMT "memseg-%" PRIu64 "k-%i-%i" > static int > -alloc_memseg_list(struct rte_memseg_list *msl, uint64_t page_sz, > +memseg_list_init(struct rte_memseg_list *msl, uint64_t page_sz, > int n_segs, int socket_id, int type_msl_idx) > { > - char name[RTE_FBARRAY_NAME_LEN]; > - > - snprintf(name, sizeof(name), MEMSEG_LIST_FMT, page_sz >> 10, socket_id, > - type_msl_idx); > - if (rte_fbarray_init(&msl->memseg_arr, name, n_segs, > - sizeof(struct rte_memseg))) { > - RTE_LOG(ERR, EAL, "Cannot allocate memseg list: %s\n", > - rte_strerror(rte_errno)); > - return -1; > - } > - > - msl->page_sz = page_sz; > - msl->socket_id = socket_id; > - msl->base_va = NULL; > - msl->heap = 1; /* mark it as a heap segment */ > - > - RTE_LOG(DEBUG, EAL, "Memseg list allocated: 0x%zxkB at socket %i\n", > - (size_t)page_sz >> 10, socket_id); > - > - return 0; > + return eal_memseg_list_init( > + msl, page_sz, n_segs, socket_id, type_msl_idx, true); Here and in similar places: I wonder if there's value of keeping memseg_list_init function instead of just calling eal_memseg_list_init() directly from where this is called? -- Thanks, Anatoly