From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99446A0C40; Thu, 29 Jul 2021 10:37:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82A1D40687; Thu, 29 Jul 2021 10:37:23 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 558CE40041 for ; Thu, 29 Jul 2021 10:37:21 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10059"; a="276613175" X-IronPort-AV: E=Sophos;i="5.84,278,1620716400"; d="scan'208";a="276613175" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2021 01:37:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,278,1620716400"; d="scan'208";a="664281179" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 29 Jul 2021 01:37:19 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 29 Jul 2021 01:37:19 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 29 Jul 2021 01:37:19 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 29 Jul 2021 01:37:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDB6M0TYAV4BugSbFE3zRr9tjxuw9LL1O2Y3VNzmaodJw54z8x/pVshZebWq7qCDHfawO1xIOP8Fm2h8nREVcvT0wt70PZgE/KOZqg74wzJtjYFGzWZgORBcPBNQz8NoBaaCbRz2W8RUlpqyxX+EWgSR0zLiUurD9bWvfj2OtVzXhMu7G3ZyrJF3UhhalVZ+ZjwVKswMwopq6G4sAuWHqPz+YCIHdC/MegXyGyFTweAH7mZCQ/Y7TW14cB4j6uo+YG8Zjna0rIeCy+EZc7XKuVWfGoAUB2I/FYXPdqk7i1dIKQ/4u1OCwXlcEGDSD+jrOi+Sw+TXq+7V9vL7IKB6zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jHoe2jBmCwxInBQkJLhMt8w+fiCeZVXYnWcjkPFbGxQ=; b=HPHzOUtLwD6/D19FRlnN7fa1MiJPyJiAzKmTVsREatAaXoJajddFg0n9YSB5XktMqw+XAOMm3A0vpqP/N8f4XvPBO4n1KgB2uMekkSHeJDi2tsdqrjJeuF4Upd0VeXnTYjARAqkZsKenOkMQoKtMSP63YR7ENHHSXjsNhD2K9d/HlEPfZzm2pCpsCExJ3HRHdcpU+H8pIITnUlaJ+DmLUi54ngoe3VwqqJk3DrrOIvIHC0ZJ97yuLcQuQkb1S4Lak/bgQjNX9lDLI0Q8jGQR20yekPSl0tbSlypniwKpz4OYiRzE7roq8H8/q/YAUtusAfTzKrO+xzL+x37VARsdLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jHoe2jBmCwxInBQkJLhMt8w+fiCeZVXYnWcjkPFbGxQ=; b=RcIkGufb76x0j1o7EoSTKRo5JpBvvuXgwa1Vohqwe3GpVjZ4+w3HbBGO/bwsevL3TB0waxEmoh9IF2B5rkINcaUmcb2/pch08E6+PJaUP1YrYj3zwIX9sT+DpLVZKGggYdQWy2/z47LnvZH11NgSlQ4RRjyhvoR/tYOwFWgIw/o= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by MWHPR11MB1965.namprd11.prod.outlook.com (2603:10b6:300:110::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.20; Thu, 29 Jul 2021 08:37:15 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4d2e:befd:7bb1:9aa4]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4d2e:befd:7bb1:9aa4%8]) with mapi id 15.20.4373.020; Thu, 29 Jul 2021 08:37:15 +0000 To: Akhil Goyal , Tejasree Kondoj , Declan Doherty CC: Anoob Joseph , "dev@dpdk.org" , "Abhijit Sinha" , Daniel Martin Buckley , Ankur Dwivedi References: <20210713133542.3550525-1-radu.nicolau@intel.com> <20210713133542.3550525-2-radu.nicolau@intel.com> From: "Nicolau, Radu" Message-ID: Date: Thu, 29 Jul 2021 11:37:07 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: VI1PR06CA0099.eurprd06.prod.outlook.com (2603:10a6:803:8c::28) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.241] (89.136.165.37) by VI1PR06CA0099.eurprd06.prod.outlook.com (2603:10a6:803:8c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Thu, 29 Jul 2021 08:37:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de7185c7-0165-46f4-0e5a-08d9526c116a X-MS-TrafficTypeDiagnostic: MWHPR11MB1965: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hiYgHLJpv/oCcs5WTPRwDhX84xu3t2IiRReLmFGenNxftcZ5IiT3NEQ6DxNEt0cTPC+oN11sSRl+Zsjj9VRhtVixWVgvTjKtY6xhs0W60jAbyKGialr5se+y+72DDahD6jtd07tP02eiC2ycuWLqmQLl0T0bVgSK0QPQbvh3h2FYfJGHccMQWJ6JA8wyIgnKf+242tnEPPJA3JImMsPPKcRk/PXf9WxYC/dcsKjz+mCfdLMZEGVCEO/iDZhDX0v4NhUSrsAp7fr5ht19+7pfBJ/XuiozbtG0J6bwHEKGzVe0pRN5VBZWtANFlmIB5uclhV/cukV74OOyGa+Y7bdcS5fl6nDRwIW9iabSblpbWaTJu3C9jAOiaEY3pr9w+VaB1ql1XVE0hHd5At3pwIqCllG9OcFdEO8KCvd6pw0VMzAjMJGm5FrpIjTVuJWY8LX62IwoWybFUWz+ydGtCdjlTmmeFrEuGsEvO8+3DxkfAx3oFCJ9oCWZWO796r16Cvpg9AK25/KRB+Etgu/hGYwNKFYacgGlza7Q6InE4dPIkoy6NBgM3UT60ekxggd4/1bK43TF9BaNZC8Ap2tyq4QDFdk7RN6XKAPV0mbyeUNbKuTopd4gZZ4QLKt5nRUOEeaJbzphaAoU+tWf0BpqFlB4ycdBMX0VGQd40VBeZJEcgmnpRLdBd9s3DL6FY3LCiAsnpbB9XE/WDIEMWNUhK9wJ9qDKCCNwT00Gt103aanwlPyeo34sQXoEoXRW2jRh2Zo5Bzcu9QCKpMzaRIkhAg0PJ/8Syoy0rmCfTSXCMfYx8fDmZCaA1tEqR9/FykKtjFyZPBQSyHwyknMbaIIWO8v7PDzufTo6opaWzw6eWi4EwuU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(15650500001)(2616005)(956004)(8936002)(86362001)(31696002)(8676002)(186003)(36756003)(6486002)(316002)(508600001)(6666004)(31686004)(16576012)(53546011)(2906002)(66946007)(6636002)(38100700002)(110136005)(4326008)(54906003)(66556008)(966005)(66476007)(83380400001)(26005)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dytQZ1F0SjRPQWtzeFM3bTVBR2wxS2QrdWdCbjJtNklQY1RIeVNpUERXSjh3?= =?utf-8?B?cE9OVEo5aXd5TzFvcHZmQVNrVGtNaVdMZVhMeDhTYVBPQlhiL081a3NYdnRQ?= =?utf-8?B?YytIR2hHOW82RWwyM2lwc0RMa0JLTzJQb3JMUVhjWktxb2hobjNCT3k5WWRE?= =?utf-8?B?S2lnaVZDY2s0ektPSnRhZFJMNS91N2pxcUlERmhPeFlmNnRubkpzQXVhWFAx?= =?utf-8?B?dlFKWmFOMmNIZ1BHdEJQVFliNEo2RTdoY2FSOVpLdnNaSjM0VGJleEVabCsy?= =?utf-8?B?dWgyUHFacWQ4QitmTmNWRUFoYnpyTHhRMC9JMTBpek5RTHdDamM2OVlmK0Jy?= =?utf-8?B?ajdUSDdzbTY2R3N3cytmbzJLRE1zcXZyTFFEc1pBQlUrRHZUaUh1azYwSHVl?= =?utf-8?B?c1pySlN6MTJ4cENNUlBmYlMvOUsrRVlTQjVaY3hlVUtDRkVOUGRheFVOVTJ0?= =?utf-8?B?LzVmclo3NGF2OWdwdVRUaGhTbXJ4NmVTVVdmK0lnOWIrc0RnZWNkZThyRU9p?= =?utf-8?B?VG0wdmh4blZKZ3ZWU0g4UzRLYUd5cjhCU2N3cVFQbUphTXJQM3VMdG9jcnFX?= =?utf-8?B?ekh2OTZINTNtekVjYWhRVVpKQy91UXJ5MXNwWUxJR1AyaEllM2NEUlRJMTBh?= =?utf-8?B?eVljSWtlSHpSV2REekpQNk5uTkZBRURacVFLMzdkYStNckhxMkVuQlVEaHZZ?= =?utf-8?B?NGo5UStzV3FsOXF4YU96bTF1b1hRR2pyU1RFaEFiZGg5dk5vTHJad0FUaHdx?= =?utf-8?B?c2E0L2x2YXYrVEZaTytxQlorVmJJOWpxaFVuMEJOM1hXZW0wMFZtc08rM0Uv?= =?utf-8?B?ekxmeG9qNDFUNWFlc3EyRHV2aWV4V21GdE9USXRCVytFaGl4TU9TczdFdG5i?= =?utf-8?B?NHVZcE9telVtZFlwZzl2dFY2QnR1UVg1U3RDNk1ZNnVDUUFoWFZiemw2SW01?= =?utf-8?B?bm1WUUxUZU9NRmFCeDFHR042Q0s0TXdabGd0bFFUWDJKcFQ1RVBlUU1iUk5a?= =?utf-8?B?dUhlaVE2MDRDQXQwcERVejlJN01lUmdzcDQrYnVNaUtncUY2MFpxblQwcGpY?= =?utf-8?B?TEthVVNiZzlWbjkvUTFORTZSMlFEc1BaamdXTy9uUVY5d1BodnZoNGxIZy91?= =?utf-8?B?QU5vYTB1RkFRTVo3NGpZeUtuVmxKZFExTDlRUERjQlYzcnQ1T2M2LzlRMG5y?= =?utf-8?B?dVpyZFdGdWRrdHQvWFQ0WGp4TUV3aUxFdkNqc1RtZ3o3ZkU2Z0ptVzdkMVZO?= =?utf-8?B?RmtMQjdTWFl6R1RiNENCRjJTNk9Xcm9XdzBkMG5XU1phTDRRZ01Ca0lVTWVO?= =?utf-8?B?TXV6TEdxampUM0dVTHp2VFhNMnNXMlFBMm9QWmxjZVU2TWJ5bVp0MXpieGlo?= =?utf-8?B?NHowSkw1UllwR0preWhaTXV5d3FBUFgwY2F6WjRwMks5Yzh5SUFVUXRCUWJJ?= =?utf-8?B?TnRHeEJtdEdEVFFxK3ZCSEJ6bjZjMnVpOS9HVHVoeEVTTEdtTEZCMnNyeThE?= =?utf-8?B?NE1DZ1c5NmNQNWNrWmpwTk5tcFF1NGozUFhGZWpob2NmZXo0NHVoM0FqazVN?= =?utf-8?B?YXdaNUxEUEc4dTh4MjJydWtyU3JKS3FHRGl2VDAvZnZ2UEI5RDRuc09UYm1y?= =?utf-8?B?Tm9uMHFHT0lYOURkQm0wR3V5STZCcXpkcmNoaDVWVXJYZWxFUDNxNWYvUFNq?= =?utf-8?B?d2c5Y0NPWEp4NDFTVjNWVnVkTWJQdUpTNGVWQ09wbWlJS21JSVJwYVN0YXc5?= =?utf-8?Q?UnAeukcTBlvmWdnj/7UZe1r44NnO/cOxL7ujf68?= X-MS-Exchange-CrossTenant-Network-Message-Id: de7185c7-0165-46f4-0e5a-08d9526c116a X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 08:37:15.3377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zEpHvR+HtV9GlUPlRI0gteN4o3/eGeI+zwtLr5WDsc2Bid4EcSFatF3p6bCCX2HkG61y0/v1M/UDCPqOhjr2Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1965 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH 01/10] security: add support for TSO on IPsec session X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, thanks for reviewing. I'm OOO at the moment, I will send an updated patchset next week. On 7/27/2021 9:34 PM, Akhil Goyal wrote: >> Allow user to provision a per security session maximum segment size >> (MSS) for use when Transmit Segmentation Offload (TSO) is supported. >> The MSS value will be used when PKT_TX_TCP_SEG or PKT_TX_UDP_SEG >> ol_flags are specified in mbuf. >> >> Signed-off-by: Declan Doherty >> Signed-off-by: Radu Nicolau >> Signed-off-by: Abhijit Sinha >> Signed-off-by: Daniel Martin Buckley >> --- > Can we have deprecation notice for the changes introduced in this series. > > Also there are 2 other features which modify same struct. Can we have a > Single deprecation notice for all the changes in the rte_security_ipsec_sa_options? > The notice can be something like: > +* security: The IPsec SA config options structure ``struct rte_security_ipsec_sa_options`` > + will be updated to support more features. > And we may have a reserved bit fields for rest of the vacant bits so that ABI is not broken > When a new bit field is added. > > http://patches.dpdk.org/project/dpdk/patch/20210630112049.3747-1-marchana@marvell.com/ > http://patches.dpdk.org/project/dpdk/patch/20210705131335.21070-1-ktejasree@marvell.com/