From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EE03C235 for ; Tue, 7 Aug 2018 15:16:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2018 06:16:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,455,1526367600"; d="scan'208";a="252025136" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.34]) ([10.237.221.34]) by fmsmga005.fm.intel.com with ESMTP; 07 Aug 2018 06:16:17 -0700 To: Radu Nicolau , dev@dpdk.org Cc: lei.a.yao@intel.com, pablo.de.lara.guarch@intel.com References: <1531921784-10578-1-git-send-email-radu.nicolau@intel.com> <1532685206-25950-1-git-send-email-radu.nicolau@intel.com> From: "Hunt, David" Message-ID: Date: Tue, 7 Aug 2018 14:16:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1532685206-25950-1-git-send-email-radu.nicolau@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fw-power: do not exit on power lib init failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Aug 2018 13:16:20 -0000 On 27/7/2018 10:53 AM, Radu Nicolau wrote: > Do not exit the application if power library fails to initialize > or high performance cores configuration cannot be used. > > Signed-off-by: Radu Nicolau > --- > v2: updated init_power_library to return error code if any core init fails > > > examples/l3fwd-power/main.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index d15cd52..e73b853 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -1638,11 +1638,13 @@ init_power_library(void) > for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { > if (rte_lcore_is_enabled(lcore_id)) { > /* init power management library */ > - ret = rte_power_init(lcore_id); > - if (ret) > + int cpi_ret = rte_power_init(lcore_id); > + if (cpi_ret) { > RTE_LOG(ERR, POWER, > "Library initialization failed on core %u\n", > lcore_id); > + ret = -1; > + } > } > } > return ret; > @@ -1683,10 +1685,10 @@ main(int argc, char **argv) > rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n"); > > if (init_power_library()) > - rte_exit(EXIT_FAILURE, "init_power_library failed\n"); > + RTE_LOG(ERR, POWER, "init_power_library failed\n"); > > if (update_lcore_params() < 0) > - rte_exit(EXIT_FAILURE, "update_lcore_params failed\n"); > + RTE_LOG(ERR, POWER, "update_lcore_params failed\n"); > > if (check_lcore_params() < 0) > rte_exit(EXIT_FAILURE, "check_lcore_params failed\n"); Hi Radu, I think this patch needs to be seen as a Fix instead of a patch. The patch that introduced the API to query the power capabilities of a core moved around some functionality that now causes the application to exit earlier than previously was the case, making problems for the test framework. I think if you added some explanation around this, and the following line, it would be fine: Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options") Regards, Dave.