From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B2DC02BA2 for ; Thu, 30 Jun 2016 09:45:27 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 30 Jun 2016 00:45:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,550,1459839600"; d="scan'208";a="727238681" Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.228.169]) ([163.33.228.169]) by FMSMGA003.fm.intel.com with ESMTP; 30 Jun 2016 00:45:24 -0700 To: Neil Horman References: <1465494421-6210-1-git-send-email-nhorman@tuxdriver.com> <1466189185-21952-1-git-send-email-nhorman@tuxdriver.com> <1466189185-21952-6-git-send-email-nhorman@tuxdriver.com> <54616833-c0cc-8e93-c9de-1580f264c57e@intel.com> <20160629161820.GB17663@hmsreliant.think-freely.org> Cc: dev@dpdk.org, Bruce Richardson , Thomas Monjalon , Stephen Hemminger , Panu Matilainen From: Remy Horton Organization: Intel Shannon Limited Message-ID: Date: Thu, 30 Jun 2016 08:45:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160629161820.GB17663@hmsreliant.think-freely.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCHv8 5/6] pmdinfo.py: Add tool to query binaries for hw and other support information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 07:45:28 -0000 On 29/06/2016 17:18, Neil Horman wrote: > On Wed, Jun 29, 2016 at 04:12:21PM +0100, Remy Horton wrote: >> 'noon, [..] >> No licence..? >> > Its BSD, same as the others, I let the README cover that. We can include > it if we must, though we have lots of examples where we haven't bothered Ok. The DPDK repo has a mix of BSD and GPL licenced files, so probably bit more critical than in other projects. > Nope, pep8 doesn't complain about this at all: > [nhorman@hmsreliant tools]$ pep8 ./pmdinfo.py > pmdinfo.py:573:80: E501 line too long (80 > 79 characters) > [nhorman@hmsreliant tools]$ Hmm.. [remy@VM tools]$ pep8 pmdinfo.py pmdinfo.py:19:1: E402 module level import not at top of file pmdinfo.py:20:1: E402 module level import not at top of file pmdinfo.py:21:1: E402 module level import not at top of file pmdinfo.py:23:1: E402 module level import not at top of file pmdinfo.py:24:1: E402 module level import not at top of file pmdinfo.py:25:1: E402 module level import not at top of file pmdinfo.py:26:1: E402 module level import not at top of file pmdinfo.py:27:1: E402 module level import not at top of file pmdinfo.py:28:1: E402 module level import not at top of file pmdinfo.py:32:1: E402 module level import not at top of file pmdinfo.py:33:1: E402 module level import not at top of file pmdinfo.py:42:1: E402 module level import not at top of file pmdinfo.py:43:1: E402 module level import not at top of file pmdinfo.py:44:1: E402 module level import not at top of file pmdinfo.py:49:1: E402 module level import not at top of file pmdinfo.py:51:1: E402 module level import not at top of file pmdinfo.py:573:80: E501 line too long (80 > 79 characters) [remy@VM tools]$ pep8 --version 1.7.0 To be fair the Python lot seem to add bucketloads of extra checks to PEP8/PyLint with every release. > As you note, none of these are catastrophic. I'm willing to fix them up, but > given, the number of iterations I've gone through for minior nits, I would > prefer to see it incorporated before I post this series again. I agree. Merge first and ask questions later.. :) ..Remy