From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D12B3A00BE; Thu, 17 Feb 2022 07:35:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CBF340150; Thu, 17 Feb 2022 07:35:04 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 73DF740042 for <dev@dpdk.org>; Thu, 17 Feb 2022 07:35:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645079702; x=1676615702; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=8HhY4/MWWFvBTpPLPbSfhF2qefSrT0ARttD6NM5Ka3k=; b=R3aKeaNiNntHs79gEqEqurlHVbWbGOdGN4pZWFi58kMjjRJsSOqor6Lr D3O6399Vyvlhxdodx5WcigI4/0fjTP0Ggr/NrWyHVJIZGUqjoHh+mU8wq 6XWvT/fKve/xS+fH0nJ/57YkFM7zn5n7Zst8nZ1A9LxF95mvVjQm1gd+c VPbIXZAlKA/5ruuLpJc+VaWwJ1vKJR7KKvHx25nSMjTpNzitMgkpc3e8b j8QhHQTKziU/sabIGaaV8rkQV53M4onwInaBWbROl4fsKy5zIpkhO4EsR Rh6rcHWzjC7PKn4dPwqfgBTBoKWOmDN3w3FKkhfZHYa7Z1Ou8p1fUMLum g==; X-IronPort-AV: E=McAfee;i="6200,9189,10260"; a="231430045" X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="231430045" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2022 22:34:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="545402111" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 16 Feb 2022 22:34:44 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 16 Feb 2022 22:34:44 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 16 Feb 2022 22:34:44 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 16 Feb 2022 22:34:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QUaMFtviET6igkl+KW01MmVodssLzDWM5qeS1rKC2Gp+FJ2MHIUaPxyvNTuK0AdHaTxYJogqIbKZJzgVMiB+OQNlhEneBg3/BwIRMg9KIAwV9oImm7RQdPyxzesscjJGM3sCMRvPUYrZgNyT1T9QM/pQ3insGaXhAYxgGiI8qBHnSstiN46W8+vTDIhn2pic92cyyuzwJru7wD/x1i5ill8XmcLUDRj9LKtuKtp5iNvVfJ/L7RD7TDD1Wuv2k7Z0EHih3hk/sgxV3gKImv4ESlbOVicxZH78dWM0rscJbyslIJvzv1LVj9cQgzq5mIuK9Ge7kYHF0NlfZOSDiY2E9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8HhY4/MWWFvBTpPLPbSfhF2qefSrT0ARttD6NM5Ka3k=; b=j7QcXsiUPcXUxKKhRhpc6KBgtGJagD3Tiwg6jQMyzo1uvs4x5UjHHQNlDuhCZl3By97nUpm/kC+/LPaWsRa23m+zI41SA9UhYik/eBiUglaEMlwmJQenLKwYVyzRnI8wZiH2XXdeB8zeTnJvgffyWRGdWdcbZIbbME6QmaE0u3BaemJQLhFI6JreCnH6k5JBUBM9Hxliw1hkAT2lIQlQQKmbyOhxN9M/i5elfOtZ0jSv1BFxzWTDfu9KyIP1cgFPx1swMQbblEIC6pMOQ8bvSaxaX+Q/7LqPRH2F9PKsRIQv+pNx80ZvYOxc488Q3QXGCpk7hlSQJUw465zlK5EbAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by BN7PR11MB2772.namprd11.prod.outlook.com (2603:10b6:406:ae::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Thu, 17 Feb 2022 06:34:41 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::417b:7df4:d3fb:2b0a]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::417b:7df4:d3fb:2b0a%3]) with mapi id 15.20.4975.020; Thu, 17 Feb 2022 06:34:41 +0000 Message-ID: <bcdf0260-9e34-caa3-8f9e-9ca98cfebc55@intel.com> Date: Thu, 17 Feb 2022 12:04:30 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace Content-Language: en-US To: Thomas Monjalon <thomas@monjalon.net> CC: <dev@dpdk.org>, <ferruh.yigit@intel.com> References: <20220123172046.1296964-1-aman.deep.singh@intel.com> <2756826.yaVYbkx8dN@thomas> <6677029b-2f32-4183-86fb-c947c6ca1134@intel.com> <3196155.AxlXzFCzgd@thomas> From: "Singh, Aman Deep" <aman.deep.singh@intel.com> In-Reply-To: <3196155.AxlXzFCzgd@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BMXPR01CA0018.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:d::28) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c516898-3893-4fd0-5f1b-08d9f1df93d3 X-MS-TrafficTypeDiagnostic: BN7PR11MB2772:EE_ X-Microsoft-Antispam-PRVS: <BN7PR11MB2772A0D9087A3A25E22F0DEFA3369@BN7PR11MB2772.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z3Dg8IdTNLGb9Z1B2u+x6QdQ9bt+g4u2yZKlxIsdS1NsfPzTbLKb1+O8+Qk9YxzQsvwad5ELZlsv+A4Oe4k8RZZUxyVwA+iW+nWcqHrhpndQOzHGMA0Rv3IVItfvsFY1ujZFPzG13ImZb3nYh/OcCG49j5vWs48PC8sSyYzFCMQ6YI8NarjJnOB6PlO1If6G1tWxaBeXEgWcBZizrSB4XK6nCabcTvYBX14DbqJaOSBpy2CXQon6VxAvSKG7fnASCKbWaT0dgto3eGnFdg8iCWobXSWPYSy/lowIv7cKHm067+Z6Wq2MXChzBsPvEgoYzUuNXycJLfKIihFT5sF3jYwjCuJDjsuAVIGGD5ozNTFgTItHEEuiJV14I5bRssjeou3w3bDu2MsLryq1j5cvUoatvoHHOC42wsM30HYXSV7SuUmd8zVez97FknnFzgj23XYt7pqWXBrzRnlzAZBC5wRbItsgaxjrcdWFydvN9vxmr+GfJdc7vUXQKDgTC4mn2yM4zgJzB0kLPVhbpdrrWMU14ILUnSoQflZYxMpyXPWuLxR5Xb5KzSSMQ5Z+tNjN3u5jJlveAxsXvzhc7Gvd5LcGwxHR35vqBToFRhZDTtXJfoCiVuR0/7NAb+gwocL/+jLa+IyxRBYVW6goVvtzX1P2T9sor4jX6JDUClHsv05wPtLcVme5W1ju9hHaSG3Vb3ISMEVuDvfDg8CEdYwEc4RP7P3/4PZN+PviPO1Cc6bEvX8LJs1p3pKfWnOBhyif X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(53546011)(5660300002)(6506007)(31696002)(36756003)(38100700002)(2906002)(82960400001)(86362001)(2616005)(6916009)(6666004)(316002)(6486002)(31686004)(508600001)(107886003)(8936002)(66476007)(66556008)(26005)(66946007)(186003)(83380400001)(8676002)(4326008)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlRGbVNQeUJGbHJ4MjBmUGdWcWZjcWdnNGNpejZPMG9XMUZBdm5tTktCVU1a?= =?utf-8?B?Mm9JdlFmNVF3S1REU2ZVN0lrZXJGY2JpRzJHMkNLZkZTdldXa09HMDF3T1pl?= =?utf-8?B?VE95NThQV2NTb2pTaGhXejEwbWltdThQYTRObVFabzF5UmJrN1h0WXViSm1k?= =?utf-8?B?bHd3a09vS1EvUitKdWNFaTdhMTRlZ1VvZXNzZ1VEM0tlbWlZeWdSTWk2cXU4?= =?utf-8?B?Y3FxdXZSYmg1YjBLR3g1UnI2Ry84cmxNK080aFpnNDZkQko2c2pueWpHT20y?= =?utf-8?B?MFoxSVZ6Z3Fhb2RUeEpvM3RtZ3c2dkFWZjk4aU5zV2k1bU5tOVczNEVxMDNB?= =?utf-8?B?L3RDMVlrZDg2UEdRUnhCYkg4cDh5Q3pxNlpKTUZyaUMxbzhUdE1KRkFGQnI5?= =?utf-8?B?TjF0TXhtUTRSclNLWmJ1VmtwN1hlbnJxZFZmUTlQRGxZVE5CbVF2Y3YrT2tV?= =?utf-8?B?T3llWWZVUTQzZXRnUE45TFhvcVJhYlZoUnVhRFkrSDFtMmMrZ0RRQmQ3T2oz?= =?utf-8?B?VW5Lbmg3QTVtWW0zaVhpbnhQdTlaYmdrNDE1R3FIYkZCUWt0QjBUVmEzODRq?= =?utf-8?B?ajYxNXE5RWRXWHZIWEJJclVpZU8vNVgwNTFBSWVpQU81UTIzU0xWVjJBSjlq?= =?utf-8?B?L0VDT0t4Q3RUdWovM0R4Sk1OTVU4NGo0T3p4dWRuSUpxQkRkRWRnN3hWa3FO?= =?utf-8?B?TUhkUno3K25lK0FBdkQ0aXpJdUpkMWZ4Rmc2b1M3dmhUMkZRSnVnbjFvV3Zu?= =?utf-8?B?dWdpcE5UUlg0VGJLSjlSQ0Q3YXdwYlYxMXB1NFptd29MeVQrejZvalZ6MFpo?= =?utf-8?B?cGpKSUFicFJTN3l4aDJrRWR6d0RwRDRud1M5SXR2VnR3WEp5UmJMcTNPNmw0?= =?utf-8?B?ZFBPRzd4TnkxakVvZTdWRmxhcXF6VTBPOXJYTGRYUGxLQktXcDQ4U0p0WS9Z?= =?utf-8?B?QmRUdEZNYjdHZWN0RTl3akpRNW1DU25YQXZMTjNMZXU4Z0lXbHNZT3lkZ3V3?= =?utf-8?B?Z0h6M0hMbXhQRWxlSjBRV1lwY2UybG1RQnBmdERLbUxxK1d2RXVSZ1NEL0Z4?= =?utf-8?B?S2R2ck9XczNPNFExVUgra2o1RU91UzBjMXh1NlhaZDNjcXdtb2tiNWJFSktV?= =?utf-8?B?aVVKOVluYytDM2UwWmR0cFBkeFc3M2phVzRaWmdlVWRDQkE1OUo1U3BmOUxQ?= =?utf-8?B?NENBTU9zNUZvSXlDeTRVZDRmREIyZm1MUmxYTzg2N2xpS0xnbndXOWJXUVlV?= =?utf-8?B?VVJyN1RHTThGWVBaY2F2UVFTaEo1V1MvSW9EbnpvVHdKMXhkTTZocUVtN2Vv?= =?utf-8?B?Vk9JekxaSXRiVHNsdHh4MzZGTFF2RGtJdFZtM2xOQTJacEFJTm1rdmhtemJv?= =?utf-8?B?THJsTm5PWk9pVGtMTE9XSXRiOU5DZ0cvQjhIRDJxK3AxRjgxOUtGS1N1WDRK?= =?utf-8?B?ZkZuRGpmbytrUDNLbG02ckhxUGVkU0Q0WXA4dHZUNjZUZXhFb0dlSXFkbEkr?= =?utf-8?B?TkRJWE55aThJMXZVaFdyRnJDUCs3VmNYVTNqRm5CbktHWFA3OTlRMC8yMmFT?= =?utf-8?B?T2JBZUw4cWdVTUwyaWlxbFdQM1JnNTdmYitzbEpGU1B1UHZsTnN5THlWOUdJ?= =?utf-8?B?Ky8zTHNiNWxmcG0vY05YcUdxZEQzcGRGc0lQSlBmMkxteUtNWng5QzJ2dnRw?= =?utf-8?B?bzJ5ditaWVBhKytudkRqK3lPOGV3Tys4ZTlLUVBmWEVCRUh5LzI0YmJFTnAz?= =?utf-8?B?eHk1M2lwVldnaENUcWdVcDFQenhkSFp2ODRYaWQweUJuN0FBd2poMWpYU1J3?= =?utf-8?B?K2dBblZKR3RnVkJjdjRQc0puWWR3bGZidHJ0N3MreXp1V1BEYWxKVlpHV1M5?= =?utf-8?B?YTZnMFV2RncwTkRFVU9RbjZnVlRyZnBsNDZxMDlMcTVjd1RZSlpGeVdaak5C?= =?utf-8?B?aitKd3hOelVjMnZkYlFxajdTRWdrdWU5WDNabkRrZHlEQUVZTURCSmVrTWxV?= =?utf-8?B?SmQ4S09tems5TGlOYm9YMFhYUWJXeXkwZ1hNQy9QbG1ka2VFbUFFMGNaVUp3?= =?utf-8?B?bFlJVjlnbDNUZ2tucVk2NzJsSDRpMVpGR3FUZkNjeGtEYTIxbk03cGVoR2ts?= =?utf-8?B?ZHJIaVozT3FaOFlVRkZ6YnFPeWdMcXlPM0Y4eFVZU1BVdjhJemY1YzJGbUF4?= =?utf-8?B?SnRIWjQreWpRUThpbk5xODF0a0hZdThrUUZrV3BqZFBXSFBCK2RhbnYyNkJK?= =?utf-8?Q?b/OVpnrpachhZ3wXOwC8ffLrkLk9WS7Excuwu17GiM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6c516898-3893-4fd0-5f1b-08d9f1df93d3 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 06:34:41.4895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wn7uWgRFMaezqpg2N4teQsbKEcXrMG3IY/tljAKrvHl6+2416Lk9wXrRnROtPCKZ4UeqWim2jE3wL+aHs18mqXcNHXzRP/2Yjgjw7PNtmDw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2772 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2/16/2022 3:47 AM, Thomas Monjalon wrote: > 15/02/2022 19:51, Singh, Aman Deep: >> On 2/11/2022 10:58 PM, Thomas Monjalon wrote: >>> 11/02/2022 09:07, Singh, Aman Deep: >>>> On 2/10/2022 9:00 PM, Thomas Monjalon wrote: >>>>> 10/02/2022 14:26, Singh, Aman Deep: >>>>>> On 2/4/2022 1:17 PM, Thomas Monjalon wrote: >>>>>>> 04/02/2022 07:13, Singh, Aman Deep: >>>>>>>> Hi Thomas >>>>>>>> >>>>>>>> On 2/3/2022 2:31 AM, Thomas Monjalon wrote: >>>>>>>>> 23/01/2022 18:20, Aman Singh: >>>>>>>>>> Added two specific exceptions for ETH_SPEED_10G >>>>>>>>>> and ETH_SPEED_25G to avoid there name change. >>>>>>>>>> Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA >>>>>>>>> Please could you explain why? >>>>>>>> These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga >>>>>>>> driver and script should no change these. >>>>>>>> There are multiple ETH_SPEED_NUM_xxx macro that need to be changed >>>>>>>> to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions. >>>>>>> Why doing this exception? What is special with ifpga? >>>>>> These two macro's are defined in 'ifpga/base/opae_eth_group.h' >>>>>> we don't intend to change these. Target is ethdev namespace only. >>>>> So we will miss future use of a deprecated macro >>>>> because ifpga is redefining it? >>>>> I think it is a wrong approach. >>>>> We should not make any exception in the check. >>>>> Instead we can just ignore the warning for ifpga. >>>> Actually ifpga is not redefining these two macro's ETH_SPEED_10G & ETH_SPEED_25G, >>>> they are unique to it. Only there prefix, matches with ethdev macro's >>>> ETH_SPEED_NUM_xxx, which caused coccinelle script to modify these to >>>> RTE_ETH_SPEED_10G & RTE_ETH_SPEED_25G. So just avoiding it by this change. >>> Would it work to restrict the match to ETH_SPEED_NUM? >> The script will change ETH_SPEED_NUM_xxx macros to RTE_ETH_SPEED_NUM_xxx >> as per the requirement. > No there is a misunderstanding. > I am asking to filter on ETH_SPEED_NUM instead of ETH_SPEED with exceptions. Yes, can do it this way. I will upload new patch with this change. > > >