From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B417C20F for ; Thu, 22 Jun 2017 13:27:42 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jun 2017 04:27:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,373,1493708400"; d="scan'208";a="100426903" Received: from foleypat-mobl1.ger.corp.intel.com (HELO [10.252.29.185]) ([10.252.29.185]) by orsmga004.jf.intel.com with ESMTP; 22 Jun 2017 04:27:40 -0700 To: Pablo de Lara , thomas@monjalon.net References: <20170620232555.82244-1-pablo.de.lara.guarch@intel.com> <20170621050733.88850-1-pablo.de.lara.guarch@intel.com> <20170621050733.88850-2-pablo.de.lara.guarch@intel.com> Cc: dev@dpdk.org From: Declan Doherty Message-ID: Date: Thu, 22 Jun 2017 12:27:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170621050733.88850-2-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/4] cryptodev: remove socket id check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 11:27:44 -0000 On 21/06/2017 6:07 AM, Pablo de Lara wrote: > Socket id parsed from the user was checked > if it was in the range of available sockets. > This check is unnecessary, as the socket specified > might not have memory anyway, so it will fail > at memory allocation. > > Therefore, the best solution is to remove this check. > > Signed-off-by: Pablo de Lara > --- > lib/librte_cryptodev/rte_cryptodev.c | 22 ---------------------- ... > Acked-by: Declan Doherty