From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69CA4A04C1; Wed, 20 Nov 2019 17:26:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32EDA9E4; Wed, 20 Nov 2019 17:26:37 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 61221271 for ; Wed, 20 Nov 2019 17:26:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 08:26:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,222,1571727600"; d="scan'208";a="237795905" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by fmsmga002.fm.intel.com with ESMTP; 20 Nov 2019 08:26:23 -0800 To: Igor Ryzhov Cc: John McNamara , Marko Kovacevic , dev , David Marchand , Vamsi Attunuru , Kiran Kumar K , Jerin Jacob References: <20191120160009.46270-1-ferruh.yigit@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Wed, 20 Nov 2019 16:26:22 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] kni: increase kernel version requirement for VA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/20/2019 4:24 PM, Igor Ryzhov wrote: > Hi Ferruh, > > There is a typo in "version incread to > 4.9.0 ...". > incread > increased Thanks Igor, I will fix in next version. > > Igor > > On Wed, Nov 20, 2019 at 7:00 PM Ferruh Yigit wrote: > >> A build error reported related to the selected >> 'get_user_pages_remote()' kernel API: >> >> .../kernel/linux/kni/kni_dev.h:113:8: >> error: too few arguments to function ‘get_user_pages_remote’ >> ret = get_user_pages_remote(tsk, tsk->mm, iova, 1 >> ^~~~~~~~~~~~~~~~~~~~~ >> >> Currently there are three version of the 'get_user_pages_remote()' >> supported, based on kernel version >> < 4.9, = 4.9, > 4.9 >> >> These version based checks are not working fine with the distro kernels >> which is the cause of reported build error. The error reported by the >> kernel version 4.8, but it is using API defined in > 4.9. >> >> To be able to take control of this, and possible more, related build >> error, increasing the minimum supported kernel version for iova=va with >> KNI to kernel version 4.9. >> >> This leaves us with single version of the kernel API and more >> manageable. >> >> Signed-off-by: Ferruh Yigit >> --- >> Cc: David Marchand >> Cc: Vamsi Attunuru >> Cc: Kiran Kumar K >> Cc: Jerin Jacob >> --- >> doc/guides/prog_guide/kernel_nic_interface.rst | 2 +- >> doc/guides/rel_notes/release_19_11.rst | 2 +- >> kernel/linux/kni/compat.h | 16 +++++----------- >> kernel/linux/kni/kni_dev.h | 10 ---------- >> lib/librte_eal/linux/eal/eal.c | 6 +++--- >> lib/librte_kni/rte_kni.c | 2 +- >> 6 files changed, 11 insertions(+), 27 deletions(-) >> >> diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst >> b/doc/guides/prog_guide/kernel_nic_interface.rst >> index c4479ffbf..848b00253 100644 >> --- a/doc/guides/prog_guide/kernel_nic_interface.rst >> +++ b/doc/guides/prog_guide/kernel_nic_interface.rst >> @@ -305,7 +305,7 @@ IOVA = VA: Support >> >> KNI operates in IOVA_VA scheme when >> >> -- LINUX_VERSION_CODE >= KERNEL_VERSION(4, 6, 0) and >> +- LINUX_VERSION_CODE > KERNEL_VERSION(4, 9, 0) and >> - EAL option `iova-mode=va` is passed or bus IOVA scheme in the DPDK is >> selected >> as RTE_IOVA_VA. >> >> diff --git a/doc/guides/rel_notes/release_19_11.rst >> b/doc/guides/rel_notes/release_19_11.rst >> index 21be600ab..45b58190c 100644 >> --- a/doc/guides/rel_notes/release_19_11.rst >> +++ b/doc/guides/rel_notes/release_19_11.rst >> @@ -299,7 +299,7 @@ New Features >> * Added IOVA = VA support for KNI, KNI can operate in IOVA = VA mode >> when >> `iova-mode=va` EAL option is passed to the application or when bus >> IOVA >> scheme is selected as RTE_IOVA_VA. This mode only works on Linux >> Kernel >> - versions 4.6.0 and above. >> + versions above 4.9.0. >> >> * Due to IOVA to KVA address translations, based on the KNI use case >> there >> can be a performance impact. For mitigation, forcing IOVA to PA via >> EAL >> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h >> index 062b170ef..339dd25a7 100644 >> --- a/kernel/linux/kni/compat.h >> +++ b/kernel/linux/kni/compat.h >> @@ -122,16 +122,10 @@ >> #define HAVE_SIGNAL_FUNCTIONS_OWN_HEADER >> #endif >> >> -#if KERNEL_VERSION(4, 6, 0) <= LINUX_VERSION_CODE >> - >> +/* >> + * iova to kva mapping support can be provided since 4.6.0, but support >> + * version incread to > 4.9.0 because of the updates in >> get_user_pages_remote() >> + */ >> +#if KERNEL_VERSION(4, 9, 0) < LINUX_VERSION_CODE >> #define HAVE_IOVA_TO_KVA_MAPPING_SUPPORT >> - >> -#if KERNEL_VERSION(4, 9, 0) > LINUX_VERSION_CODE >> -#define GET_USER_PAGES_REMOTE_API_V1 >> -#elif KERNEL_VERSION(4, 9, 0) == LINUX_VERSION_CODE >> -#define GET_USER_PAGES_REMOTE_API_V2 >> -#else >> -#define GET_USER_PAGES_REMOTE_API_V3 >> -#endif >> - >> #endif >> diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h >> index fb641b696..5e75c6371 100644 >> --- a/kernel/linux/kni/kni_dev.h >> +++ b/kernel/linux/kni/kni_dev.h >> @@ -101,18 +101,8 @@ static inline phys_addr_t iova_to_phys(struct >> task_struct *tsk, >> offset = iova & (PAGE_SIZE - 1); >> >> /* Read one page struct info */ >> -#ifdef GET_USER_PAGES_REMOTE_API_V3 >> ret = get_user_pages_remote(tsk, tsk->mm, iova, 1, >> FOLL_TOUCH, &page, NULL, NULL); >> -#endif >> -#ifdef GET_USER_PAGES_REMOTE_API_V2 >> - ret = get_user_pages_remote(tsk, tsk->mm, iova, 1, >> - FOLL_TOUCH, &page, NULL); >> -#endif >> -#ifdef GET_USER_PAGES_REMOTE_API_V1 >> - ret = get_user_pages_remote(tsk, tsk->mm, iova, 1 >> - 0, 0, &page, NULL); >> -#endif >> if (ret < 0) >> return 0; >> >> diff --git a/lib/librte_eal/linux/eal/eal.c >> b/lib/librte_eal/linux/eal/eal.c >> index b5b71500c..5879e33e5 100644 >> --- a/lib/librte_eal/linux/eal/eal.c >> +++ b/lib/librte_eal/linux/eal/eal.c >> @@ -1073,7 +1073,7 @@ rte_eal_init(int argc, char **argv) >> */ >> iova_mode = RTE_IOVA_VA; >> RTE_LOG(DEBUG, EAL, "Physical addresses >> are unavailable, selecting IOVA as VA mode.\n"); >> -#if defined(RTE_LIBRTE_KNI) && LINUX_VERSION_CODE >= KERNEL_VERSION(4, 6, >> 0) >> +#if defined(RTE_LIBRTE_KNI) && LINUX_VERSION_CODE > KERNEL_VERSION(4, 9, >> 0) >> } else if (rte_eal_check_module("rte_kni") == 1) { >> iova_mode = RTE_IOVA_PA; >> RTE_LOG(DEBUG, EAL, "KNI is loaded, >> selecting IOVA as PA mode for better KNI perfomance.\n"); >> @@ -1090,9 +1090,9 @@ rte_eal_init(int argc, char **argv) >> RTE_LOG(DEBUG, EAL, "IOMMU is not >> available, selecting IOVA as PA mode.\n"); >> } >> } >> -#if defined(RTE_LIBRTE_KNI) && LINUX_VERSION_CODE < KERNEL_VERSION(4, 6, >> 0) >> +#if defined(RTE_LIBRTE_KNI) && LINUX_VERSION_CODE <= KERNEL_VERSION(4, 9, >> 0) >> /* Workaround for KNI which requires physical address to >> work >> - * in kernels < 4.6 >> + * in kernels <= 4.9 >> */ >> if (iova_mode == RTE_IOVA_VA && >> rte_eal_check_module("rte_kni") == 1) { >> diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c >> index 86995fc81..b564482fe 100644 >> --- a/lib/librte_kni/rte_kni.c >> +++ b/lib/librte_kni/rte_kni.c >> @@ -98,7 +98,7 @@ static volatile int kni_fd = -1; >> int >> rte_kni_init(unsigned int max_kni_ifaces __rte_unused) >> { >> -#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 6, 0) >> +#if LINUX_VERSION_CODE <= KERNEL_VERSION(4, 9, 0) >> if (rte_eal_iova_mode() != RTE_IOVA_PA) { >> RTE_LOG(ERR, KNI, "KNI requires IOVA as PA\n"); >> return -1; >> -- >> 2.21.0 >> >>