From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A39DA0C41; Wed, 15 Sep 2021 10:23:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F0C94003F; Wed, 15 Sep 2021 10:23:48 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 08DDC4003C; Wed, 15 Sep 2021 10:23:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10107"; a="307805857" X-IronPort-AV: E=Sophos;i="5.85,294,1624345200"; d="scan'208";a="307805857" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 01:23:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,294,1624345200"; d="scan'208";a="516298235" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 15 Sep 2021 01:23:43 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 01:23:42 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 16:23:40 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.012; Wed, 15 Sep 2021 16:23:40 +0800 From: "Zhang, Qi Z" To: "chenqiming_huawei@163.com" , "dev@dpdk.org" CC: "Xing, Beilei" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e/base: fix the resource leakage problem Thread-Index: AQHXllZM+xR+i9FxPUGeSIsABuQXuquk6SJA Date: Wed, 15 Sep 2021 08:23:40 +0000 Message-ID: References: <20210821063008.4504-1-chenqiming_huawei@163.com> In-Reply-To: <20210821063008.4504-1-chenqiming_huawei@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e/base: fix the resource leakage problem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of > chenqiming_huawei@163.com > Sent: Saturday, August 21, 2021 2:30 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Qiming Chen > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e/base: fix the resource leakage probl= em >=20 > From: Qiming Chen >=20 > In the i40e_init_arq function, when the i40e_config_arq_regs function ret= urns > from processing failure, the previously applied arq_bufs resource is not > released, which leads to leakage. > The patch is processed in the same way as the i40e_init_asq function, > maintaining a unified coding style. >=20 > Fixes: 49ea51605be4 ("net/i40e/base: gracefully clean the resources") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Chen Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi