From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B95EA0599; Fri, 10 Apr 2020 08:26:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 513782BD8; Fri, 10 Apr 2020 08:26:41 +0200 (CEST) Received: from qrelay242.mxroute.com (qrelay242.mxroute.com [172.82.139.242]) by dpdk.org (Postfix) with ESMTP id 0087E293C for ; Fri, 10 Apr 2020 08:26:38 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay242.mxroute.com (ZoneMTA) with ESMTPA id 17162c4ceb20000d83.001 for ; Fri, 10 Apr 2020 06:26:37 +0000 X-Zone-Loop: 370565375f9dd406b6fe201033e60b0d59116f66a2ac X-Originating-IP: [168.235.111.26] Received: from galaxy.mxroute.com (unknown [23.92.70.113]) by filter003.mxroute.com (Postfix) with ESMTPS id CCA5160038; Fri, 10 Apr 2020 06:26:31 +0000 (UTC) Received: from irdmzpr01-ext.ir.intel.com ([192.198.151.36]) by galaxy.mxroute.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1jMmit-00056W-3m; Fri, 10 Apr 2020 02:01:03 -0400 To: Thomas Monjalon , Bruce Richardson , Neil Horman Cc: dev@dpdk.org, david.marchand@redhat.com References: <20200408195616.335004-1-nhorman@tuxdriver.com> <1907515.8hb0ThOEGa@thomas> <1831256.eGJsNajkDb@thomas> From: Ray Kinsella Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: Date: Fri, 10 Apr 2020 07:26:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1831256.eGJsNajkDb@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/04/2020 17:51, Thomas Monjalon wrote: > 09/04/2020 18:29, Ray Kinsella: >> On 09/04/2020 16:18, Thomas Monjalon wrote: >>> 09/04/2020 16:52, Ray Kinsella: >>>> On 09/04/2020 11:59, Thomas Monjalon wrote: >>>>> 09/04/2020 12:45, Ray Kinsella: >>>>>> On 09/04/2020 11:43, Bruce Richardson wrote: >>>>>>> On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: >>>>>>>> On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote: >>>>>>>>> On 08/04/2020 20:56, Neil Horman wrote: >>>>>>>>>> +The syntax of the ``check-abi.sh`` utility is:: >>>>>>>>>> + >>>>>>>>>> + ./devtools/check-abi.sh >>>>>>>>> >>>>>>>>> (from v1 feedback) >>>>>>>>> Could we simplify this all greatly, by telling people to use the meson/ninja build, >>>>>>>>> so they get this checking out of the box, without all the headache below? >>>>>>>>> >>>>>>>> I think bruce noted that was never merged, correct? >>>>>>>> >>>>>>> Yep, correct. :-( >>>>>> >>>>>> apologies, was there a reason? >>>>> >>>>> Because build tool job is building, not checking. >>>>> It would be wrong to make (slow) checks mandatory in all builds. >>>>> >>>>> The need is to enforce checking ABI. >>>>> The result is already published by Travis in patchwork and in an >>>>> email to the author I believe. >>>>> Not checking email and patchwork is not a good excuse. >>>>> >>>>> Patchwork must be a mandatory read for everybody for all checks >>>>> in general. Let's not give up on general CI workflow. >>>>> >>>> >>>> Thomas >>>> >>>> You are trying to solve two problems at once; CI tooling and ABI. >>>> Let's try to solve one at a time. >>> >>> No, you want to mix two problems in a single tool :-) >>> >>> >>>> 1. The ABI check, will make the build _marginally_ slower. >>>> You _should_ only need to rebuild the changes between A and B. >>> >>> Not so marginal. >>> A re-build takes less than a second. A mandatory check takes 10 secs >>> on my machine. >>> >>> >>>> 2. The meson/ninja are an order of magnitude faster than GNU Make. >>>> We can afford this check. >>> >>> I am doing such build 10 times (each target) per patch. >>> But that's not the main issue. >>> >>> >>>> 3. If we want to lessen the ABI burden and send the correct message. >>>> It should be a build blocker, contributors need to hear the message loud and clear. >>> >>> The developer needs to get or build/save the ABI reference. >>> Making such ABI reference for each target is not so obvious: >>> - all symbols must be enabled (dependencies) >>> - some fixes may be needed for some compilers >>> >>> >>>> Most important people _consuming_ DPDK will never see this message. >>>> Only people _changing_ the ABI will see it - the people we want to hear the message loud and clear. >>> >>> No, they will have issue in DPDK compilation if something in the check >>> goes wrong. We should not bother end users with internal checks. >>> >>> >>> The message is >>> a) run the check by >>> 1) setting DPDK_ABI_REF_VERSION on command line or in devel.config file >>> 2) running devtools/test-build.sh or devtools/test-meson-builds.sh >>> b) check what Travis is reporting in >>> - email to you >>> - patchwork reports >>> >>> I think Travis report is convenient to use. >>> The local check is integrated in build scripts >>> but cannot be run by default because of the reasons above. >> >> Thomas the reality on this is that people have a tendency to filter >> this messages into an email folder and don't always see them. >> >> My 2c is that this will always be a struggle unless we find a way >> to make it un-ignore-able. >> Hence my build-wiring suggestion. > > My other concern is that we will have the same issue with all checks > done in a CI. > I think the right approach is to enforce people checking CI results. Beyond asking maintainers to check, how would we enforce? > They will be used to check CI in patchwork because the patches will > be blocked. >