From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0569141CFE; Tue, 21 Feb 2023 14:30:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB835431D6; Tue, 21 Feb 2023 14:30:41 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2075.outbound.protection.outlook.com [40.107.92.75]) by mails.dpdk.org (Postfix) with ESMTP id BCC6C40E0F for ; Tue, 21 Feb 2023 14:30:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gAZu0RkMRdX3xXddTfBThjfXBIfB4fpSSA8gSCKmCdMN7SdwGgRAd1Be3dZRSZpQUb4WAHeCzhssEucfAn2kABDpR/wxRwDBysTnNmsfTWsbI8PvevTSrBU9z1u2qNOrRZgOmyd6RRbG00MwolaHWlYcpIpEaiqhajZAiBavgGoF2G+5Ft+HOp8wECO0QT3RKqjTB6fWjIS1eT726V+i4GxE/96hotzS8/s56sg3mT7dnGZvKrVh7DxWESlSKk1Gh3K34dvvJpAdXnncZodWr9jaHL74MFNbqxpVSPmZ/K/Acjtpqd6GuPINtlL5jwiZFzduvk6DCTsRkACOMKy4Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4o/olzm6bWkZEPhd/Ucf0+sf8xWpm4LCy3DPOj63Fu4=; b=Au8dqtHJIYz6qGv2bywJeLdBELFVXj87aZdIjpzPc+dcEd4YuzKa2SmaI81UR4jhuCknvjfSoztxXAo5Xy04nnzLNVQVv+3NTch7xnpVDHkezQHuvilxlTLKSYV7osp65+pA5wY1qRLQV2W+m1w79g5hOY3GqMvc6eV6Fs9Hvubux1J9ILItBKr9L2MzR5mL41RMs0aPwzeUHGkxJQvRng97Yh1QSSieD68AUIA86o5YOezJ41E7B90ZxdWPTuYkodCvq5ejzOnp0KjWixULEJqG7oUYO3vJFvtEgxF7UHYXrHn91YP39NTErnKoofH6MdwG7Ji7PGqp8tcTEvjclA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4o/olzm6bWkZEPhd/Ucf0+sf8xWpm4LCy3DPOj63Fu4=; b=Jg0C9slmcbDSh3tSI36hcQyH0h+WrqTL/xzF30TJStCKmG72926pqHJnZcBcWSUFIj5HzXaYY+KmdEkcI9hyq0QwnXK1GreXE9eSDgcfXC+J6w3/0J0z5Mn0T95piZnptVEHUrhYrh7uJ3T51tVNqPFfR00E4uC//TOxgQlMIxw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4501.namprd12.prod.outlook.com (2603:10b6:208:269::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 13:30:37 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 13:30:37 +0000 Message-ID: Date: Tue, 21 Feb 2023 13:30:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] net/af_xdp: fix integer handling issues Content-Language: en-US To: Shibin Koikkara Reeny , dev@dpdk.org, qi.z.zhang@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, john.mcnamara@intel.com Cc: ciara.loftus@intel.com References: <20230221111426.172357-1-shibin.koikkara.reeny@intel.com> From: Ferruh Yigit In-Reply-To: <20230221111426.172357-1-shibin.koikkara.reeny@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0221.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4501:EE_ X-MS-Office365-Filtering-Correlation-Id: d61305b2-7237-40c1-5ff0-08db140fd170 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: akkzglBjcsqZMqK+7Y5+ne8dw9yYTajvcni0L5rQBpcbIEV8Kk7yGXpjfygKTdN958IQGdiopRYqti4ZOaRXz5tqDpjkJZL5zw01bnrtoHpus/0VaDId2lXeg2qQWy+uSR3245kBQ1onXFKNcMNSaaDMP1ewHuYW1jtnKPDWHvefeuOy/lTHZlK5lG6BpOGh1qbaHTLjJFKz0X6rJtEYPz2QP/dq1rHOKrRZBuC13bWENcQ/2byIouEw6FU+UI9CQwxs6pcT77wOZg0qZQRjnnb8XmC7koAbsmFjlFoSJNP3PpRFDaJYwyEUXYmHPZFX+bphWlH3gHRqFIuA1aYbL4rQbQguezOEUb/rSwYuaDEiuEDBsFYVO/rQAS5MOLRyiYgj0+vElEliaI8nxD7cb6jP5niLWGZo80/riTg99ECrTRA7BxhaTia+gASCc3q3AsghBvWdgIQ5BgK8FdiHFwHxiycqpJ5qtE9SH6Q7ZjuT72KargpnKamEvS+QFCAZjLOBTndSHsKNUy7uN8rPIU3LFr5ONYnIDKFhGIW9y53D+Eysv0887m1a+1zhADSmM+PuVmXEjgdJ1CegwdtfarDO41fN4bJBDnhMj58UyYbLDuHGSWPLp/fmTg9ruM1MQvxljb3PfLv6nZxfdr8i8f0ATgYDwimoXxdmaaKHXH1jU4j3Z5OCRRwJuNtD9ggd4oWE4ak2rZR/JA/L6uWQU+EgEH2J5hbMZmqqfn8lsUY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199018)(478600001)(86362001)(2616005)(31696002)(316002)(6666004)(53546011)(6512007)(6506007)(6486002)(186003)(26005)(44832011)(4744005)(38100700002)(36756003)(2906002)(5660300002)(41300700001)(66476007)(66556008)(66946007)(8676002)(4326008)(8936002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3B2Q1NWWGNyNkUxaVZHWndJU2tUb0FpSHRDS3FMY05vM3NXd21ZYzU5dDJv?= =?utf-8?B?bk0yNXk2OVBBdWQ4YWt5Vjg3OEd6TG9tZmN5Tm1salF5aXVJSTBESXZQQkUz?= =?utf-8?B?OHFmc09VYkFSdFhjOE9UWWxvTVlMUjFEQmllbzRUdWlLZENBaThlOTYvTlVB?= =?utf-8?B?WXRqWTBPcytUcUtFNm9sUE5qV2VRZ1ljUDdDUkRqTjFaYVVscGk0TWplTTJ6?= =?utf-8?B?T1FMdW03ZE9JNVk4VzFuUElpdVVhaCtKVUJRamgzRjY3Z20wOGpIdk42Nlhv?= =?utf-8?B?S3dZTUZDQ0g1R1JLbDZtY1ZyZDZHWlI3MmhjdnFZS2xibzJ4Ry9WV3BrY2FD?= =?utf-8?B?MWNsRWFOclR4a21MTnVQZnNHVG81cmpjcHNPK01CMjVBYXhTTFBnMXp4dUJh?= =?utf-8?B?Nk5TVFY0SXZJR0QxTkxibXFPMlVGbWkvT3lhcEdMaFhxZnJqQXJyeWU5Z1Nh?= =?utf-8?B?SGdacTl5QW04UTdDOVY0V3FjM2tkbkZwN0Z1em05RFcvYUsxSU9vekpaMU05?= =?utf-8?B?amFVeUhvanRYRzNLaVBtS0YwREQvN01rUVgxbW9WYnZmcTVSVWVoeFM0Qksz?= =?utf-8?B?VUNNLzBoamh1Ris1MzltNVMzYkRySmJVMElrT0pKRGR3UHhRakx4MThoL3V4?= =?utf-8?B?bk43WThsZ1hhR2RJMnFPSEs5YlBVcWZ6OUFocVhVVGplUEJ2V3lMZlM0d3Z0?= =?utf-8?B?VytTMk1FMGNsalFObUNSbWlmR1plV0VTVFZJOVZuZWVSUWxrZnNjcEN2cUFL?= =?utf-8?B?SllnSFBNVmpPQkV4WlUxd2U2TmdTU1Ivd3R5SnQxRG0wdENmUWpZMWJ1LzFI?= =?utf-8?B?NEdmTWFNZWZPcXRsVnhKSHE4WEQwRDFQWWRQZS9iTmI4NnByMmlMZUU3UzE4?= =?utf-8?B?Y3Q3SU11QkFUSExEVHFBeHNZMS9aUmZWWk5MOUtZRnkrSFAzUDRSVFpaM1dq?= =?utf-8?B?a0FJbFd2QzFLd1hSMXhCVFltSm1rRjU3aWZnRnhIRDd3RzNDTXJMVzF6Mngz?= =?utf-8?B?M0ZYdmZ1dHErVkZsOHVvOEVMcDBXRHdyUkk3OW5zRmNKY2lnUEVtVjMxc1NX?= =?utf-8?B?UURSM1QxYUtNaDlHeVFUdmJlU3U2TWhaYWFkOGRzMWptMVo0YStzaXo3K0VK?= =?utf-8?B?b2ZxU1FhMlJFRWJpcTZ6dDA3Tm9yV3VEaitjS29XNWFsNWVhWHpDRHZlS0tp?= =?utf-8?B?OGk5WjV5Vm52S083Z0h0VVIwazRNN0Q2TThYZVM3MjR3TU84L2UrVWYxWkZX?= =?utf-8?B?VGwrVGNIalZyL2RvZHFkV0hwNFEyaDNnTHVrMkliNzl2VmhyVVd4Uy9oaUNR?= =?utf-8?B?QWN1ekRuRS9sazI3amJ0M3EyaG95djVrL1N3b1BqeTVXZG5pZDVSQzFMNkll?= =?utf-8?B?d1FEMndXZDN0TnRFRVdjN3ZRRjl3eDl2eU8ycmdsYWxDZFl6UXJod3RtRkh6?= =?utf-8?B?SkpxSkxEcXZiNTlBUjJJN2Z4dWhVQnl1ZG1PMGQzS216WXlCeE1Wa3haTFdC?= =?utf-8?B?TTJ5Y1p5eGxkMzR4eGVWWXJRaFl5TGFGUXVnZXRFdXp5c2VJZzlkS0hOekkz?= =?utf-8?B?Qmxmd3VHZEdyR3Q2MkZuSnd2eG01YnhrMnpmWXVUY0k2RHIxUkxJclZDZnp0?= =?utf-8?B?aUhBT2xnQ3JiWEpkazRVYWRvVExTZXBMNElVYi80WDFmZ0NtOTZYcEZCNHYr?= =?utf-8?B?a2tlRVdYYnNWSUZxV1hJMGlnNEpsNVV5dHM3RzBwNHdjaUN0c291cldMeDVK?= =?utf-8?B?NUY1aFpscndVbDNLMDNMdlFFcjdvcDRUQlgzOGlmZWozbjc4Tm9SN0k4ZnJE?= =?utf-8?B?M0x4bE1UZGdnSXV3OXE4OFZDSlQxZHFOUUw3ZXFwb2paRTI0cUxrQmNsK3hE?= =?utf-8?B?QTZob0c0Y1lEVDZ4NWJyVWNvY2NMbjUzZkpiM2RyOHN6dmVyN0o3Ty9BcS9p?= =?utf-8?B?ZENoV1RuNW1BZnhpdGtkTlJUUTBEM2tMQytNTWdmTVRDSWtNNndkR01nZG5X?= =?utf-8?B?UHhRcDViNmRYNzVzbC9wUDdDQ3MwOUN3RkpGQjhXSll2VERXWC9tZ3BncE9z?= =?utf-8?B?b2hzaHhTRFJvNUxkVllwUmxRaUJqQkxEQWFwaTJVeDNreEpjQ2l1WXdvUFFU?= =?utf-8?Q?DJNi3UVk8+1lQfimwsUSjj8s0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d61305b2-7237-40c1-5ff0-08db140fd170 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 13:30:37.6748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oAkmK4ixD7YSsEL0PH4sDlX8RZnn296m9N4wX0zaUXnkVH0sldCrw2yTDu++2d8Z X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4501 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/21/2023 11:14 AM, Shibin Koikkara Reeny wrote: > Fix integer handling issues (NEGATIVE_RETURNS) reported > in coverity scan. Add a check to sock variable if the > value is negative return -1. > > Coverity issue: 383245 > Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") > > Signed-off-by: Shibin Koikkara Reeny Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.