From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Stephen Hemminger <stephen@networkplumber.org>,
Martin Havlik <xhavli56@stud.fit.vutbr.cz>
Cc: Ori Kam <orika@nvidia.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Dekel Peled <dekelp@nvidia.com>, Bing Zhao <bingz@nvidia.com>,
Gregory Etelson <getelson@nvidia.com>,
Eli Britstein <elibr@mellanox.com>,
Alexander Kozyrev <akozyrev@nvidia.com>,
dev@dpdk.org, Jan Viktorin <viktorin@cesnet.cz>
Subject: Re: [dpdk-dev] [PATCH 2/4] doc: specify RTE flow create behaviour
Date: Thu, 22 Jul 2021 13:33:45 +0300 [thread overview]
Message-ID: <bd129dd3-b643-f36a-1a0c-1b586dc647eb@oktetlabs.ru> (raw)
In-Reply-To: <20210721111629.2e03cadd@hermes.local>
On 7/21/21 9:16 PM, Stephen Hemminger wrote:
> On Wed, 21 Jul 2021 17:58:14 +0200
> Martin Havlik <xhavli56@stud.fit.vutbr.cz> wrote:
>
>> The ability to create RTE flow rules, depending on
>> port status, can and does differ between PMDs.
>> Now the doc reflects that.
>>
>> Signed-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
>> ---
>> doc/guides/prog_guide/rte_flow.rst | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
>> index 2b42d5ec8c..2988e3328a 100644
>> --- a/doc/guides/prog_guide/rte_flow.rst
>> +++ b/doc/guides/prog_guide/rte_flow.rst
>> @@ -3097,6 +3097,10 @@ actually created and a handle returned.
>> const struct rte_flow_action *actions[],
>> struct rte_flow_error *error);
>>
>> +The ability to create a flow rule may depend on the status (started/stopped)
>> +of the port for which the rule is being created. This behaviour is
>> +PMD specific. Seek relevant PMD documentation for details.
>
> Any PMD specific behavior in DPDK is an anathema to application developers
> and should be considered a design flaw!
>
+1
next prev parent reply other threads:[~2021-07-22 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 15:58 Martin Havlik
2021-07-21 15:58 ` [dpdk-dev] [PATCH 3/4] doc: update bonding mode 8023ad info Martin Havlik
2021-07-26 1:39 ` Min Hu (Connor)
2021-07-21 18:16 ` [dpdk-dev] [PATCH 2/4] doc: specify RTE flow create behaviour Stephen Hemminger
2021-07-22 10:33 ` Andrew Rybchenko [this message]
2021-07-26 3:07 ` Ajit Khaparde
2021-07-26 6:46 ` Ori Kam
2021-07-26 14:52 ` Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd129dd3-b643-f36a-1a0c-1b586dc647eb@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=ajit.khaparde@broadcom.com \
--cc=akozyrev@nvidia.com \
--cc=arybchenko@solarflare.com \
--cc=bingz@nvidia.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=elibr@mellanox.com \
--cc=ferruh.yigit@intel.com \
--cc=getelson@nvidia.com \
--cc=orika@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=viktorin@cesnet.cz \
--cc=xhavli56@stud.fit.vutbr.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).