From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DEE3A0C4E; Thu, 22 Jul 2021 12:33:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AAB74014D; Thu, 22 Jul 2021 12:33:49 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C8DC240040 for ; Thu, 22 Jul 2021 12:33:47 +0200 (CEST) Received: from [192.168.100.116] (unknown [37.139.99.76]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8D0867F502; Thu, 22 Jul 2021 13:33:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8D0867F502 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1626950027; bh=ZtWZQhpy1Pc/nEA6m5M9Usd8RNdPwv5DaNHwG2oWpns=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=c4uHdzb9pWDmU+vl6S8J2k1mzEfE+QKjE7FU6CepEIRXEyzwZk5j1/6KtvGJxHACm fnUrNnEQRGtJD9ecPhfdk4FLPZ10AK35qfDZEyfccIJmv3cQEba9Oisyu0nNG3GNBp uPmLR2bvFU18zrCuFa3qcrB8jMCGA27/hG1QHE/Y= To: Stephen Hemminger , Martin Havlik Cc: Ori Kam , Ajit Khaparde , Thomas Monjalon , Andrew Rybchenko , Ferruh Yigit , Dekel Peled , Bing Zhao , Gregory Etelson , Eli Britstein , Alexander Kozyrev , dev@dpdk.org, Jan Viktorin References: <20210721155816.188795-3-xhavli56@stud.fit.vutbr.cz> <20210721111629.2e03cadd@hermes.local> From: Andrew Rybchenko Message-ID: Date: Thu, 22 Jul 2021 13:33:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210721111629.2e03cadd@hermes.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/4] doc: specify RTE flow create behaviour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/21/21 9:16 PM, Stephen Hemminger wrote: > On Wed, 21 Jul 2021 17:58:14 +0200 > Martin Havlik wrote: > >> The ability to create RTE flow rules, depending on >> port status, can and does differ between PMDs. >> Now the doc reflects that. >> >> Signed-off-by: Martin Havlik >> --- >> doc/guides/prog_guide/rte_flow.rst | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst >> index 2b42d5ec8c..2988e3328a 100644 >> --- a/doc/guides/prog_guide/rte_flow.rst >> +++ b/doc/guides/prog_guide/rte_flow.rst >> @@ -3097,6 +3097,10 @@ actually created and a handle returned. >> const struct rte_flow_action *actions[], >> struct rte_flow_error *error); >> >> +The ability to create a flow rule may depend on the status (started/stopped) >> +of the port for which the rule is being created. This behaviour is >> +PMD specific. Seek relevant PMD documentation for details. > > Any PMD specific behavior in DPDK is an anathema to application developers > and should be considered a design flaw! > +1