From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 78DB11B1A2 for ; Wed, 17 Jan 2018 17:55:07 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2018 08:55:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="10996561" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by fmsmga007.fm.intel.com with ESMTP; 17 Jan 2018 08:55:05 -0800 To: Andrew Rybchenko , dev@dpdk.org Cc: Thomas Monjalon , Shahaf Shuler References: <1515658359-1041-1-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Wed, 17 Jan 2018 16:55:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1515658359-1041-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/6] net/sfc: convert to the new offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 16:55:07 -0000 On 1/11/2018 8:12 AM, Andrew Rybchenko wrote: > May be it is too late to suggest a new API functions to ethdev, > but hopefully if the idea is accepted, it could be applied in the > current release cycle since these functions are trivial. Agreed, I think they are OK to get in even late. > > I'm not sure that rte_ethdev_version.map is updated correctly > since EXPERIMENTAL tag is present and I don't understand how it > should be handled. > > In general for the transition period from old offload API to the > new one it would be useful to convert Tx offloads to/from txq_flags > in rte_eth_dev_info_get() for default_txconf and > rte_eth_tx_queue_info_get(). Unfortunately it was lost during > new offload API patches review. However, it would require testing > for all network PMDs and we decided to follow more conservative > approach and kept code to fill in txq_flags which should be simply > removed when txq_flags are removed. > > Cc: Thomas Monjalon > Cc: Ferruh Yigit > Cc: Shahaf Shuler > > Ivan Malov (6): > ethdev: add a function to look up Rx offload names > ethdev: add a function to look up Tx offload names > net/sfc: factor out function to report Rx capabilities > net/sfc: convert to the new Rx offload API > net/sfc: factor out function to report Tx capabilities > net/sfc: convert to the new Tx offload API Series Reviewed-by: Ferruh Yigit