From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0B0ABA0A0C;
	Fri,  2 Jul 2021 15:59:59 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E87B7413DB;
	Fri,  2 Jul 2021 15:59:58 +0200 (CEST)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by mails.dpdk.org (Postfix) with ESMTP id DB48B41353
 for <dev@dpdk.org>; Fri,  2 Jul 2021 15:59:57 +0200 (CEST)
Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GGc801gxZzZnZm;
 Fri,  2 Jul 2021 21:56:48 +0800 (CST)
Received: from dggpeml500024.china.huawei.com (7.185.36.10) by
 dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.2; Fri, 2 Jul 2021 21:59:56 +0800
Received: from [127.0.0.1] (10.40.190.165) by dggpeml500024.china.huawei.com
 (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 2 Jul 2021
 21:59:56 +0800
To: Liang Ma <liangma@liangbit.com>
CC: Bruce Richardson <bruce.richardson@intel.com>, Jerin Jacob
 <jerinjacobk@gmail.com>, Jerin Jacob <jerinj@marvell.com>,
 =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>, Nipun Gupta
 <nipun.gupta@nxp.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit
 <ferruh.yigit@intel.com>, dpdk-dev <dev@dpdk.org>, Hemant Agrawal
 <hemant.agrawal@nxp.com>, Maxime Coquelin <maxime.coquelin@redhat.com>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, David Marchand
 <david.marchand@redhat.com>, Satananda Burla <sburla@marvell.com>, "Prasun
 Kapoor" <pkapoor@marvell.com>
References: <YMo1V/Trf7WH8dgN@bricha3-MOBL.ger.corp.intel.com>
 <eb8394ee-45d9-7427-88c2-9c172f424de2@huawei.com>
 <YMsrqB1ixpezlnux@bricha3-MOBL.ger.corp.intel.com>
 <YMtZn36FV2Fe9MEj@bricha3-MOBL.ger.corp.intel.com>
 <25d29598-c26d-8497-2867-9b650c79df49@huawei.com>
 <CALBAE1P37KgBpkiNEMQPCoEATyfAoenYgfoURtqtaoJayPePRg@mail.gmail.com>
 <3db2eda0-4490-2b8f-c65d-636bcf794494@huawei.com>
 <YNNLniBG8IPUhu5h@bricha3-MOBL.ger.corp.intel.com>
 <e3735fa2-0416-1f9f-ff0f-1a259c675248@huawei.com>
 <c4a0ee30-f7b8-f8a1-463c-8eedaec82aea@huawei.com>
 <YN67N8Jb5VGQmuw3@C02F33EJML85>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <bd1ef088-fc96-2020-5f5b-e784b25271df@huawei.com>
Date: Fri, 2 Jul 2021 21:59:55 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <YN67N8Jb5VGQmuw3@C02F33EJML85>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.40.190.165]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] dmadev discussion summary
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2021/7/2 15:07, Liang Ma wrote:
>>   8) One example:
>>      vq_id = rte_dmadev_queue_setup(dev, config.{HW-queue-index=x, opaque});
>>      if (vq_id < 0) {
>>         // create virt-queue failed
>>         return;
>>      }
>>      // submit memcpy task
>>      cookit = rte_dmadev_memcpy(dev, vq_id, src, dst, len, flags);
>>      if (cookie < 0) {
>>         // submit failed
>>         return;
>>      }
> IMO
> rte_dmadev_memcpy should return ops number successfully submitted
> that's easier to do re-submit if previous session is not fully
> submitted.

emm, I didn't get your point.

Welcome review the new patch, tks

>>      // get complete task
>>      ret = rte_dmadev_completed(dev, vq_id, &cookie, 1, has_error);
>>      if (!has_error && ret == 1) {
>>         // the memcpy successful complete
>>      }
>>   9) As octeontx2_dma support sg-list which has many valid buffers in
>>      dpi_dma_buf_ptr_s, it could call the rte_dmadev_memcpy_sg API.
>>   10) As ioat, it could delcare support one HW-queue at dev_configure stage, and
>>       only support create one virt-queue.
>>   11) As dpaa2_qdma, I think it could migrate to new framework, but still wait
>>       for dpaa2_qdma guys feedback.
>>   12) About the prototype src/dst parameters of rte_dmadev_memcpy API, we have
>>       two candidates which are iova and void *, how about introduce dma_addr_t
>>       type which could be va or iova ?
>>
> 
> .
>