From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 362A4A0C41; Wed, 17 Nov 2021 11:01:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C049A4068C; Wed, 17 Nov 2021 11:01:03 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 8814440040 for ; Wed, 17 Nov 2021 11:01:02 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10170"; a="220803351" X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="220803351" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2021 02:01:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="504980473" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 17 Nov 2021 02:01:00 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 02:01:00 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 02:01:00 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 17 Nov 2021 02:01:00 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 17 Nov 2021 02:01:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gy8BzbrlM36SxCP0tYJU33Ak2azbNZDHU9A+mfHc8vNVgYZ702CGrexbW8GKtuRcup3PHU6Tj9dbopg6klPwq446BI2O/woioOjlEwjjeQd5BDCEoGTOk/WWS5GBZCW7ceCa2DTRjhv+w4JvULCd8FrtOZ2wx9UQ+7VApAgJXq2QflpobuhrRsaUlkq1ZUvwd4ZOpyLR9WZWzsBzLcSwWXpQbC0wJFGBsLWYwX8D7W0pqZfukfMLvvp/tXAk2oe12Js/+Ym4WNYLNR3O90sQl2ZXjqoalKA9+v9XGO4WMzVNPE3LVOO6dN2WI4TLvb/Lj+dmCkYKTOhN5vZVzgDf9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fsynIIVHwoNcGq6XMmihiXic8BMTxXIAfFwIUquJz9A=; b=eihrif/XJZLTq+eGo4Il39VOi2eRCwRUtyULDqWnzJHEiCNYi9eZSicTrXHLT5CSpEa2e4HLD0Le+we4uSln28IAvSBGuY8SiytY6MSRHt8u3DwfBvElbsNhmbvhNe3CvnZSYYVl/yqtk+PFgMIaWXNb0gDfmrF5WsiJgIQHKEzl+ytkzcpXMOiit7jkYrA8n3+78QPVSPI86Qu5hoEhI/pmR+XUNV9R3RuUS5hCdArF73FamQLaH32zxiqoGLFF4dFcL7E5JyS2SHFp4sprEtGCaE3jFjPrJIG09ldlD2j487sH+RWJUDkjJ+JX5GmuDT3dUoamVqe0Ae67bf94EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fsynIIVHwoNcGq6XMmihiXic8BMTxXIAfFwIUquJz9A=; b=W12wsS+gex37ExCaWmu2VLm53X8fL41vUuxNtE+M5fHUK9JNEWc36vtBBxfKsLBnf6YZ5OhEGz/NuSVw3Enu46SSG9Np5dq8XAnyNTNEpiX10gZlB/qYrIOxHgc2OL4/0ZkyWTlfny4gPqrkrPBr7DIWagwefu4/cGKJE2iFsAw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5111.namprd11.prod.outlook.com (2603:10b6:510:3c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Wed, 17 Nov 2021 10:00:56 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.028; Wed, 17 Nov 2021 10:00:56 +0000 Message-ID: Date: Wed, 17 Nov 2021 10:00:47 +0000 Content-Language: en-US To: Thomas Monjalon CC: Rasesh Mody , Shahed Shaikh , Rahul Lakkireddy , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Haiyue Wang , Jiawen Wu , Jian Wang , "Maxime Coquelin" , Chenbo Xia , Olivier Matz , References: <20211110174029.614449-1-ferruh.yigit@intel.com> <7652023.1kbqhHN0E7@thomas> From: Ferruh Yigit Subject: Re: [PATCH] net: add macro for VLAN header length X-User: ferruhy In-Reply-To: <7652023.1kbqhHN0E7@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0201CA0024.eurprd02.prod.outlook.com (2603:10a6:4:3f::34) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0201CA0024.eurprd02.prod.outlook.com (2603:10a6:4:3f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Wed, 17 Nov 2021 10:00:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3506eae5-f1a6-4b2a-5a07-08d9a9b125c3 X-MS-TrafficTypeDiagnostic: PH0PR11MB5111: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1AS6S66J3tMAmjs/BcATlyX5UC2w07TSLIZ3aGqkaZXz3BPB0b/C5xXnVwdlj2amummUUJBl5jblT2cH00TfCEV+g4ovZB8Wi1aKvjT6FTFTiQ1bnr9E0hsmAokuqYubjIq1Xs7zqvzRFioNp5g2p894CY9+7gVpa3/BiohE1Z+ePMR38CiOct1Ht9lK5cpZPyla5nbh2MqgYGuOzYiWlUdNMGg+4Wot8YY7S1uUoxrvRiV2tqnIZh2OMA2aTODnsZt+JDxPD2J8KkNK3/zaKCh07QqqEQP8NJ9hF1huskeNgbf/yvb4QSLVbRbZJlEsTzNhy2iM0PCwpaIgqFhwxtJ8v0EoKWx0wMrCiMWcSQtTeVK2xBzfVNniItPjCSHaIvkyZE2bm5epkkEZNSxFuUIDOLrelk29CzlybnV/aJ0DzfMYwyVbHLLTUO0hG8dzAIk0RFX8p2D7EAo9gEUaz/gTrYchTcdmINqCz5bKCSxANwplo1hjJxFO23LCnbLl3TQN+5tKxjzT+2tIYPM3NVKv52rVCQ8vzi3nbgS+UrBkQwc0vcfT4I96usn/VT5wclptF7ul7Qy1wbT/Zwe1ZPjQMuoPy9tw3rVTzr6EFU6pC+Wzrli0ktWPb4hwswYQTqumlCAWuk4kqe9y2N2S0r8HmY9yUIZjPfcq3wR0CpEEvJzHtc2QosMbZOhRBSPD5Ywcb9RZNCZeAlAXkt8LtA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4744005)(86362001)(31686004)(54906003)(44832011)(8676002)(2906002)(6916009)(31696002)(83380400001)(66476007)(82960400001)(4326008)(66556008)(186003)(5660300002)(53546011)(316002)(508600001)(66946007)(36756003)(38100700002)(956004)(26005)(7416002)(2616005)(16576012)(6486002)(8936002)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZS9rSi9zMXR6QngwOVpQL0Y0a3ZIc1RiTXp0cFdGMWYvSDBReFVGYnQzak1s?= =?utf-8?B?KzBGVklvek5jSE5Cdi9Fbll6YnpMTUEwd2xTbkp4RzVPUnJRd240T0JkOXRl?= =?utf-8?B?T2lBMkwyRU81Vk1kZlZ0d0JFalZpaXdUb1FzMUpaeXl3SFo3cmdxNHFNSmwy?= =?utf-8?B?VkZKMmJTNjNJbXZxN2ZMQktzQXE2NDRjckFYcWd3cTVYUG9hRC94RUMwTmRQ?= =?utf-8?B?bDcxeHhxSXF3bW9DVkU0OXBCNURaSEdVRXdhcGZpUXdaRnNhb1BScDVzbVhR?= =?utf-8?B?emFrdEo0NmZYNDh4bkprYlBrelowbDhvZnZ2V0VabXB0VmVpUDhSYTR2Um5i?= =?utf-8?B?dXBjM2Q3blBFYWphaUVURnk5ZkQrSXhyNFhaUm5xSjlWZkFTNU9xVS9JczY5?= =?utf-8?B?VDd6R2pGQkQrYk8zR0t1OUxmUjh1UW0xQVdzOUR2aXFxTG9rUDBPUno3N2NF?= =?utf-8?B?SVM3b0VJZGJLUzdWOVFQN1RINERLZnNwN0NaWlBFV0ZUUGJKMUV1T1JBcDQ4?= =?utf-8?B?bDdEcHBqMk1yNjVyYUtWZkYzZ3RzM1JjMnUyVk1WWXcvOVF6KzQ3Wjl2QWVF?= =?utf-8?B?dTQ4Wnh2UlMvTkZNWC9tU0poYVpUdGxscnNFMENPTzVsa0xNZzRxL3lYdG5L?= =?utf-8?B?T0VVN0w2UlJySnZKb3V2WjFkazNmSHE2bmdmOXVOdm43NG1nL28zdlR6WW9k?= =?utf-8?B?RmRtMXVwNWJ0blFzOHp2U3I5R0tlbENuYzhxWENSMlpYTWZOcUpmcTdQL3lx?= =?utf-8?B?M1ovak16Q0k0UWJacHBZa2psNjRXZmJ6dGY1d1ZHVzZTakFBUlJEZk1hT1NH?= =?utf-8?B?TG9SVmE2R2VEUW1vdHJyWTFSWm9nNVBham80NGJKaFRqa2p1ZDFRYXRpc3pP?= =?utf-8?B?OWprYjZXV3I3bCtZSm5rU2RsWHRzaE54dmR1clJGU0lwdmZLNEVqZmJqOEVD?= =?utf-8?B?d3JxT3c3dkRjNEVKMnZwb25NUVprTHFKM05YenVvaWFrREhTQjRvRm1hd002?= =?utf-8?B?QytqNStWczNEc0pvRnl6Mk9VNmpVSi9Tc29RR0JUeFhOYVFiQnpLMHlYUjZQ?= =?utf-8?B?dVFGRkRocktJVkorejU3Qk5ONUFaT294MzNpRDhlSzhaVEdPUjNXb2ptMXJY?= =?utf-8?B?a3BqNEF4aTBkWC9hRU9aZlNwa1Z3eGpXWnJjNjBkVlAvcXFzQm4zNUZOZ1lq?= =?utf-8?B?dENQRGJPUjlMblc5YzBuUXJETGJQaG8yODF3OUJXOFdsUmVWMnZaWkpUejF4?= =?utf-8?B?Z0hyR28vNlg2eGg3a2h0WW90SEdwa1dBMWNXN2RkQnNZMyt0RXNkMlBYczYv?= =?utf-8?B?TENEY3IvVnRGTlVMM1E4dE96VTJwY0FuMHNjYk1lRnhmOEdiVFlvdVNweHR2?= =?utf-8?B?R1AyOWUrWXh3VGo4VmpEVWM4eUFzY1pqckVhMXBRR0tZbHBkRjVhUVFGbTQz?= =?utf-8?B?cUhwbysvbVd2bnVzeU9iVFZnVjA0VHRTMmdTMEh1RGpuZmJvdEZZRDZ0SGlZ?= =?utf-8?B?cDdudEgxRE5VcnRrY08wWUxuckQ0U1dyTWhwMUQwSmRmempmSHU1amsxK0d1?= =?utf-8?B?RXVyeW9jUUJHSmxNZlkvMkN5TlkvcU1JVGU5V2lMWkd5T0V0QkR5Q3F6V2xD?= =?utf-8?B?TDNaWFhWM2xiZEpqR2s0SURwREtDYlFIbDFjck9oQ3NyWnlyeGI4dUFIZTgx?= =?utf-8?B?amhpY1dLWjBYZ3BNd2l6V1RwdVZaYk8zTEt0eTJaaEpBa09XSnBXT1A1a0hs?= =?utf-8?B?Um9ld1F5a3FaTVZhaWVRNDV5UVhMQm00dXNEUTFJMU1vNU9ONHp6SmwwNGor?= =?utf-8?B?SVVhK05oNEk2TmIwUDJQdXJBdGZrODY3Nzl0QXU1VFd1QjFrL1ZVRjA0aHY3?= =?utf-8?B?UHpCZ2hEUlpMN3BTVU9BTllybVRiVzdTdTU5MjZtZFFUUHlvWDgxd0pXM0NT?= =?utf-8?B?TmFGcTArbUMwM25JTVVZancwYk9tUmdlV0RET1E4eGIwT3Z6UWdVTEQ2Zkp0?= =?utf-8?B?eFJ4K2QvbzBFSllwbTE0UHdUeCtJeVhqeDFYbE5veWh1Y1pXTjZWRTljUkl5?= =?utf-8?B?dTJSSHo0WTZac3N5VlJMTlNWbG9uWDVrYzdJSG1QRDJMYm0zNlViS0Z6VFBQ?= =?utf-8?B?cVBEU2JYRzZwOER0ZkRqbUxaM2gzdzZidXVmbC9OV2xzWVludWJmMnNTeXZY?= =?utf-8?Q?xZlgFhuJAd0Xt+Gy5rfphk0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3506eae5-f1a6-4b2a-5a07-08d9a9b125c3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 10:00:56.0915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A8Bsqtsd0hw+ao16PHNKgz8DDOZ7xay13GmIL7/s/+/hmWM0rJItUxDEKKFxDJ1dijZGoJF6qyMIAH122+AdFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5111 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/16/2021 11:14 PM, Thomas Monjalon wrote: > 10/11/2021 18:40, Ferruh Yigit: >> Multiple drivers are defining macros for VLAN header length, to remove >> the redundancy defining macro in the ether header. >> And updated drivers to use the new macro. >> >> Signed-off-by: Ferruh Yigit > [...] >> --- a/lib/net/rte_ether.h >> +++ b/lib/net/rte_ether.h >> +#define RTE_VLAN_HLEN 4 > > Please could you add a doxygen comment for this constant? > ack. >> +/** Maximum VLAN frame length, including CRC. */ >> #define RTE_ETHER_MAX_VLAN_FRAME_LEN \ >> - (RTE_ETHER_MAX_LEN + 4) >> - /**< Maximum VLAN frame length, including CRC. */ >> + (RTE_ETHER_MAX_LEN + RTE_VLAN_HLEN) > > What about QinQ? > I am just replacing hardcoded value with macro in this patch. Changing 'RTE_ETHER_MAX_LEN' may have unexpected affect, and may not be good thing to the at this stage.