From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4552EA00C4; Fri, 1 Jul 2022 15:59:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35E0240A7B; Fri, 1 Jul 2022 15:59:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8C44140156 for ; Fri, 1 Jul 2022 15:59:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656683990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGszSZTrZJvdKJGwdMhQffI+VAKOztfOT4dZ5dYIBlo=; b=YypyfrswCUuSNV1jL2lzVVbC15IZkE63L2CZEjI+zCjFwXabuPhfYIRtqG1wVMEQ/djbD2 v27jZPOUWk6BE3EIz1BE5qlI4xFRJ3msaRo6OoPAmJruIlJcApA5Y743He3oO2WnuBc5c9 Ol9M2x5+3f0Sm01Mkncf9wbE793qqfY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-342-bGdvPbvnNZuSQMPgyyc2ew-1; Fri, 01 Jul 2022 09:59:39 -0400 X-MC-Unique: bGdvPbvnNZuSQMPgyyc2ew-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2A24B1019C83; Fri, 1 Jul 2022 13:59:39 +0000 (UTC) Received: from [10.39.208.30] (unknown [10.39.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0E41B2026D64; Fri, 1 Jul 2022 13:59:37 +0000 (UTC) Message-ID: Date: Fri, 1 Jul 2022 15:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] vhost: fix unchecked return value To: Jiayu Hu , dev@dpdk.org Cc: chenbo.xia@intel.com, stable@dpdk.org References: <20220623010858.951367-1-jiayu.hu@intel.com> <20220629090706.1395614-1-jiayu.hu@intel.com> From: Maxime Coquelin In-Reply-To: <20220629090706.1395614-1-jiayu.hu@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/29/22 11:07, Jiayu Hu wrote: > This patch checks the return value of rte_dma_info_get() > called in rte_vhost_async_dma_configure(). > > Coverity issue: 379066 > Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path") > Cc: stable@dpdk.org > > Signed-off-by: Jiayu Hu > Reviewed-by: Chenbo Xia > --- > v2: > - add cc stable tag > --- > lib/vhost/vhost.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Applied to dpdk-next-virtio/main. Please propose something to protect DMA channels registration & also consider introducing a function to unregister. Thanks, Maxime