From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4896742929; Wed, 12 Apr 2023 18:03:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 194D9410F2; Wed, 12 Apr 2023 18:03:04 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2084.outbound.protection.outlook.com [40.107.96.84]) by mails.dpdk.org (Postfix) with ESMTP id AEFBC406A2; Wed, 12 Apr 2023 18:03:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mz1bsT4rJ52OZgNmbFngm06Bwq38N39XHuaG2QC0YUbTgqjfutAVPY0YDl1zlXwvicBkySz7BSo4Clz+r3yp+hJtv7FnbY1nYQUmcFChRrbFL5G1wIEev1cU4Y3L0328XWMgOcL287C5xtoUgRJkCYo3BmBkOHs4zVi62oaH7Jg90zWQDgK7uZ8GVUFVirbjOc6hhKl5zVuQlGh5XAPxdTKUF1+SF9/i5NEcrPjvBFwaMfQriHg3C6AiJKDjOAa7x6BDgwQOJQH1kCA38qmiK5tvmJeTsRNl0JCgxGjVS3gA+A2krf5ohgY5s/pqNQ2XQ8gUHvzfFdQBsbydku5rJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hc/zj90XigJjnPRpH5gbHTJbJV7JX4Nzm6tExHljQy8=; b=K953nhbRgMGs5fGA8ZP49KqD72T11pTKTgUcXj9WZDiBJf5VQpJ0EvTNh4zVjFYZk9ilSjtmKOa3t7Koj1/ev1PoEA6Y9MfdriN811MXeiXY5k8KRzFZx5i88IgYUroSedtOddLifgfSy6dDVpjZvogKYGKGSbGqjqtXZg1K2LmDucQjBrjabkmRG5SdnPVZLxxuYB9QfPyDY9ijVZIMCQqvvbWCVpL6jyM/08MW59V6MIoXuoIfhE6+kGHFy97N5BcOhvQJlzCm5DrSNMJKbXBPFGPOraYkmK3ENZfr5YYz5ZlMSsxx4YjCUiUZMwkMLhh+NMlYVgfj88wfo1RLLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hc/zj90XigJjnPRpH5gbHTJbJV7JX4Nzm6tExHljQy8=; b=JNWG0UNklAZGP/0piJ8FUaCqNhoCE8UwI89jPUeDdXLAtPvakR886ObIsyzmW8RAgsNQ7mDbDNlujQbSfia5pictiGWBFzKKj8/T/5OBYxJIDxi49aF7PAQ940hvl9+C8jmPpoLDwnweeSPVRmBF8L1FC8wSCm6sZEZoBgEkU0U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB7526.namprd12.prod.outlook.com (2603:10b6:8:112::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Wed, 12 Apr 2023 16:03:00 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7%7]) with mapi id 15.20.6298.030; Wed, 12 Apr 2023 16:03:00 +0000 Message-ID: Date: Wed, 12 Apr 2023 17:02:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/1] net/gve: update base code for DQO Content-Language: en-US To: Rushil Gupta , "Guo, Junfeng" Cc: "Richardson, Bruce" , "dev@dpdk.org" , "Zhang, Qi Z" , "techboard@dpdk.org" References: <20230411045908.844901-1-rushilg@google.com> <20230411045908.844901-2-rushilg@google.com> <2fa761ca-7b40-cf61-22cf-0078cf331f7d@amd.com> <382d5e88-0f52-863b-e20e-746b6b81c8b9@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0292.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB7526:EE_ X-MS-Office365-Filtering-Correlation-Id: 81b0a3b1-15df-4bee-da35-08db3b6f6371 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EftZ361e5hrBTDBfBV+b5boUJZTyVFWwdZKIHkKVrlxA8exhSkxPw5AsG90z1fYN2lBHKbRdT489tVL4shHu1AV2N7zuQKD/GBc7tFtEz/S5qlioPjDF8g8CjE9PNIFk44hwccRtEPowHNiG8PZMdVb7T66huzOOqfp5+tX878Onk8ulGasjf9gpRQ9UmMKIchPeXFjY6JOFlm3CqTGdiXp7vRH/RBfDBvwHRJ/TNN29xdB1EilALObAHZul4jU7CMS6UAgijZ8WBQfVRshnCpOyGj5RKgfdyPxRNE6MomB85dDDrfTURNLO3tDYOT6cZcunwqtItoRYpmeYFlaVL7r7G6kVIiDmPBYM3n+Tx3d3CLzeB8ERKSzZwEpMvUpC/GGRiJDht4SX7Q2QVvWP90F1x980yzpHBZ0HSaT5BhZvnFN+pAvuc6Ca5gsa8kSSVFUUBHxnlXtSeAU7JU6tNxGup+JQ3wZH5n+ghV7eW1yjZ7jryM2T0LWbcxtMiQF0s4KD6qa+n/O5W1ovhVXDpIx0bdgouayTIpD8dRS7zxt7ZVJLLcGlUpkcd1QwXSPEZHjGHejgErwwc7VFRjWg1++lzC2Sg32/48XiJaTRbmkhOYAQ8b+7VmCARQwW4VoXSG5INTpDii/eanjVpJIjivTxV/3BHMpdNeLsUXHanhXoiUn65oXCu784qpgfHHmf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(84040400005)(451199021)(31686004)(478600001)(31696002)(83380400001)(36756003)(86362001)(38100700002)(2616005)(2906002)(966005)(44832011)(53546011)(316002)(6506007)(110136005)(6512007)(66476007)(26005)(186003)(8936002)(66556008)(5660300002)(6666004)(41300700001)(6486002)(8676002)(15650500001)(4326008)(66946007)(54906003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1FYcndmb1cyem5WcmN3OHJKVk5Ydjh0QVhJeER0cDh5VWRXS1ZUdXpzVnNU?= =?utf-8?B?REFuRXV6azBLMWI1UjR6K212OGhoMTZERmtYTWh6VjNuSFFVRDZFT2hIdHdo?= =?utf-8?B?T1hoV1Qzdy9BQUU1d0ZVeWZKdGhvcXZrYVdZK2pqNTc1OE51TWhqUFRJYndX?= =?utf-8?B?MmFSVFRWNVMwV2g0Wnl1RUt6bUpQT0RCSlYzZ1ZRVEloblpiTjFobml3V1Q5?= =?utf-8?B?QTZCNDdLVG8vZWU0ZWk3T3ZtYUdjR0c4MUZZWHVOZ0Y5MkduTnk4M0M0SDcv?= =?utf-8?B?WksrcjVSbDZKb3cwMnhxajRVc2pKUkl6bjBZYWdydDBoYXQvMWhXSEl1MUtw?= =?utf-8?B?Ukhyd01VZ3Btb1J6dnBMRUlQZ05iUEQ5QjRJVE1ueHBlSVBKMEduSWk5L0N4?= =?utf-8?B?L0hMZk1GOTZLWjQyY29XSTlhMmJQeGRObFViYWlkQkkwK2dSK3BxSHR2N3lz?= =?utf-8?B?eHlMbG03b2MyTlFXWnZCV0drT1o2SXRhdkxud0o1L2phZWNsZFBuS29HNWkz?= =?utf-8?B?RWFZU3JrOS9wbzM3bmZlalZlUVlmREc1M081bmJkUWtrZ2pCUTJGMW1xbXJj?= =?utf-8?B?bCtqSkplU3FIdEc3T2ZNK0F1VEVQU1gxYXcrL0IzSmtrTXFkUmVXWXZISDQw?= =?utf-8?B?VHA2TCtGbGFHVlU1NnRhMlFTK3BQT1dkemNVK2NldDVBMnBDemJNU2NvVDJR?= =?utf-8?B?VTNjV1B5VDFSQzdtMU5pcFIwRng2QTBEZjR0YkFvR1c4WFdLZ3BHM1N5MnVm?= =?utf-8?B?aXYvcENWcSs0a3l6am80YlZKS3FWWEhOZUluSCtuOEpsMGIyQkRJTlBkYUNC?= =?utf-8?B?bnF5ejZmc25mY0plUURqaVFDN0N6Z0kwMjhkVVFYL0lKaWFPaVRnZnNSNnpo?= =?utf-8?B?SFpVOHJIMnVZd0pGeEdpOUNaRHdrMHZuNkQraUhvaTFRa2lhenFyUC8yekov?= =?utf-8?B?ZDRFanZONE5BZzY2YzBSZEQxUzcyY3gvRk9VZ3NZYkJLVFl5QVFvbHhjR29B?= =?utf-8?B?d2hzTFFtSnNTZ2FWUUt5RXp3d0Zoak1LZzBXNlhmVXVOSE5vRU43TUdaL2k2?= =?utf-8?B?Mm5TeVlsUVVQdk5xdThmZmhEdHh6QmgwMWpQLzE0bjdpeXVFSmxMSDIxcjd3?= =?utf-8?B?VUdJQzc3bGR0N2s0ZTFjeWtEeTkzYWZVMEFtc3dscGxMaW1BN2FJNE1DcmFu?= =?utf-8?B?R0tiSjluOG80MmZMdlhuYTFLSEpkZjNaaTdhOEFYeGJRTDBFblBNSE96Wkhz?= =?utf-8?B?SGVZMVlLR3M2S3N0T0lCSmMrT3JjbDIyTFRaeGF1SVJCV1NLV0l2RTZEZTJU?= =?utf-8?B?UE9tb3JHKzNlN2lGOTUweFFDVGs4eEVNcDZITWxUa1NlcUtqN3RyYllyaTJ4?= =?utf-8?B?SE1TNXNzbm1mQzRJUzZIRS9vMkk1NU5NV1BvMTZhdnJjVFFVNCt4KzFRck9Q?= =?utf-8?B?bHlRMWZpOWs2elFWN2ZReUVsd085ZGVXcFBUL3ZCUmoydmhVYWZPSWpYMHk0?= =?utf-8?B?N3FyV2FRcW54QjV1NEQyWklBQWFDaVN5S01CU01qdTVLbGM2WHdIRFUzcnV4?= =?utf-8?B?eTI2TTF5Tm5KMWtQK3RLdHNVaEE1c0RJV3pHRDljWGpOaXJZMjAyT1RRQ2oz?= =?utf-8?B?b2hCYnd2SERjYTRpSXZ2enFpUHQ2blE0RGx3WnBiRTliU3M2M2JhZGlRMnZa?= =?utf-8?B?Mjl6aUVyTXdMVUxvMDMvNFRQSEFScFFQWkJDMS9BeXFlSVIvS1NQWHFGMThz?= =?utf-8?B?V2lCaFQ4N1pXSlF3bms0cFZVdEczcE4wQkJnZlRWS3lxVzlxTkNiT2cvY25k?= =?utf-8?B?VDFGK21CTkcxQ3hQNkJnbVBwS0NtSDJYVUxhaWNqMk9pZDN0V0tSK2V6cFAr?= =?utf-8?B?b0wxZE0vbCtYY1VRVEhHOEM1RUZLYTlBTTZVQnJqa05ZeDNHL2Q4K0k0a3N3?= =?utf-8?B?cllwUGNrekFaVml5K2FURXlETTByZG1KYy9vVS9kR0gzZnNoYzlrRW1ac0x3?= =?utf-8?B?MGJRa21LTldLSzJPNVFLZDc3NjlZbTM4SVA2aWVLeVBlVXJ3QkdFcVBYZ3Y3?= =?utf-8?B?NzlWNE1rY3FOLzJBbmRwaVYvUHhDSTZmRVFGREFJRWFrU1hVY3Vxb1NuOGpp?= =?utf-8?Q?Xm1fy9jLDfyWQIo1HSYacidOu?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81b0a3b1-15df-4bee-da35-08db3b6f6371 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 16:03:00.1542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qz3KO5+t3EKsf4Q1yVBopS7SCar+ltNSG7aAdyJcVr4S1i3msDY+H063O9BZpEuX X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7526 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/12/2023 4:42 PM, Rushil Gupta wrote: > > > On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng > wrote: > > > > > -----Original Message----- > > From: Ferruh Yigit > > > Sent: Wednesday, April 12, 2023 17:35 > > To: Guo, Junfeng >; Richardson, Bruce > > > > > Cc: dev@dpdk.org ; Zhang, Qi Z > >; Rushil Gupta > > > > > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > > > On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > > > > > > > >> -----Original Message----- > > >> From: Ferruh Yigit > > > >> Sent: Wednesday, April 12, 2023 16:50 > > >> To: Guo, Junfeng >; Richardson, Bruce > > >> > > > >> Cc: dev@dpdk.org ; Zhang, Qi Z > >; Rushil Gupta > > >> > > > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > >> > > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote: > > >> > > >> Hi Junfeng, message moved down. > > >> > > >>> > > >>>> -----Original Message----- > > >>>> From: Rushil Gupta > > > >>>> Sent: Tuesday, April 11, 2023 12:59 > > >>>> To: Zhang, Qi Z >; ferruh.yigit@amd.com > > > >>>> Cc: Richardson, Bruce >; > > dev@dpdk.org ; > > >>>> Rushil Gupta >; Guo, Junfeng > > >>>> > > > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO > > >>>> > > >>>> Update gve base code to support DQO. > > >>>> > > >>>> This patch is based on this: > > >>>> > > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > > > >>>> > > >>>> Signed-off-by: Rushil Gupta > > > >>>> Signed-off-by: Junfeng Guo > > > >>> Hi Ferruh & Bruce, > > >>> > > >>> This patch contains few lines change for the MIT licensed gve base > > code. > > >>> Note that there is no new files added, just some minor code > update. > > >>> > > >>> Do we need to ask for special approval from the Tech Board for > this? > > >>> Please help give some advice and also help review this patch. > Thanks! > > >>> > > >> > > >> Once the MIT license exception is in place, as far as I know no > more > > >> approval is required per change. > > > > > > Got it, thanks the comment! > > > > > > Then we may also need your help to review, as well as the coming > patch > > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > > > > > >> > > >>> BTW, Google will also help replace all the base code under MIT > > license > > >>> with the ones under BSD-3 license soon, which would make things > > more > > >>> easier. > > >>> > > >> > > >> Is this different from base code under DPDK is changing license > [1] ? > > >> > > >> > > >> [1] > > >> > > > https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar > > >> chive=both > > >> > > > > > > The patch set of the above link only contains the processing of > replace > > the > > > MIT licensed base code with the BSD-3 licensed base code. After some > > > discussion, we think Google is in the right place to do that > work. And > > they > > > are working on that now. > > > > > > > Is the Google GVE driver [2] in the process of changing license > from MIT > > to BSD-3? > > > > > > [2] > > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet- > > > linux/tree/v1.3.0/google/gve > > > > I'm not sure, I don't know much about Google's plans. > Maybe they could provide some info here. Thanks! > > @Rushil Gupta > > > > > > > > This patch is mainly for the feature upstreaming of DPDK 23.07. It > > contains > > > only the code part, following previous license statements, > without any > > > license change. > > > > > > This patch is separated and sent by Google, to ensure there is > no license > > > violation. > > > > > > BTW, about the feature of GVE PMD enhancement, the rest code are all > > > about BSD-3 licensed files, and that patch set will be sent out > soon. > > > > > > Thanks! > > I have got the green light internally to switch to BSD-3 license for > code under base directory. If it is ok with the tech board, I can send a > patch right away with all of the base files changed to BSD-3 which can > be merged after this patch. Please let me know what you think. > We are also about to upstream driver > code: https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo.  +techboard There is already a patch [1] to change dpdk gve driver license from MIT to BSD-3, what will be different in the patch you are planning to send? Or overall I am trying to understand what is this new development on top of existing patch.