From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C164541EB2; Thu, 16 Mar 2023 19:20:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACE6E42DA8; Thu, 16 Mar 2023 19:20:26 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2044.outbound.protection.outlook.com [40.107.244.44]) by mails.dpdk.org (Postfix) with ESMTP id 504BD42DA4 for ; Thu, 16 Mar 2023 19:20:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zd8Gx709TX+UGpT7b+K3niNowYb3UZTZYQyYnSenHBwDtu0RcErx6tBOXLzuq+U2Kh9vpODyRzBjs3lO31ldIdTL9FOhbVYgVKXVS+eNhXpRGB+vMgEeiJDZ1IJERH0tuIfACyQ+eNxLtqjMtwDzImTHAwHnh61fVXv5Tf8hlnxIgIwSDtDezVsG1LCQsRrwiKY6bVkyolkjxc9nNQM8kYIngYpnu89+kTBmvAo7hvQFTY7BJKxPw2zysTBjnwf3UIxEnpv7fQUPW9nr+R5hxk1o9EoOpgVdhkLEkdBdYme/+4v87+g1LucF4tMkwmjEbOrqvOA+REbIZdnRhSBOuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hnxvaBpyOsAgsK+nLQqoW0SDOCAw5H2txrC4KSNxnt8=; b=FkHYoNO3UtKCrIjFXjHgD3rdR6DIgxn3u6M561ASBR1CXzNqWzgU66XVMx179WYfu8Ofpwb4FVNy1YdXpSfktLinn4jt78ARhlLNf302+/MZyrWjtln2g6C0iorAUBk1DGN2yZixtacx/fUmZ61YjMziIcVJT6ufYwmFMgspsOIeI3nSGDCmaIKLVYwBSyChdDmKDPPEApI0uoYIMtG92deU2p3/OEhUjuHoW+pv1YCVdnKZqmTbruBRaQvmyI1ZRO+mtdxPI5Ihm2bIaYcvccnb2JoQlzstNVlY29IRNbxQpRbr2Lg+SdXoxn45U5ZclAZhamrHAxT0hsgyNzd0nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hnxvaBpyOsAgsK+nLQqoW0SDOCAw5H2txrC4KSNxnt8=; b=g/jp+Zpv84CY2q2IbElpAssYRkF/XWw11S6nFr0HFnSLLrBv0PWKs9NsD4hhCpG2zqsCrSkSD3UDV9cWwgb0zq67E9Cq4LS6VVnuzB8VdNL40ME/fzQ+lOB3uwOKBIYWwH1LyPoGXBUKGO1CaP7Bw0qdGz0DgVOXFRcQTcaBcvM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB8494.namprd12.prod.outlook.com (2603:10b6:208:44c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Thu, 16 Mar 2023 18:20:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.026; Thu, 16 Mar 2023 18:20:23 +0000 Message-ID: Date: Thu, 16 Mar 2023 18:20:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Chengwen Feng , thomas@monjalon.net, Ferruh Yigit , Ido Goshen , Juhamatti Kuusisaari , Cian Ferriter Cc: dev@dpdk.org References: <20230314124813.39521-1-fengchengwen@huawei.com> <20230314124813.39521-4-fengchengwen@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH 3/5] net/pcap: fix segment fault when parse devargs In-Reply-To: <20230314124813.39521-4-fengchengwen@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0567.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB8494:EE_ X-MS-Office365-Filtering-Correlation-Id: e87fb291-6153-404b-8600-08db264b1b71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YIIifkq1e8HsEOwUUYbDmpfdADQ3GnekhUED/bMF5hU7V+Fr1oRHNhRh3wSgGNiqpeJazywm8RynEdsoIzGbMVljA1NmWtw1o6xfUqWJP8V7KO1yYkSN/5859i6RcxJXz50k83uGdh+5+bSX4Q4k8itizclipnQG5vUdecV2rs7jsYWkv0cOAs0Q2LzQVFlJqcoFHroDN6+mFH9b0v0m2ipl9aVTNbNsufzelOQn3lZJsO1BCE0JDmbVBCfOdQV8xOImqzEyYpQlXRVO/szT+HF3I9dtbP6nxOlbvL5VQ5uJdVOiuTLY+N9/C1u3n3iu8rThGBb7ZyAZ6r4CL2a3L67hV1hUlVsvrK/jUjH0QvuDqH7FnmC5YRbmzK0yosiXO/pzDJK1UjFem1ANzKphtssTEdTIcf756y07B/sS6oEuRv8JRwb6f3u/UBk14iH2UgAcBrmkle30N4ABsauUpuFQrYVIkS1gJZBbRaU8nWOeAy4UIqpWqZf443IZR2/sPDyF8sKyCKY58kwb0FbjU56fOlZq/v7j6pw4K0wO+vDOkACOBh1GY+6mSGViz/iC4bKSECEqQWbJAq1DjUqZRhx9gOvGCE6UacUxB0lGBrlSc0wjWrn5D/eNxQl6+o5E8aN98cu9qwZW0f5WmGs9BF6XfBfPe5wLZmYsBsadrwIQo+1XFLcsm+xwzOBAvEb7tlIkjbfKBFknUkw8v7/xsBGsSktwiapa5zljuR7g9eQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199018)(36756003)(38100700002)(31696002)(5660300002)(41300700001)(2906002)(44832011)(8936002)(86362001)(4744005)(4326008)(6486002)(2616005)(6506007)(53546011)(26005)(316002)(110136005)(6512007)(186003)(66476007)(6666004)(66946007)(478600001)(8676002)(66556008)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjZCOG0wK3dPam1YU0pWbFdETU91bW9tUTJxa1AwdDJkd2FKM0pqZzlOQU5y?= =?utf-8?B?V1FscHdTdnN3bnd3aVlYOCtZU05GcEM1dlhxS0NQT2t4Wnd0cU0zSlZ4OW9o?= =?utf-8?B?ZVZmaC9yRnNha2hkNk1WWVlZbi9tZ1l5aTJNekVtOXFxRXk3SEsxT3ZTMlhp?= =?utf-8?B?ZTJSRGZtQjhZM2VrZXdQZnJXVVRLTVpibnNYRFlzUlVCNCt1ZEExbnhCZnVU?= =?utf-8?B?Z0EwdUM1S0Q1Q3lyNjM5YVZjSkIxazZGQkhMV0VMYTR2NitVUmhzL0YyREk4?= =?utf-8?B?bDJwQnRrVCtNT0VrQUJlZkRPejMwb21KOXEzWGZIdjNleGlOakUvNnUrV1lM?= =?utf-8?B?N1FQYTF2SjhNTFYzQXF3aXNBN2pyaGJhUVNzbktWczFULzNqM2pNSFRSUnhO?= =?utf-8?B?eUdjUlBLNlIwUW5YbjF3eVVoOVZqZTdLWDlzdFcxOWRWM2o1TFh6Z09DalNW?= =?utf-8?B?dTBpZU5rVyt6MVJ1T01KNTMwNjd0dFo5YkFjYnUwcVRhaE9SVXQ3UE9wZ2xY?= =?utf-8?B?VUpEbjgyT09HbVFINHFIOGljcHdTQXNUbjJvYTMzZUpoNGR2ZFIwN0JBNmQ2?= =?utf-8?B?T1BZNVhJQnZ4cHZCUWxUM0Y1cnI4ck1CR2VPWlRtTmRGSGl5TW9XVVFmM25v?= =?utf-8?B?Z2hWaUhyZ1hHQVZtTTJpaUxwQlJBL3lmc0tXZkExLzRFLzUxc1Y4MWVOY1Rv?= =?utf-8?B?MUdPbTJIRlI4VzcwSHNydktXRjEyOERGT2plazJySGcweFJweFQ5S2pzek0y?= =?utf-8?B?MkxSM2J2Zm82THFjbWx6VGUwUStNbU9jVmdtbXlyQUJFRDhZZTV1eUpXcnNV?= =?utf-8?B?bGhIOVpOWTlWU0dRaVhTSEdTVjBNMG5vUFhwaDhkZ0pLK0lYRG5sR0U4V2NO?= =?utf-8?B?YVg3eUZ4U0lDOVFKeXg3Z0xWME5aUVBPQURJazJmSWhSZU1uUUhZVUo2c3Z3?= =?utf-8?B?WU5JV2Fzd3FER0tnK1lnUWFOUDQ3SFVKckxCOUdmSDVPcWx5RFNDclU2Yi9t?= =?utf-8?B?dDlVWUNKb3o4TmJjUVVwM01WTE11c1hTbWRXSGZMTmx1VjVwamF3Y1BOMFRJ?= =?utf-8?B?cWRUbU9HMlpucGRXTy9ZbCtVTkVpOVNMRG1TU2plVENTRHdIa3VPQ1V1YUVY?= =?utf-8?B?amRQajAwM1grZ2tJQWNObXRRN0pxTy9Hb3VpS3B1WWhwN3A4SDk1Q3daVjdu?= =?utf-8?B?NGt2cUtMZ2RaR3BXVEQ1NVVLclFuaGdCZDE4ejRzYmZXenB3amtkMUxyOWpS?= =?utf-8?B?SFNaNklRNS9pM01Ed3BHTVF6WUEzckdaUlVRUWZ4dXpvQ09zeXowRlJralU1?= =?utf-8?B?cmkzNVJiL3dNcDd2YXdmSDhVZXhMYkNCbFJHYW5QalNpQUpLamRmMmZJdllS?= =?utf-8?B?amhBRkVib3RNbWRIRko3dlhmU0hnR1FsbGh1N0lCb21sTUw0QzVpQlFqdXpi?= =?utf-8?B?VytZQXNLcDdlZnNWUTErcjJSQ2ZmdkVvTTFobXNEeHFHelo0dnJkTzFOMWNq?= =?utf-8?B?RkxjcjRDaEFDai9DMVFkeGNVRHc1N2g1OEhHeXUwZG5WanpKcDM2OEsvaWtr?= =?utf-8?B?c0pndjZJOGlmRmwzYjdlR0kyc0oreVZzcmVJNkIrb3FnQ2l3V1JkWG5FOTFn?= =?utf-8?B?eEZocWxCVFNHQUM1dzh5NVNneEtGK2RnMUwzY0Z5cW5pUzEwL1R5bjBLWExR?= =?utf-8?B?ZW5TQUE4Z2xzb1RYeEVmTmhtWncrREdubXFwd3JyaGNXQXVNa3ZCVllCWUdF?= =?utf-8?B?WjdidkFYaXpIMkhxaUNXU0NDZVFWdHlHSXA0UEJOOWtRWVpGT0l3WldDc1R3?= =?utf-8?B?ek85ckthOW9BRU51a0pOU0VaRHFVRWRraUhqQ0N0ZEFTY0hMTTJDdWFPL1VZ?= =?utf-8?B?ZmJqdDRzWGY5SjVIdlpOQXc1bVg4c3BBZDdDUWZ3ZEpqSFJZSGo2c3ZvYWFV?= =?utf-8?B?UUZ6YURKL0VtbWdhMlRKakpzb1NRMnZKTEUyNDdxemhTN0FxZWRmZHlBZXF0?= =?utf-8?B?U1dabWdzalpua2VNY3JYT2RXNmduMG9ieDFnby9VVFR5dG5EYjNwSVBBdWdQ?= =?utf-8?B?aDRzTmQ4N2Zpcnh5NzF5V1VRanpNelUrUEtaL3JUczM3d1BMd0hLNmJuWHhF?= =?utf-8?Q?1YSjFBZcqZ4jmAFnY4DSP3fW/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e87fb291-6153-404b-8600-08db264b1b71 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 18:20:22.9915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U34Ot1+C7+B5JtfdYK7h6GSqm9Q9sJfxP3z6YvSNvmyHpCjQZBPT9keQCYM+sooG X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8494 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/14/2023 12:48 PM, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when parse input args with 'only keys'. > > Fixes: 4c173302c307 ("pcap: add new driver") > Fixes: 53bf48403409 ("net/pcap: capture only ingress packets from Rx iface") > Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address") > Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file") > Cc: stable@dpdk.org > Can you please check following callbacks too: `rx_iface_args_process()` `open_tx_iface()`