From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Gaetan Rivet <grive@u256.net>, dev@dpdk.org
Cc: wangyunjian@huawei.com, Ali Alnubani <alialnu@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v1 3/3] net/failsafe: fix default service proxy state
Date: Wed, 6 May 2020 18:16:23 +0100 [thread overview]
Message-ID: <bd890238-2d96-152a-e3ee-231fcbeb6196@intel.com> (raw)
In-Reply-To: <7286631f479ef296b4c6b3ff41c5ca52504b0834.1588705694.git.grive@u256.net>
On 5/5/2020 8:10 PM, Gaetan Rivet wrote:
> The service proxy is initialized at 0. This is assuming that all of
> its fields are invalid at 0. The issue is that a file descriptor at 0 is a
> valid one.
>
> The value -1 is used as sentinel during cleanup. Initialize the RX proxy
> file descriptor to -1.
>
> Fixes: 366226dd859f ("net/failsafe: fix fd leak")
> Signed-off-by: Gaetan Rivet <grive@u256.net>
I have squashed this to the commit in the fixes line, to not leave any commit
that can cause crash, and kept both sign-offs and Ali's test tag.
Squashed into relevant commit in next-net, thanks.
prev parent reply other threads:[~2020-05-06 17:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 10:44 [dpdk-dev] [PATCH] net/failsafe: fix fd leak wangyunjian
2020-04-27 11:12 ` Gaëtan Rivet
2020-04-27 16:55 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-05-03 11:33 ` Ali Alnubani
2020-05-04 16:22 ` Gaëtan Rivet
2020-05-04 16:28 ` Stephen Hemminger
2020-05-05 9:47 ` Ali Alnubani
2020-05-05 9:14 ` Ali Alnubani
2020-05-05 18:35 ` Gaëtan Rivet
2020-05-05 19:10 ` [dpdk-dev] [PATCH v1 0/3] failsafe & ring fixes Gaetan Rivet
2020-05-05 19:10 ` [dpdk-dev] [PATCH v1 1/3] net/failsafe: avoid crash on malformed eth_dev Gaetan Rivet
2020-05-06 17:16 ` Ferruh Yigit
2020-05-05 19:10 ` [dpdk-dev] [PATCH v1 2/3] net/ring: fix eth_dev device pointer on allocation Gaetan Rivet
2020-05-06 11:48 ` Ferruh Yigit
2020-05-06 12:33 ` Gaëtan Rivet
2020-05-06 13:43 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-05-06 17:32 ` Gaëtan Rivet
2020-05-06 18:09 ` [dpdk-dev] [PATCH v2] " Gaetan Rivet
2020-05-08 11:00 ` Ferruh Yigit
2020-05-11 16:54 ` Ferruh Yigit
2020-05-05 19:10 ` [dpdk-dev] [PATCH v1 3/3] net/failsafe: fix default service proxy state Gaetan Rivet
2020-05-06 8:58 ` Ali Alnubani
2020-05-06 17:16 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd890238-2d96-152a-e3ee-231fcbeb6196@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=wangyunjian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).