From: Panu Matilainen <pmatilai@redhat.com>
To: David Marchand <david.marchand@6wind.com>, dev@dpdk.org
Cc: thomas.monjalon@6wind.com, anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH] ivshmem: remove integration in dpdk
Date: Thu, 4 Aug 2016 15:50:35 +0300 [thread overview]
Message-ID: <bd9390b2-954c-99e2-ec31-ee4909c47fb0@redhat.com> (raw)
In-Reply-To: <1469795316-31740-1-git-send-email-david.marchand@6wind.com>
On 07/29/2016 03:28 PM, David Marchand wrote:
> Following discussions on the mailing list [1] and since nobody stood up to
> implement the necessary cleanups, here is the ivshmem integration removal.
>
> There is not much to say about this patch, a lot of code is being removed.
> The default configuration file for packet_ordering example is replaced with
> the "native" x86 file.
> The only tricky part is in eal_memory with the memseg index stuff.
>
> More cleanups can be done after this but will come in subsequent patchsets.
>
> [1]: http://dpdk.org/ml/archives/dev/2016-June/040844.html
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
> MAINTAINERS | 8 -
> app/test/Makefile | 1 -
> app/test/autotest_data.py | 6 -
> app/test/test.c | 3 -
> app/test/test.h | 1 -
> app/test/test_ivshmem.c | 433 ------------
> config/defconfig_arm64-armv8a-linuxapp-gcc | 1 -
> config/defconfig_x86_64-ivshmem-linuxapp-gcc | 49 --
> config/defconfig_x86_64-ivshmem-linuxapp-icc | 49 --
> doc/api/doxy-api-index.md | 1 -
> doc/api/doxy-api.conf | 1 -
> doc/api/examples.dox | 2 -
> doc/guides/linux_gsg/build_dpdk.rst | 2 +-
> doc/guides/linux_gsg/quick_start.rst | 14 +-
> doc/guides/prog_guide/img/ivshmem.png | Bin 44920 -> 0 bytes
> doc/guides/prog_guide/index.rst | 1 -
> doc/guides/prog_guide/ivshmem_lib.rst | 160 -----
> doc/guides/prog_guide/source_org.rst | 1 -
> doc/guides/rel_notes/deprecation.rst | 3 -
> doc/guides/rel_notes/release_16_11.rst | 3 +
> examples/Makefile | 1 -
> examples/l2fwd-ivshmem/Makefile | 43 --
> examples/l2fwd-ivshmem/guest/Makefile | 50 --
> examples/l2fwd-ivshmem/guest/guest.c | 452 -------------
> examples/l2fwd-ivshmem/host/Makefile | 50 --
> examples/l2fwd-ivshmem/host/host.c | 895 -------------------------
> examples/l2fwd-ivshmem/include/common.h | 111 ----
> examples/packet_ordering/Makefile | 2 +-
> lib/Makefile | 1 -
> lib/librte_eal/common/eal_common_memzone.c | 12 -
> lib/librte_eal/common/eal_private.h | 22 -
> lib/librte_eal/common/include/rte_memory.h | 3 -
> lib/librte_eal/common/include/rte_memzone.h | 7 +-
> lib/librte_eal/common/malloc_heap.c | 8 -
> lib/librte_eal/linuxapp/eal/Makefile | 9 -
> lib/librte_eal/linuxapp/eal/eal.c | 10 -
> lib/librte_eal/linuxapp/eal/eal_ivshmem.c | 954 ---------------------------
> lib/librte_eal/linuxapp/eal/eal_memory.c | 30 +-
> lib/librte_ivshmem/Makefile | 54 --
> lib/librte_ivshmem/rte_ivshmem.c | 919 --------------------------
> lib/librte_ivshmem/rte_ivshmem.h | 165 -----
> lib/librte_ivshmem/rte_ivshmem_version.map | 12 -
> mk/rte.app.mk | 1 -
> 43 files changed, 13 insertions(+), 4537 deletions(-)
> delete mode 100644 app/test/test_ivshmem.c
> delete mode 100644 config/defconfig_x86_64-ivshmem-linuxapp-gcc
> delete mode 100644 config/defconfig_x86_64-ivshmem-linuxapp-icc
> delete mode 100644 doc/guides/prog_guide/img/ivshmem.png
> delete mode 100644 doc/guides/prog_guide/ivshmem_lib.rst
> delete mode 100644 examples/l2fwd-ivshmem/Makefile
> delete mode 100644 examples/l2fwd-ivshmem/guest/Makefile
> delete mode 100644 examples/l2fwd-ivshmem/guest/guest.c
> delete mode 100644 examples/l2fwd-ivshmem/host/Makefile
> delete mode 100644 examples/l2fwd-ivshmem/host/host.c
> delete mode 100644 examples/l2fwd-ivshmem/include/common.h
> delete mode 100644 lib/librte_eal/linuxapp/eal/eal_ivshmem.c
> delete mode 100644 lib/librte_ivshmem/Makefile
> delete mode 100644 lib/librte_ivshmem/rte_ivshmem.c
> delete mode 100644 lib/librte_ivshmem/rte_ivshmem.h
> delete mode 100644 lib/librte_ivshmem/rte_ivshmem_version.map
>
[...]
Ooh, what a nice "welcome back from vacation" message in my inbox :)
FWIW,
Acked-by: Panu Matilainen <pmatilai@redhat.com>
- Panu -
next prev parent reply other threads:[~2016-08-04 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 12:28 David Marchand
2016-08-04 12:50 ` Panu Matilainen [this message]
2016-08-18 14:08 ` Burakov, Anatoly
2016-08-23 10:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd9390b2-954c-99e2-ec31-ee4909c47fb0@redhat.com \
--to=pmatilai@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).