From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEE83A00C4; Tue, 25 Jan 2022 11:51:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C82B4293C; Tue, 25 Jan 2022 11:51:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 818714293C for ; Tue, 25 Jan 2022 11:51:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643107867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V8UpHT57XUkASL6dXjcnDQrKmwf62KDcscWjE0ptswQ=; b=DfCYtOiNTfaVPjAi7wkgnqTwhSWVv2+VPK0b1jVlUswBUxF7UJTotg/KHd23X1ScOFoxWm 3ij9vWspL7rJW+fd7MTqLgD9vAbVBHaxF5deQZv43GGDZVx0AOm+4vB6bmi9aLHyjvMSoK TavnrOrazeP3LC4FXuvb7qcKFfPVA0Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-529-9-OmbLqHPlSrfyfqEC3HUw-1; Tue, 25 Jan 2022 05:51:03 -0500 X-MC-Unique: 9-OmbLqHPlSrfyfqEC3HUw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9EA99185302C; Tue, 25 Jan 2022 10:51:02 +0000 (UTC) Received: from [10.39.208.46] (unknown [10.39.208.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8CD77CAD8; Tue, 25 Jan 2022 10:50:57 +0000 (UTC) Message-ID: Date: Tue, 25 Jan 2022 11:50:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 3/7] vhost: improve socket layer logs To: David Marchand Cc: dev , "Xia, Chenbo" References: <20211223083659.245766-1-maxime.coquelin@redhat.com> <20211223083659.245766-4-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/4/22 16:02, David Marchand wrote: > On Thu, Dec 23, 2021 at 9:37 AM Maxime Coquelin > wrote: >> @@ -471,16 +468,14 @@ vhost_user_client_reconnect(void *arg __rte_unused) >> sizeof(reconn->un)); >> if (ret == -2) { >> close(reconn->fd); >> - VHOST_LOG_CONFIG(ERR, >> - "reconnection for fd %d failed\n", >> - reconn->fd); >> + VHOST_LOG_CONFIG(ERR, "(%s) reconnection for fd %d failed\n", >> + reconn->vsocket->path, reconn->fd); >> goto remove_fd; >> } >> if (ret == -1) >> continue; >> >> - VHOST_LOG_CONFIG(INFO, >> - "%s: connected\n", reconn->vsocket->path); >> + VHOST_LOG_CONFIG(INFO, "%s: connected\n", reconn->vsocket->path); > > Another nit that I caught when testing in OVS. > For consistency, we can have () around the socket path. > > dpdk|WARN|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost0) failed to > connect: No such file or directory > dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost0) reconnecting... > dpdk|INFO|VHOST_CONFIG: /var/lib/vhost_sockets/vhost4: connected > dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost4) new device, handle is 0 > dpdk|INFO|VHOST_CONFIG: /var/lib/vhost_sockets/vhost5: connected > dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost5) new device, handle is 1 > dpdk|INFO|VHOST_CONFIG: /var/lib/vhost_sockets/vhost6: connected > dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost6) new device, handle is 2 > dpdk|INFO|VHOST_CONFIG: /var/lib/vhost_sockets/vhost7: connected > dpdk|INFO|VHOST_CONFIG: (/var/lib/vhost_sockets/vhost7) new device, handle is 3 > Agree, changed in v2. Thanks, Maxime > >> vhost_user_add_connection(reconn->fd, reconn->vsocket); >> remove_fd: >> TAILQ_REMOVE(&reconn_list.head, reconn, next); > >