From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B81ED45C18;
Thu, 31 Oct 2024 03:24:26 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 50D23433A9;
Thu, 31 Oct 2024 03:24:26 +0100 (CET)
Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])
by mails.dpdk.org (Postfix) with ESMTP id 6F44543532
for <dev@dpdk.org>; Thu, 31 Oct 2024 03:24:24 +0100 (CET)
Received: from mail.maildlp.com (unknown [172.19.163.44])
by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Xf7485yb5z1HFmy;
Thu, 31 Oct 2024 10:19:52 +0800 (CST)
Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242])
by mail.maildlp.com (Postfix) with ESMTPS id 134A4140360;
Thu, 31 Oct 2024 10:24:22 +0800 (CST)
Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com
(7.193.23.242) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 31 Oct
2024 10:24:21 +0800
Message-ID: <bdbe91bc-ee4e-d95f-6420-12d86a1881a7@huawei.com>
Date: Thu, 31 Oct 2024 10:24:20 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
Thunderbird/91.2.0
Subject: Re: [PATCH v3 1/1] net/bonding: make bonding functions stable
To: Lukas Sismis <sismis@cesnet.cz>, <dev@dpdk.org>
CC: <stephen@networkplumber.org>, <mb@smartsharesystems.com>,
<anatoly.burakov@intel.com>, <ian.stokes@intel.com>
References: <20241029124832.224112-1-sismis@cesnet.cz>
<20241030154256.379249-1-sismis@cesnet.cz>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <20241030154256.379249-1-sismis@cesnet.cz>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.121.59]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To
kwepemm600004.china.huawei.com (7.193.23.242)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Acked-by: Huisong Li <lihuisong@huawei.com>
在 2024/10/30 23:42, Lukas Sismis 写道:
> Remove rte_experimental macros from the stable functions
> as they have been part of the stable API since 23.11.
>
> Signed-off-by: Lukas Sismis <sismis@cesnet.cz>
> ---
> drivers/net/bonding/rte_eth_bond.h | 4 ----
> drivers/net/bonding/rte_eth_bond_8023ad.h | 1 -
> drivers/net/bonding/version.map | 15 +++++----------
> 3 files changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond.h b/drivers/net/bonding/rte_eth_bond.h
> index e59ff8793e..4f79ff9b85 100644
> --- a/drivers/net/bonding/rte_eth_bond.h
> +++ b/drivers/net/bonding/rte_eth_bond.h
> @@ -125,7 +125,6 @@ rte_eth_bond_free(const char *name);
> * @return
> * 0 on success, negative value otherwise
> */
> -__rte_experimental
> int
> rte_eth_bond_member_add(uint16_t bonding_port_id, uint16_t member_port_id);
>
> @@ -138,7 +137,6 @@ rte_eth_bond_member_add(uint16_t bonding_port_id, uint16_t member_port_id);
> * @return
> * 0 on success, negative value otherwise
> */
> -__rte_experimental
> int
> rte_eth_bond_member_remove(uint16_t bonding_port_id, uint16_t member_port_id);
>
> @@ -199,7 +197,6 @@ rte_eth_bond_primary_get(uint16_t bonding_port_id);
> * Number of members associated with bonding device on success,
> * negative value otherwise
> */
> -__rte_experimental
> int
> rte_eth_bond_members_get(uint16_t bonding_port_id, uint16_t members[],
> uint16_t len);
> @@ -216,7 +213,6 @@ rte_eth_bond_members_get(uint16_t bonding_port_id, uint16_t members[],
> * Number of active members associated with bonding device on success,
> * negative value otherwise
> */
> -__rte_experimental
> int
> rte_eth_bond_active_members_get(uint16_t bonding_port_id, uint16_t members[],
> uint16_t len);
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h b/drivers/net/bonding/rte_eth_bond_8023ad.h
> index b2deb26e2e..5432eafcfe 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.h
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.h
> @@ -193,7 +193,6 @@ rte_eth_bond_8023ad_setup(uint16_t port_id,
> * -EINVAL if conf is NULL or member id is invalid (not a member of given
> * bonding device or is not inactive).
> */
> -__rte_experimental
> int
> rte_eth_bond_8023ad_member_info(uint16_t port_id, uint16_t member_id,
> struct rte_eth_bond_8023ad_member_info *conf);
> diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map
> index a309469b1f..eb37dadf76 100644
> --- a/drivers/net/bonding/version.map
> +++ b/drivers/net/bonding/version.map
> @@ -11,12 +11,17 @@ DPDK_25 {
> rte_eth_bond_8023ad_ext_distrib;
> rte_eth_bond_8023ad_ext_distrib_get;
> rte_eth_bond_8023ad_ext_slowtx;
> + rte_eth_bond_8023ad_member_info;
> rte_eth_bond_8023ad_setup;
> + rte_eth_bond_active_members_get;
> rte_eth_bond_create;
> rte_eth_bond_free;
> rte_eth_bond_link_monitoring_set;
> rte_eth_bond_mac_address_reset;
> rte_eth_bond_mac_address_set;
> + rte_eth_bond_member_add;
> + rte_eth_bond_member_remove;
> + rte_eth_bond_members_get;
> rte_eth_bond_mode_get;
> rte_eth_bond_mode_set;
> rte_eth_bond_primary_get;
> @@ -26,13 +31,3 @@ DPDK_25 {
>
> local: *;
> };
> -
> -EXPERIMENTAL {
> - # added in 23.11
> - global:
> - rte_eth_bond_8023ad_member_info;
> - rte_eth_bond_active_members_get;
> - rte_eth_bond_member_add;
> - rte_eth_bond_member_remove;
> - rte_eth_bond_members_get;
> -};