From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Anoob.Joseph@cavium.com>
Received: from NAM04-BN3-obe.outbound.protection.outlook.com
 (mail-eopbgr680045.outbound.protection.outlook.com [40.107.68.45])
 by dpdk.org (Postfix) with ESMTP id 71B162B9A
 for <dev@dpdk.org>; Mon, 17 Sep 2018 06:21:30 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=80Wo4BGU2cwXnXignlWMeEgLSUioJqOkCjzrWEqjit4=;
 b=JxHpm41xSSlkhnHSDxxiopW2/24r0nytZWTV4I/D5I7W5LH4PZpxCh5QVTzBsmAjCjxhNuH+vYW1CNi8Quk8ylO96EM61K9GtbTFDyc/YHyX/avJ4WeRz2kIAlBy+oV3RWJO43iJl1lQn9MMDh0tGs94+2Z15h0aD97lG66lQ6g=
Received: from [10.88.100.222] (115.113.156.2) by
 BYAPR07MB4903.namprd07.prod.outlook.com (2603:10b6:a02:ef::26) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1143.18; Mon, 17 Sep 2018 04:21:23 +0000
To: Akhil Goyal <akhil.goyal@nxp.com>,
 Anoob Joseph <ajoseph@caviumnetworks.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
Cc: Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org,
 Murthy NSSR <nidadavolu.murthy@caviumnetworks.com>,
 Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>,
 Ragothaman Jayaraman <rjayaraman@caviumnetworks.com>,
 Srisivasubramanian S <ssrinivasan@caviumnetworks.com>,
 Tejasree Kondoj <kondoj.tejasree@caviumnetworks.com>
References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com>
 <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com>
 <1536033560-21541-2-git-send-email-ajoseph@caviumnetworks.com>
 <fdc981ad-dbbd-258f-7160-aa4416b39236@nxp.com>
From: "Joseph, Anoob" <Anoob.Joseph@caviumnetworks.com>
Message-ID: <bdf4f10e-a450-ea3e-82a4-f73920374510@caviumnetworks.com>
Date: Mon, 17 Sep 2018 09:52:14 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <fdc981ad-dbbd-258f-7160-aa4416b39236@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Originating-IP: [115.113.156.2]
X-ClientProxiedBy: PN1PR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::20)
 To BYAPR07MB4903.namprd07.prod.outlook.com
 (2603:10b6:a02:ef::26)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e396f8f9-1d67-478e-c941-08d61c5509c9
X-Microsoft-Antispam: BCL:0; PCL:0;
 RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(2017052603328)(7153060)(7193020);
 SRVR:BYAPR07MB4903; 
X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4903;
 3:PWlOXxspwR42vleNMnJdHJehFZdIpN5RLCbgPJP8hGadjXNuy8KxsMyu5CYMd5QNPzfuguwGOrc9WdQkXfI/zyOx1ZBUVrWef9Fyw8jL0hWv070eHLAYR7+BWL6JZF6pHCU+Q+fMMxUmcdCdlTvDpII5MQDEA5dLzRm4c8yVHO+rYR836oJkMAruwbo1NNTyKXGVON53q3UIzr58dQVioKk3VYMMQIm9Kbk4DEidoVqKILSXkqKc7GSoAcYD4wj4;
 25:7dV0rLByxus+3UmfQShBCy2jDnkxKIo24TSmrodzsz/4CI10TA47dbd3iyrCx7klt+KZwqW5vHaMgadD/9Pab9X/hbi6zgmOR/0Chdr8qnl2oH8VmSGXJwrTEIfpPfUXL5HX08MMrOyMlSGJ55EVwuX7ieGQ+Wm43ZlYi6VxpubGzfOzNkJdiOIEz8bIzUfDqnVefM/FsYDv4/l120LKP8EXq4K0oTV+Pax8lhvzC5XzZgZMBxIU9F1wU3h1jZwmWIze6vC8+WMJH84ov8G+iq4gPa6/IJ+pDZx3c6x0W2hdbxuzi8NHZiU8lMFSelTfR49KEbC4V/L3L+v0zEZnRQ==;
 31:wxp3fcphuS94z1w+oH8cxe+8fISXsJ9BT2RigH8qxtAX7d3np9U0LUToU4Elvu9kkstuptCSnBuXj0/ZnlmHOL3gEzbeXYjxiB113aN6mAz1gaPnC0zlYLbOEoVWtkfwwH6dvWWVkm9JhOAtpz7tDD22I+qaz4LC0hve+tSBlOayRmOTxc/o2+elvyNKCCLqTfaxGFpdqAJGeqLzUSMlG+D7gXXbpkO0gbJyLj0Lbis=
X-MS-TrafficTypeDiagnostic: BYAPR07MB4903:
X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4903;
 20:7PIEds3kXJCeTPiOUdvQTKOyUOa6l61iUBTG/wCErb1955iLClYgh+1vufGSy3qTusc0gQkIfaZs+fdexScS0PV/Ha8BcvSej9qJVQVqF06c1Ey4PCAUviE+Z335JI1J1t1u8E+Jsz12+mlMfJdR+H19PpbAA5RIDcJFIvGEK6ABu1tQYKjsDWIsyErub/QOQl9xN8UOYmsnZ/X4XFh4S0Np8z4F0qY/UHCm9ipt7r3VrIES293bH2rdIczBH8ZevG3s7WAy2bJuCQDcaVWGdWDRHw1JLnrNu3WxiOfBLWScT0zZtH/X8cUTFqbfV7Rl3NAxSkOFuYwXXVg8fLq5xEbG6F9YaNqRdU6/Yl4spApuP3P6LeqrSa4h7rQYfYjemPy43/fyTtY7sEUSbJ4dSooJWeTS01tHqTF/wJvZxwSYCTzcgaiJWTu2SWt1laDErwmJ5aMdv7bEo/DLZ047ER4bbT+VRM3qXfO5J9IDWpPZnX08IfsUHM0e2tZf2cu02AGlRzNM/v8jsJABBZyk4C/tKsppc2sbCAEmIt1eKbbCzYTzBICC9LsV1fMO3tJ6APtJe2cX25gI8zs/IvUFY37ggE2cJ6zuRVnrJixJtU8=;
 4:aOSd+OXKptrCVj+dogWD51xs2Go/qdGDXo0Y6jnzJzD2x/8qIA0PFA4xa1QW25GBZbDybvpLBdlHwqJJizl++/hhygBM/1LiHiQ3aoDSjFq2azOhIWnCJonLEtxXD2wcAnEjwLisshLnPcCa7g6FInIwxRIB5g/NE2UY0hwFuK70FVSF63JBcezHFbToa3z21KStxWpeyMBLh/hUQFvvgUkFNDBMvxsfM/xEYuWegZORXrv9q3ACFCLxcLEePpGZrBeDdx1YK8IdAjvshYYyyuTVf9tpP60RFfj/YkGCBTCCQ35PdOJls7pGcXldJcfT
X-Microsoft-Antispam-PRVS: <BYAPR07MB490310477E50B9E7ACAF252EF81E0@BYAPR07MB4903.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(228905959029699);
X-MS-Exchange-SenderADCheck: 1
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
 RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(93006095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699050)(76991041);
 SRVR:BYAPR07MB4903; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4903; 
X-Forefront-PRVS: 0798146F16
X-Forefront-Antispam-Report: SFV:NSPM;
 SFS:(10009020)(6049001)(396003)(39860400002)(346002)(136003)(366004)(376002)(199004)(189003)(64126003)(386003)(106356001)(31686004)(23676004)(2486003)(52146003)(68736007)(76176011)(105586002)(93886005)(16526019)(476003)(486006)(26005)(77096007)(31696002)(42882007)(956004)(11346002)(2616005)(7736002)(8676002)(446003)(52116002)(107886003)(305945005)(6246003)(53546011)(6346003)(67846002)(81166006)(478600001)(97736004)(4326008)(2870700001)(25786009)(3260700006)(6116002)(3846002)(2906002)(5660300001)(65826007)(110136005)(36756003)(16576012)(316002)(53936002)(58126008)(50466002)(54906003)(6666003)(6486002)(81156014)(14444005)(47776003)(72206003)(8936002)(66066001)(65956001)(65806001)(229853002);
 DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4903; H:[10.88.100.222]; FPR:;
 SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; 
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Anoob.Joseph@cavium.com; 
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWUFQUjA3TUI0OTAzOzIzOmgyTDc4QTVDSjdZTEIrNVdFNXE3TWFJbmFs?=
 =?utf-8?B?YnNQTXFIRUVkS2xvQ2hUMDBLRjZReXVJcFBnRGFhSWJTQ3JuRTZLTTMzUFJu?=
 =?utf-8?B?ckQ5bzlBaG82Rm1jcWJKdWFGREh0Y2hwUEd2SUN1aW1JT1c0ZWJxK1A3UUpJ?=
 =?utf-8?B?WU1FTGhpUEQ1aHQ3MzhxRzRsUHZSYVM2bEV6SVlCMUN6bmdhT0RRRHhoQXRi?=
 =?utf-8?B?cTNWYS9UbEZiaHNXdVRQbWZYMjRiRG1WRzVKVHJpUnNGMlpRajluTHhIZStx?=
 =?utf-8?B?bUppUW9UODd6eThaWGo2TEJQSGZsbEVaNnY5M2dWSDNUYXJ3SEE1a2lVUFJH?=
 =?utf-8?B?Uy9VeWlxZjJtV1J6SlBZUFJENzR2Yzl1Y2ozNm9RTWxlelFhTkFzeXdnTWI4?=
 =?utf-8?B?U2FJYXUzdW9KRmdTUnlHM3VzUGZESHIwNEdWT2xWbjhKY2owcXVHc21PSlFY?=
 =?utf-8?B?NnZJVnpSSElobDNoWnA3RjhDL09BcExSdkRvOFF6ZjUwZ3l4LzNkYVJMajRX?=
 =?utf-8?B?ZXMrK3RhUzI1NmtKeWQrUkZDeVpFQlFVMnMxL2w4bmpzOEFJNW9YMVBwc0FJ?=
 =?utf-8?B?OWZaK2loV3V1dUZqSjRSRFF1RVBER3dwUVdUSngvNW5KUFc5UU5MNXpvMDhv?=
 =?utf-8?B?UjdKd3BhYnQwT201dTZkMFNxbCtDQnU1SURvdTc3MExuNFlJY3VyNHVuWlp4?=
 =?utf-8?B?OTgrMkJBdnhGdXJYTW8yTDBLQldCRitxUi9WNGlhdm94c3NyU0NKWGJSejFz?=
 =?utf-8?B?cmtRbXlzS2lSTi9VZElUbzZWd2x0L2xlVWwwZ2V0aVY1aFY4OUQ5OU5FZllV?=
 =?utf-8?B?SFA1OGdaeThSaFFVd1dPOUdBR21HYnJBVkxMYkJsTkRpdTRIdWI2a2Q2V2Nh?=
 =?utf-8?B?WlRSU1VST1BGeklvYlNWdFdSWTB0dlJzRkZHNmszM3FOT2dMTDNnVlRjYmd5?=
 =?utf-8?B?UDQzTTFSVSsxU09UcmhxazVkR0cyODRTZnFKRVZZRkNQYWtyWDV2OTgveDZo?=
 =?utf-8?B?a0ZsMDJJK2dLbVdEYUJoc2F1SmRhRytMSTcxQVpHTEI1RzZEL2ZkVmtNNEh1?=
 =?utf-8?B?SVl2TDlDNmRmUGV2L3hOdHNzalc1ZkwvMVBXbmpvVUhQa09aNnNneWt3azFp?=
 =?utf-8?B?YnJLaCtVVEUvZG5NUnlKcWdnOG5jRXR1ZmJFZzAwZVdlWEwxSnQzM3JyL1k3?=
 =?utf-8?B?TzhHQkVZYjRjU0Z0bGg2bUp1c3dINnpMa2hmNCtMWkNkZ3ZmVlFjVldNWUMr?=
 =?utf-8?B?WVVjT0lPbGF2aEoxYnhLdmY0WlRLeHlRODJueFNxYzVwV3Y1bW5VSnZ1WTBw?=
 =?utf-8?B?NjRKd2UzQXUwUENiWWFpR0RhLzhIdTdjNnZ5YTg1U2EwNEhHRGtVZEloTEFB?=
 =?utf-8?B?YURCdGFoMEY4dy9XQ3JuNk94WU1QWTl3dEdPY1ZydnRsd2xtZlR0V1AzOFg1?=
 =?utf-8?B?SGU0b1pYRkk0cDFreW8yUlpwVzFFWmI0aUZUaHhtVXV0NjgwSGdSVTM2WS8r?=
 =?utf-8?B?YStySDUrM09KYW4zWjdtWFk3QjlLWU0xRE5pZkx3dlJnK2F5dFpSVEhpdzNF?=
 =?utf-8?B?dnJFZmxMRG1od1FnV0E4OC9OSDY5UnFRT0hXL3ZmckFCUVFObXRxUmFFY0Qz?=
 =?utf-8?B?OUdqZDZ5eWdib3RuclNkRnhIYjZDMDZ3MUZESG1tWk1SVFZPdHlqd0JlMnRi?=
 =?utf-8?B?TWR0b0g3TTdQdkE0M08rUUdDVUdpQUJyU25UNXJLbmc3OWQ5UHNhWmMyOFNK?=
 =?utf-8?B?ZU5hRzAxWStVa2JUSnBOSURjMlI2RmZQSWdiNHpPaldoR2pjSUFkRkg3Nlcv?=
 =?utf-8?B?Q1NVZDA3aGdVZC9IOWlVQXJYTmtvOC9OOTZoS2EzUDJOZmJZTzdhYlN3S1NN?=
 =?utf-8?B?WTZVMEoyZWlxcWIwQjE5aG9VN3dQME1VbUJ1blp0VkRENDhBWkErN0N0MStp?=
 =?utf-8?B?ZlhrRnBrQWE5bWZVblFJdWRCcytJYmhDaHYwb1BGYzhFQVlYY1pZSHBONmMx?=
 =?utf-8?B?OVNHRUpwZ2VnRlV0WFB3QnlVZmdDT0hTOE14QVgxTnZ1UUhmYmFtdy9ic0tC?=
 =?utf-8?B?MjgzbWQ5Y01qejZpeHlpdzhkNkFLYXhBNzNKa3F2cXdBWExGZ3EzclFvMDRy?=
 =?utf-8?B?Z0E9PQ==?=
X-Microsoft-Antispam-Message-Info: KPGtaRuZ9AYtfROz/aWGzMC9dQdOZtWue07heBfcQ5yB35Dyo3humrmngCGPa4lAccmz27WabsxIkJuAqE0bp3AB1kezRZDux+PnUA/zeatAnUfL4QP438gwVviOxhGmfn9T9WMEKSly+jeAoVRzOAceoGTn1Gg2Xbl/UHspOXKHlNIq3UWGjcw+dmNVaQ/xZcPj+UlFkcBIIPDph0dYfwI9B1PooJJFM96K+H2D+HwcsOq/g46SYQkGrl5WJVqnQXRh3iVDVZzEM3arecBdfc3h2+idqIetQNGazfw/Tb8uFfzFsKNltQSQIpGWp42JT82OeOxG0j3PHcx7mI9ol0k/26678zu2eZ5ozxHhJ3I=
X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4903;
 6:j03y6bFi8bNXhrgt3WpXaHJDkkswMbFvWwf04Zym8enVuDaU9pWivNFp7f6wnnWQCD9EyWCo4TiSl02s2nWHUvUyXHSceWVbKJExACB9uZqA6tqw7wnA07AgG+CHzDKNfiaubVBT2K1LBCmqxlRg8DhnC30GvhADC5OZEMHeubE3ezcX12GSd0MT9NMYQGuAxQZO8PSSv4Pmw75JKt0Nqm2emTtp4sMmybSZp/GN9xrp21xku2jG8gxQLb9UUZZq1356vep6BkwuYmOzDdOhU++teGoNuV4u2DtTqBizR2ghjO15G3NaclTA+eBbFWbTzJT7hUxFaGrXanO0msPcL9e7UDBD6YHYRKYTOGTaFgVsRjNMZkHPBDylk8RRAJxabUlvP4wBeYPD8Y9ScvMHnrTiOBcG8qLD56gqqdblIQWiwV478pbkfY1VbB4nKPVwITV/vePbB6glV5s7veZC3A==;
 5:NE164GuyMx3zoc7t35FG/cXV+xJ0+pQgk4UmrYLSzrP+tyRNVY1G+kGSgmz1Yq/ODQqn3qrjqX9dUdnuCmeDuAgQiSKGvzvifxD5FMDNb+fMr9bmlI69Q/bz0fa6onK8Dx+lrw7Y9rB40/rKIu4hB8QgFPrYHO+wN14jc5DCdSI=;
 7:AI84okv9dInWjvLduBok69aBuXy7TuL3b/JBAIFZEHnKH+h9oEF1mgfKwpq705denGf/bAMUAQZH61s+qodtgowa2dNQkYewm/faHSQMkZNTOi2HiSWc+xXIaz6gaW1E0mFzoHP1UqvF/M4vdh7A9U6JNpWgk5NJlyyGV7yVl1DTuHcpf7trU2m+ziIB7lY86WGDHh+WmlWiTFBg6N6OIKMlBfWeHLpIIzEl8Lp/frTbXbJ8v8SxIhMfWZJriCLU
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 04:21:23.9390 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e396f8f9-1d67-478e-c941-08d61c5509c9
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4903
Subject: Re: [dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto
 PMD skeleton
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 04:21:31 -0000

Hi Akhil,

Please see inline.

Thanks,
Anoob

On 14-09-2018 17:41, Akhil Goyal wrote:
> External Email
>
> Hi Anoob,
>
> On 9/4/2018 9:28 AM, Anoob Joseph wrote:
>
>> From: Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>
>>
>> This adds Makefile, meson.build and config file options.
>> Also adds the version map files and maintainers
>> file to claim responsibility.
>>
>> Signed-off-by: Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>
>> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
>> Signed-off-by: Murthy NSSR <nidadavolu.murthy@caviumnetworks.com>
>> Signed-off-by: Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>
>> Signed-off-by: Ragothaman Jayaraman <rjayaraman@caviumnetworks.com>
>> Signed-off-by: Srisivasubramanian S <ssrinivasan@caviumnetworks.com>
>> Signed-off-by: Tejasree Kondoj <kondoj.tejasree@caviumnetworks.com>
>> ---
>>   MAINTAINERS                                        |  7 ++++
>>   config/common_base                                 |  5 +++
>>   drivers/crypto/Makefile                            |  1 +
>>   drivers/crypto/meson.build                         |  2 +-
>>   drivers/crypto/octeontx/Makefile                   | 37 
>> ++++++++++++++++++++++
>>   drivers/crypto/octeontx/meson.build                | 12 +++++++
>>   .../octeontx/rte_pmd_octeontx_crypto_version.map   |  4 +++
>>   mk/rte.app.mk                                      |  1 +
>>   8 files changed, 68 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/crypto/octeontx/Makefile
>>   create mode 100644 drivers/crypto/octeontx/meson.build
>>   create mode 100644 
>> drivers/crypto/octeontx/rte_pmd_octeontx_crypto_version.map
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 9fd258f..09548fa 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -771,6 +771,13 @@ F: drivers/crypto/armv8/
>>   F: doc/guides/cryptodevs/armv8.rst
>>   F: doc/guides/cryptodevs/features/armv8.ini
>>
>> +Cavium OcteonTX
>> +M: Anoob Joseph <anoob.joseph@caviumnetworks.com>
>> +F: drivers/common/cpt/
>> +F: drivers/crypto/octeontx/
>> +F: doc/guides/cryptodevs/octeontx.rst
>> +F: doc/guides/cryptodevs/features/octeontx.ini
>
> octeontx.rst and octeontx.ini does not exist. Please update 
> MAINTAINERS in
> the patch which is adding this file.
Will do so.
>
>> +
>>   Crypto Scheduler
>>   M: Fan Zhang <roy.fan.zhang@intel.com>
>>   F: drivers/crypto/scheduler/
>> diff --git a/config/common_base b/config/common_base
>> index 4bcbaf9..4c6a951 100644
>> --- a/config/common_base
>> +++ b/config/common_base
>> @@ -635,6 +635,11 @@ CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=n
>>   CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=n
>>
>>   #
>> +# Compile PMD for Cavium OcteonTX crypto device
>> +#
>> +CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO=y
>> +
>> +#
>>   # Compile raw device support
>>   # EXPERIMENTAL: API may change without prior notice
>>   #
>> diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
>> index c480cbd..c083e64 100644
>> --- a/drivers/crypto/Makefile
>> +++ b/drivers/crypto/Makefile
>> @@ -7,6 +7,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM) += aesni_gcm
>>   DIRS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += aesni_mb
>>   DIRS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO) += armv8
>>   DIRS-$(CONFIG_RTE_LIBRTE_PMD_CCP) += ccp
>> +DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO) += octeontx
>>   DIRS-$(CONFIG_RTE_LIBRTE_PMD_OPENSSL) += openssl
>>   DIRS-$(CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER) += scheduler
>>   DIRS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G) += snow3g
>> diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
>> index d64ca41..2187870 100644
>> --- a/drivers/crypto/meson.build
>> +++ b/drivers/crypto/meson.build
>> @@ -2,7 +2,7 @@
>>   # Copyright(c) 2017 Intel Corporation
>>
>>   drivers = ['ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
>> -     'null', 'openssl', 'qat', 'virtio']
>> +     'null', 'octeontx', 'openssl', 'qat', 'virtio']
>>
>>   std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
>>   config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
>> diff --git a/drivers/crypto/octeontx/Makefile 
>> b/drivers/crypto/octeontx/Makefile
>> new file mode 100644
>> index 0000000..65bd02f
>> --- /dev/null
>> +++ b/drivers/crypto/octeontx/Makefile
>> @@ -0,0 +1,37 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2018 Cavium, Inc
>> +#
>> +
>> +include $(RTE_SDK)/mk/rte.vars.mk
>> +
>> +# library name
>> +LIB = librte_pmd_octeontx_crypto.a
>> +
>> +# library version
>> +LIBABIVER := 1
>> +
>> +# build flags
>> +CFLAGS += $(WERROR_FLAGS)
>> +
>> +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>> +LDLIBS += -lrte_cryptodev
>> +LDLIBS += -lrte_pci -lrte_bus_pci
>> +
>> +VPATH += $(RTE_SDK)/drivers/crypto/octeontx
>> +
>> +CFLAGS += -O3 -DCPT_MODEL=CRYPTO_OCTEONTX
>> +
>> +# export include files
>> +SYMLINK-y-include +=
>> +
>> +# versioning export map
>> +EXPORT_MAP := rte_pmd_octeontx_crypto_version.map
>> +
>> +# library dependencies
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO) += lib/librte_eal
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO) += 
>> lib/librte_cryptodev
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO) += lib/librte_mempool
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO) += lib/librte_mbuf
>> +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO) += lib/librte_malloc
>> +
>> +include $(RTE_SDK)/mk/rte.lib.mk
>> diff --git a/drivers/crypto/octeontx/meson.build 
>> b/drivers/crypto/octeontx/meson.build
>> new file mode 100644
>> index 0000000..261bb77
>> --- /dev/null
>> +++ b/drivers/crypto/octeontx/meson.build
>> @@ -0,0 +1,12 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2018 Cavium, Inc
>> +if host_machine.system() != 'linux'
>> +     build = false
>> +endif
>> +
>> +deps += ['bus_pci']
>> +name = 'octeontx_crypto'
>> +
>> +sources = files()
>> +
>> +cflags += '-DCPT_MODEL=CRYPTO_OCTEONTX'
>> diff --git 
>> a/drivers/crypto/octeontx/rte_pmd_octeontx_crypto_version.map 
>> b/drivers/crypto/octeontx/rte_pmd_octeontx_crypto_version.map
>> new file mode 100644
>> index 0000000..521e51f
>> --- /dev/null
>> +++ b/drivers/crypto/octeontx/rte_pmd_octeontx_crypto_version.map
>> @@ -0,0 +1,4 @@
>> +DPDK_18.11 {
>> +
>> +     local: *;
>> +};
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index de33883..b530337 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -211,6 +211,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ZUC) += 
>> -L$(LIBSSO_ZUC_PATH)/build -lsso
>>   _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO)    += -lrte_pmd_armv8
>>   _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO)    += 
>> -L$(ARMV8_CRYPTO_LIB_PATH) -larmv8_crypto
>>   _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO) += 
>> -L$(LIBMUSDK_PATH)/lib -lrte_pmd_mvsam_crypto -lmusdk
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_CRYPTO) += 
>> -lrte_pmd_octeontx_crypto
>>   _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER) += 
>> -lrte_pmd_crypto_scheduler
>>   ifeq ($(CONFIG_RTE_EAL_VFIO)$(CONFIG_RTE_LIBRTE_FSLMC_BUS),yy)
>>   _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC)   += -lrte_pmd_dpaa2_sec
>>
> I think it would be better to squash the makefile related changes in 
> the 3/33 patch as the code
>
> is actually added in that and here the code is not getting compiled here.
So the changes in the following files has to be moved to patch 3/33?
   drivers/crypto/Makefile
   drivers/crypto/meson.build
   drivers/crypto/octeontx/Makefile
   drivers/crypto/octeontx/meson.build
   mk/rte.app.mk

I think this patch will just have MAINTAINER edit (even that might be 
required to be moved to 3/33?) & changes to config/common_base, after 
that. Is that fine?
>
> -Akhil
>