From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A383B42C02; Thu, 1 Jun 2023 13:58:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E61B40DDC; Thu, 1 Jun 2023 13:58:55 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 63985406BA for ; Thu, 1 Jun 2023 13:58:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685620733; x=1717156733; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=rBreLLxk8vUGqGGDr62PjJBLmn7To0Bhb56p70EujAQ=; b=T5K7XVPvdpzVf/aaC/XAIEJ9ghmhp/UqZi3nPsoNizZzZm8rNAMPwbPr 1PtCc1G6t3YO4TeIKNR1Dgzu5NEEUdBlPIoNgi6EoEKPPU0eAz2wY62Vh 1GdQg2sQ9T0O25y5Eecc9J09bqZmLRJhkAiZQMWtArSFCZlp6MigTE1Uk yee2axiMPEKdahhqAsOahaS7skdpMlKCZNAE54TIF1EDrBqhGjAR1kA4U J8+hF+2g9vcqKR65dHIiC13+6jStP625xdgb1llnlY1xMtBxchkKG00sR K4T/zOPD7VTkA/4FbTg+GdPG1rCVB2Xk1/Rw0UFHN4KuePqt1la2W0AkI Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10727"; a="353033233" X-IronPort-AV: E=Sophos;i="6.00,210,1681196400"; d="scan'208";a="353033233" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 04:58:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10727"; a="851647090" X-IronPort-AV: E=Sophos;i="6.00,210,1681196400"; d="scan'208";a="851647090" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 01 Jun 2023 04:58:52 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 04:58:52 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 04:58:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Jun 2023 04:58:51 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 1 Jun 2023 04:58:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LKEydrOCQ/7wLsS+RaXZa2LxjoCjs/oxIBcimQGU+fSP6t2Y63DkHKqoJfTIQ0MI9mdcDfYmkiZQ+g/vA433JL+pr9DJPzZN1/s82hnH9sAQoTWVeAlfulg0B1b47crAQX946GXJxwCI4g0EH3VTzPOAdYGG7MVw0oYrw+kV4a19jePL4lm/j/GczrtXROrKEwluLhak/47+0Fbkt0DZFfNAFIVxKkrSYFa6aZd4v0n6TrfnAd2M2TDD4hN5eoekVkNdDluu5Ls9PWr05GCadHMiME6gZJt6TQB4s0+gp5pePSGOVZ1KqAu8WsAFqPc+vw/Kl6Y47KOw6nxwwL3++w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pWM2Am8C6ABAzZMDLpwmP7mX6ROJGX+w086uC5Onw3I=; b=AF1CGaqzKc+8HBMuSe3qkU9QPpB1rO12N97o2fwzxmow4/u7r+NwGvk3NIY+qv1OAgWADk9twqG7m6TyKJEz2fzP2AdGlxGFQXXrhZBD9KhK545xfxCDX8lJ4NphlHwj4VfPrIF258/X8wRkbZnGFlmUuPIkhsydboeoaX6PR+IYDgSHcQRMvUtDza6yN+HABYY1Cr/l/TM1B/D6VnP4+RnWzWohcKX4wtEout52zFQyDXq7mV4yYImYydrTNfwX8ZFoDPHjMzQYRe3zxkCNmK4lkRHoW5CDsNHT1GXSQcWcSZ00rWD1pmAgyf3Kh4HhxGH4g6IvaTyRoLVLcIsoIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by IA0PR11MB7912.namprd11.prod.outlook.com (2603:10b6:208:3dd::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Thu, 1 Jun 2023 11:58:49 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::ca2b:ad33:65e1:980d]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::ca2b:ad33:65e1:980d%2]) with mapi id 15.20.6455.020; Thu, 1 Jun 2023 11:58:49 +0000 Message-ID: Date: Thu, 1 Jun 2023 17:28:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/4] app/testpmd: support UFO in checksum engine To: Zhichao Zeng , CC: , , Yuying Zhang References: <20230413053426.4190965-1-zhichaox.zeng@intel.com> Content-Language: en-US From: "Singh, Aman Deep" In-Reply-To: <20230413053426.4190965-1-zhichaox.zeng@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN0PR01CA0023.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:4e::18) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|IA0PR11MB7912:EE_ X-MS-Office365-Filtering-Correlation-Id: 30646b50-1318-4a42-af02-08db62978f77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YdwOfh38THwpIA6EwBygydGrTE68EgCZNtTKCxYvsVKdoSGa33rWHi8VrKtsX4DxAkR4eEK4+PAHjHP87fgLd+Hi8p/dM/yNXJTE2wTCNJQ6P/wBwrzsvq0neTZVn+FAPoMvbqfdYjQaNOiT96dJlj6RQ+C38gRHdBsMdEajvgBVReZV4n8jWJNxBnopdt7lv90/8pwWLDoU6UltGR7jcsyowIRgDIZ/U3cL+UlcS/HCz5yDtHx3jXhMcuXzyXLz0bcXdsSGd5b2K16F6wrtTOORP7YayMbvf4dg7BLT7LfaI19XvLzChP3IEuwekULX6HunBFcsf7OWm1KVWOf2cIihu8lNVlhWyTj4eEleEBHBtWoXMKisvl5l0ddaSAuVF8T5A8HR0MG2iRQh8nqmZpTLpHYhd709qHPAJyyoz/gigrs/ZrQECu7bJsHJtOK4atkFCvyb/vFR9y/TUIDa2s+iRuIVDdf+JaZn5KMmNwNcl4Aoh2eKW9BoROvYaOxbH4PkwA/mt1K2ypz0FzDYF+U31hmH+DS4JzTFyTzfvCrF7yR+j6K4+oFod//es6XkAexi0yAPSmwpoTueQTd1+F/wv4BaAYHDk4iU6lqJDemB+1o9OjNkQ6YlHX0P8SOFCHn94F2neVHEp97LNwZcuw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(39860400002)(136003)(366004)(346002)(396003)(451199021)(31686004)(82960400001)(38100700002)(66476007)(2616005)(66556008)(66946007)(86362001)(4326008)(31696002)(2906002)(4744005)(186003)(316002)(26005)(6486002)(6506007)(6512007)(53546011)(36756003)(107886003)(5660300002)(6666004)(41300700001)(8936002)(478600001)(8676002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDZjMU5rdVNVU1NJWVFodmtyY3lRZjVxMjZLZDY2bEI2VjJML1lBRi84Mlpy?= =?utf-8?B?SUFzYUNwZllYdU9tUUZWbm55emZrYkJ0T1hFL3dmNG55a3UvY0lSa1JFTnlj?= =?utf-8?B?QUUwV05VYzJvamhwUDYrYmFLN1BPclhXU2ZiUVcxOTVIUVJ4Ky9ZaEJMSnBU?= =?utf-8?B?NkRhNjQxR3BTeHRFVFJaOUxvc1RING9zTlFtdmQ0UHRKdUN6cmRsTUdLNkk2?= =?utf-8?B?VWJXbDhENklWZE9HWVVROEh6eVgzYmVOZlZJWEVPL3czcWJ6bE9IVXpsMnRv?= =?utf-8?B?YVM1S0dLQWNaZ3ZiUmhCWDhJWW9XMlBvSjJnc2Z4ZVJFY0NEMDRuMkhDc1lx?= =?utf-8?B?M1FESzMxNDFxamE3bE9ZTjRiK2VKTEp5YUJXQWFzYWlBS3NzNktLMmo0bXlN?= =?utf-8?B?TDh4emU4c1NKcng5blA1N0NpTXVvSUZ3SlFFLzBzMmJidlNYRDQvUE9mdkR4?= =?utf-8?B?RGJFY0krMlFIZHVGdVJKUFd3cGpTb093NmZGdFNsemRxUFMrOUp0Q3EyNFFq?= =?utf-8?B?UXc1SFFCTTh1dlloN1hDcWgrcDRCZnBieTRRcDJ4dG4yY0VXTmRHRkdBRk10?= =?utf-8?B?dUtKU2JXWVFzYVhBOWtxc3ErYWhBRFRlM0pBbmhrVlVtN0FoMngraDQ4ZHky?= =?utf-8?B?R213aTVWL2FUOUxucExXOFFoL1NZQzZHV1lyd0lHTVVYTG5MT3ZCYm1RNXIy?= =?utf-8?B?Q3BhZ3h5S2crKzQ0cFpYTG9OUEJwcnUzSndpY1dQdUhRbUVaTkVBamluVSt2?= =?utf-8?B?WWNMNUhxSTN5cjc5a1NiUWFuWGxjWlA5NkxGS3gyVGFRWVJmSGdCeUtkcmpY?= =?utf-8?B?Z0hsMTRMNDJGaVRiR3Y4WU1xbm52bjRxSmMrcUlHQkwrYWVZdDA4MmtyQVRy?= =?utf-8?B?YkcvajEycDBkenYrT2d6RERBS0ZTRU9wYmlnRWJKU1crbWpXVnJwTUFKNXN1?= =?utf-8?B?MW9oczR0YUlVTGZZNFZ2Mm44MU1MeUJ3NnpHcFVxNEJSdHJiWE5hK2xLSzV0?= =?utf-8?B?ZUhURHBkRzNlVzgxUzJkVGFOVmNqTnVvT3BYaDJxTzNpZHdreUN6dUxGQSt5?= =?utf-8?B?cU9XYnZ2Q0hYTVlBc2hCS3VGN3djbWJQWTVSQkRRc2MvNXNJOVppQXZGV0lq?= =?utf-8?B?NHVXZklGQTNEaTFzc05vaGFJMW0yNjJFWkJHN3IvMmY1bG9QejFZcnJkRGtY?= =?utf-8?B?SWNpd0dUNE50U3JOL2RtNWpxS1BsNHJtUWxiUEEzMGVHSVBoTElxWHFieUN1?= =?utf-8?B?dSs3VStIWXFEL2tEVWxNSnh3VVVmMjJMdnUzcTJ2OStMbUdtcGg1NHFpUFc1?= =?utf-8?B?YXNtYWQwcEhUb1J4dGV2Zm5sYXZXYSt6WWZqdlhERUtBVjFTRU1YL0pVTW9z?= =?utf-8?B?OTh0OEY1T0NQdnBqYkk2Qy9ZNnBLR3pvZDNLelEvUlFCdU9laUYxcVlDYzRZ?= =?utf-8?B?c2ZIZ04rWjRoRW43NGZGNG5kcnVvb05qNVZmUnppVWpia3FxZnU2aWRqWUo3?= =?utf-8?B?VVJ3V1BranI0SjN4OUJ0N0trM0YxYmYvYlRZbzdaSkIvU1Bpb2x6d0MzU0lJ?= =?utf-8?B?SHo2dnA0V1ZDTU5JVTNhR1A3dGRpeUQvZE1wR25CdmhKWktoT2QvQkZLUzBI?= =?utf-8?B?bmtVaE5KLzlRSmUyZklJeUkyV2orQXZzYXFRL21qNStxK0V1NnBRaVplalpl?= =?utf-8?B?dlAyR0RJU2RWTUJBK21HbE5SSmJRMU5rd2JWdjNIZW5kbC9BUGI4VTljS21q?= =?utf-8?B?MXRXbWZZakdoTVlabnYwVnc2TG5xSE5wMUdJK29sVkxTajlNQlY0cG9NbWw3?= =?utf-8?B?SXh0Mkd5RjI3OFAxdkQ4MERYWHNuRmNWQTIwY09tdExsdlZyT3RlNjFwZUFZ?= =?utf-8?B?cGVUZGN4cFVTMVpQWDdKOUxzWXZQVERRRWQ1K1hxRmVQeVhQU0pJQ3p5NnUz?= =?utf-8?B?dDBZZ1A0aUpmOEFac0lzb05rSVRpOEpqNlgvNmxMVmo3WXJXdVdwRnZxbVhY?= =?utf-8?B?WlFYUnNqVXAwdTdLc3pwZmZIYjQ0Y3Jla2V1Mng3cUx4V0FLK0YxaUxBYTcz?= =?utf-8?B?aG9xUGtoM0FlMm1NNmRIVHFoWW5GcEwzKzBmVFk3eVlEWWtZL1FsUTVQVE1W?= =?utf-8?B?UXphbll6Njg5Z2lSZkt2dnhWS3YySkNqQW00dHdkeW9TQzNXYjBMVDlkRXg2?= =?utf-8?B?a1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 30646b50-1318-4a42-af02-08db62978f77 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 11:58:49.3583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mXKWuT2jM4fckKFCkvHgcZNHg/Iml1DS+x/WpDTDyprbiwG+anaSOPMafRQs0thELE0BVpBD0GYo+qbmo5DxB/XzDXn4FI9jyWz77HB1qKs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7912 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/13/2023 11:04 AM, Zhichao Zeng wrote: > This commit supports UFO for both non-tunnel and tunneled packets. > > Similar to TSO, the command "tso set " or > "tunnel_tso set " is used to enable UFO, > and the following conditions need to be met: > a. The NIC supports UFO; > b. For enabling UFO in tunnel packets, "csum parse_tunnel" must be set to > recognize tunnel packets; > c. For IPv4 tunnel packets, "csum set outer-ip" must be set to hw, because > UFO changes the total_len of the external IP header and the checksum > calculated by SW becomes incorrect; This is not necessary for IPv6 > tunnel packets since there's no checksum field to fill in. > > Signed-off-by: Zhichao Zeng Acked-by: Aman Singh