From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16FF3A04FD; Mon, 23 May 2022 20:09:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08AE841611; Mon, 23 May 2022 20:09:33 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2080.outbound.protection.outlook.com [40.107.93.80]) by mails.dpdk.org (Postfix) with ESMTP id 1C52641143 for ; Mon, 23 May 2022 20:09:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WWhFGrd0MLD5OoVeQwQvNoCQDFaE6qjS8zT4WVEV2LL155YiATugmeSGSAiAs46KpgUZyHQ+Y2uAymKyhh9aYmq7yRCzo1+RGYuTktT3u0whv7U/v6zC+lPmJSLH2Z6Rfj3OFbeKIZfLf5qDAZRpwRdBQ/nSlKWNeucMIMsdvFDWGOnuh17PLmk4zJxvFa1zn7Hwq610NTjzkx6G3nFRFadWJL0mk7KSlUtec0lFz+NuqvR57NNGyTHSQPA8IARilcLT2edO4gzk7Umwc6tUnLbt8f8GClOsiXlK+FGWC71wB9hI55Qp8SQE97o6q3/3sNLpkOxrKVnAiuSNlvUBAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XBN+/HedRAOKmu85RRWbsEbikITs0JocCkFG7KO6ywE=; b=lSZTbRHEUSBxpDVRGJcWV83TOqQ8qNv/moCrZsLB2t6KwWGf6zd4F/FyD+7Aff75GNfvwd8rQX9LR3GnlE86ZfCj1ZZ7WGoyIgPSIuixSPXw04CTsw0QFZ5DKRwgJYcPAa1oM1RX6HO5CvL/iL6TnfoEt7a/6Q39RucRLfBfY72xy1kSpryafnfA5JyjIxfJ0JD0mU8PZuaCfLdbnVSHl3TllxFX9p/Dixm5iUmnnI9FP/ZW5ZEOWkIrw5bLIJfBqFkdSQbynSUsNl62BKWWt82y3fBhopfnnVR9d7xMegKAkvieKOzCVOZI1bAO0r5Rnrog+7hFLYfs3I2bS2F0pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XBN+/HedRAOKmu85RRWbsEbikITs0JocCkFG7KO6ywE=; b=cfA2pPAJfjdGKT+4ovWn7HSgjKBrMti6UdyyDAhqqjzOEE6r64ajBvmtFCevek6kRJWCveoDPHsf73N2b3C/ZSxhHte/Vt6+o+Y7abaJUFfI3CCe7+WHdWbqYgqKy8EuEK72qY5lkn3d+byFe7lYCAvM+wWVS+FvQoVzvbmDYQM= Received: from BN9PR03CA0098.namprd03.prod.outlook.com (2603:10b6:408:fd::13) by BN6PR02MB2723.namprd02.prod.outlook.com (2603:10b6:404:fa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Mon, 23 May 2022 18:09:29 +0000 Received: from BN1NAM02FT009.eop-nam02.prod.protection.outlook.com (2603:10b6:408:fd:cafe::ff) by BN9PR03CA0098.outlook.office365.com (2603:10b6:408:fd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 18:09:29 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT009.mail.protection.outlook.com (10.13.2.127) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Mon, 23 May 2022 18:09:28 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 23 May 2022 19:09:27 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 23 May 2022 19:09:27 +0100 Envelope-to: cristian.dumitrescu@intel.com, david.marchand@redhat.com, dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, konstantin.v.ananyev@yandex.ru, xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, orika@nvidia.com Received: from [10.71.119.126] (port=64506) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1ntCUh-00042T-Lj; Mon, 23 May 2022 19:09:27 +0100 Message-ID: Date: Mon, 23 May 2022 19:09:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/6] app/testpmd: mark most cmdline symbols as static Content-Language: en-US To: "Dumitrescu, Cristian" , David Marchand , "dev@dpdk.org" CC: "thomas@monjalon.net" , "andrew.rybchenko@oktetlabs.ru" , Konstantin Ananyev , "Li, Xiaoyun" , "Singh, Aman Deep" , "Zhang, Yuying" , Ori Kam References: <20220513075718.18674-1-david.marchand@redhat.com> <20220523071031.1868862-1-david.marchand@redhat.com> <20220523071031.1868862-2-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb06769c-5b29-48a0-3f53-08da3ce76113 X-MS-TrafficTypeDiagnostic: BN6PR02MB2723:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: usCShRj5CBgCh/nqlXkzSlVssFgjSkjdlO1PHLSlJqN9ra00zuf7LzWJI4qKl29OFsWUwFe+AeGzLsZD0rdm1BG3FsnB+tYQpWNbiw65V6DT4GCr1q3knLZ8krds9RtpQBF2nsiqBea8fULyUJQv4L7/+Qyf2iMTB+qjFyJ//Fp1emCojK9NU/p+2kAMreJv2/O6lDKapfPVY/vfaL5MDhzCyQgQ1HllQkMRzWgEG8VVWHFW3ajO2xJ+F2/wPWEq8ZIOVgdxhs1roeKFxg03L+23A12ohit3ue4rZM6A/uoFFpj5xmgd6zYurEp7fWe15Y9t5iC3l9VZB4ptIrO4uYrvmHebK3mG2YsPUCJ5Cu9g2YX+UqH23iIe8xtfDtwVfxZxV6eI1F/toV27D22re6H+9ifiQm7Cq3/a0A6l5Eg1E2bRHjdxU1vheRfOp8p5jvcgwurNrxIQf70L/bFUnRmjY8EPu+W8G5l3xg0XrypnJ/erlnWFijpb/L8HbkcYOCuWsRMrWK3McLaTE2LzjSqwNCUoDdaSgbFhDenVYHElGCjvnK9O5pOtQXtJMpFklRVH81SYUZl/6JVGKkJiTdd4SUwUiVNFfGag4vU7kCGJ8FSOvGmTv7YUWopYsacHouzcAre5JjOPiV0/urXHA8dbjF+e7S+ZmoKj8nvetWkEe3abhbyC5F+SarvkVwc7vhyVO4GDAWs3pc7EUWFr3CPNejuy4YW03oR6FZQ3qGxIz2Wd+7S1dSi795vaqHiBqCkmas/6sVJLrDGuGpJOaA== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(31696002)(336012)(2616005)(86362001)(508600001)(2906002)(26005)(53546011)(83380400001)(35950700001)(9786002)(7636003)(47076005)(356005)(82310400005)(40460700003)(70586007)(70206006)(31686004)(110136005)(5660300002)(44832011)(8676002)(4326008)(36756003)(316002)(8936002)(54906003)(7416002)(50156003)(23180200003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 18:09:28.8234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bb06769c-5b29-48a0-3f53-08da3ce76113 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT009.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2723 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/23/2022 11:19 AM, Dumitrescu, Cristian wrote: > [CAUTION: External Email] > >> -----Original Message----- >> From: David Marchand >> Sent: Monday, May 23, 2022 8:10 AM >> To: dev@dpdk.org >> Cc: thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; >> ferruh.yigit@xilinx.com; Konstantin Ananyev >> ; Li, Xiaoyun ; Singh, >> Aman Deep ; Zhang, Yuying >> ; Ori Kam ; Dumitrescu, Cristian >> >> Subject: [PATCH 1/6] app/testpmd: mark most cmdline symbols as static >> >> All those symbols don't need to be global, plus it was hiding unused >> code such as: >> - cmd_set_conntrack_dir_set and cmd_set_conntrack_dir_conntrack in >> cmdline.c, >> - cmd_create_port_meter_g_action, cmd_create_port_meter_r_action, >> cmd_create_port_meter_y_action in cmdline_mtr.c, >> >> Mark those symbols as static. >> >> Signed-off-by: David Marchand > > Acked-by: Cristian Dumitrescu > Acked-by: Ferruh Yigit