From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id 7AF7A2BD8 for ; Mon, 8 Apr 2019 14:47:50 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id E155040002 for ; Mon, 8 Apr 2019 14:47:49 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id C169B40012; Mon, 8 Apr 2019 14:47:49 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 X-Spam-Score: -0.9 Received: from [192.168.1.59] (host-90-232-144-184.mobileonline.telia.com [90.232.144.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 1085D40002; Mon, 8 Apr 2019 14:47:47 +0200 (CEST) To: dev@dpdk.org References: <20190405135030.09c5291a@shemminger-XPS-13-9360> <20190408123029.6701-1-mattias.ronnblom@ericsson.com> Cc: "Richardson, Bruce" From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: Date: Mon, 8 Apr 2019 14:47:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190408123029.6701-1-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [RFC 1/3] Replace lrand48-based rte_rand with LFSR generator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 12:47:50 -0000 On 2019-04-08 14:30, Mattias Rönnblom wrote: > +static void > +__rte_srand_lfsr113(uint32_t seed, struct rte_rand_state *state) > +{ > + uint32_t lcg32_seed = seed; > + state->z1 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 2U); > + state->z2 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 8U); > + state->z3 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 16U); > + state->z4 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 128U); > +} > + > +void __rte_experimental > +rte_srand(uint64_t seedval) How do I best avoid around having this function marked as experimental? If I removed the attribute, the compilation will fail (because of check-symbol-change.sh rules). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BF158A0096 for ; Mon, 8 Apr 2019 14:47:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A1634CA6; Mon, 8 Apr 2019 14:47:51 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id 7AF7A2BD8 for ; Mon, 8 Apr 2019 14:47:50 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id E155040002 for ; Mon, 8 Apr 2019 14:47:49 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id C169B40012; Mon, 8 Apr 2019 14:47:49 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 X-Spam-Score: -0.9 Received: from [192.168.1.59] (host-90-232-144-184.mobileonline.telia.com [90.232.144.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 1085D40002; Mon, 8 Apr 2019 14:47:47 +0200 (CEST) To: dev@dpdk.org References: <20190405135030.09c5291a@shemminger-XPS-13-9360> <20190408123029.6701-1-mattias.ronnblom@ericsson.com> Cc: "Richardson, Bruce" From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: Date: Mon, 8 Apr 2019 14:47:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190408123029.6701-1-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [RFC 1/3] Replace lrand48-based rte_rand with LFSR generator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408124746.j4KbxE_rSpbuovkwCke-EjoBOrTpH3F5lJu1zkLb1Jo@z> On 2019-04-08 14:30, Mattias Rönnblom wrote: > +static void > +__rte_srand_lfsr113(uint32_t seed, struct rte_rand_state *state) > +{ > + uint32_t lcg32_seed = seed; > + state->z1 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 2U); > + state->z2 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 8U); > + state->z3 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 16U); > + state->z4 = __rte_rand_lfsr113_gen_seed(&lcg32_seed, 128U); > +} > + > +void __rte_experimental > +rte_srand(uint64_t seedval) How do I best avoid around having this function marked as experimental? If I removed the attribute, the compilation will fail (because of check-symbol-change.sh rules).