From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 848B27CE2
 for <dev@dpdk.org>; Mon, 18 Sep 2017 16:47:23 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga105.jf.intel.com with ESMTP; 18 Sep 2017 07:47:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="1173318528"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57])
 ([10.237.220.57])
 by orsmga001.jf.intel.com with ESMTP; 18 Sep 2017 07:47:21 -0700
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Cc: hemant.agrawal@nxp.com
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-3-shreyansh.jain@nxp.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <be78a122-7c20-3c23-bfe0-181131de537a@intel.com>
Date: Mon, 18 Sep 2017 15:47:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170909112132.13936-3-shreyansh.jain@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus
	driver skeleton
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2017 14:47:23 -0000

On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

<...>

> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> new file mode 100644
> index 0000000..d97a009
> --- /dev/null
> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> @@ -0,0 +1,7 @@
> +DPDK_17.11 {
> +	global:
> +
> +	rte_dpaa_driver_register;
> +	rte_dpaa_driver_unregister;

"local *;" ?

<...>

> +struct rte_dpaa_device {
> +	TAILQ_ENTRY(rte_dpaa_device) next;
> +	struct rte_device device;
> +	union {
> +		struct rte_eth_dev *eth_dev;
> +		struct rte_cryptodev *crypto_dev;
> +	};

Bus struct should be independt from functionality, this has been done in
PCI, can same thing be done for dpaa bus too?

<...>

> + * @return
> + *	0 in case of success, error otherwise
> + */
> +int rte_dpaa_portal_init(void *arg);

Definition is not in this patch.

> +
> +/**
> + * Cleanup a DPAA Portal
> + */
> +void dpaa_portal_finish(void *arg);

Definition is not in this patch.

<...>