From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9119942B7D; Tue, 23 May 2023 12:22:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 823094282D; Tue, 23 May 2023 12:22:06 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2071.outbound.protection.outlook.com [40.107.95.71]) by mails.dpdk.org (Postfix) with ESMTP id 810F840689 for ; Tue, 23 May 2023 12:22:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nJ1t9A0qzi8ygi5PcaLJ+AQlHekFKGrR7tBrdcfXMvBBI8JcyWiJh4IwKuDFDRomuF8OTqPuh0fnqrBf2VLC+6D+8Xq+wJYKZy1QXbJ/mDNYE1IO+2/KpZKzhEfmUGJfMEp3OoFwcDxPT+ulqg1Imn8RJYY4X42a4HqXS+kliQhN9Sr7xrZ8cVzyvZS9NFzvXRG7gUPlEIzeKFQXwWeE7r/sYEtpqXtx0uYgmrNFZuEavEko49YTQ9GcykSbCeU/VG8CtqfxGCFTohiKiI9rNseSs6nJqa3zvvuGCLpoAVTUNSMYqIMH7bnf6HVHbrNkRIJpbc9VwTilV5/gx55HeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QNyEloMMKZWwjXFidfVy/23s01Crbz9leadlqXNMyMM=; b=I95eTG9jOLSzfDaY7tqDYy/ro1oqyCBt7nv6u3+dWMpHc+4xxvThSRxrHxXbFm35qRv7gHKDbA/lvP7gxsFR3QjY8tXqUr+O2Zar5htPqEf8tvchksbh9GmAbkkeGzo5/WIFmUSKLeru/GFjMPddp9Q9MX6dPepm7COkW3s+AOZAQcyATIG4amoA8ormgVPeJNEhL7eyhV5kOkBVpLq+V5V+OgaKVanythqUmKHaRcW2555UDHu+/ogm4ZfrSu/NQGouZFesrR8UDrXancrI3LSTRcYS82Jeu6nGk5UyxxwgGCGJnNGWedXdATN/JS9x3RSWOY/AL+zfvafz40IktQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNyEloMMKZWwjXFidfVy/23s01Crbz9leadlqXNMyMM=; b=IYdVJxbHtdjTyhoRAsFjhDurECbgP6ElUDbmpn92yOduwgPUEJT1FKbRQS5AoPAgvLMuzS8YQKHQRih5INGjOHinWflFhcTw3ldcUiAARFwQMTPkMYs/AEeHOlZxwUfxG9WrY/oZvdnMb8Ffd9uVnBFckWTKSHemhw5WUNbAZ2Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN0PR12MB6004.namprd12.prod.outlook.com (2603:10b6:208:380::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 23 May 2023 10:22:02 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.028; Tue, 23 May 2023 10:22:02 +0000 Message-ID: Date: Tue, 23 May 2023 11:21:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [v4] net/gve: check driver compatibility Content-Language: en-US To: Rushil Gupta , qi.z.zhang@intel.com, jingjing.wu@intel.com Cc: junfeng.guo@intel.com, joshwash@google.com, dev@dpdk.org, Jeroen de Borst References: <20230519072600.1444309-1-rushilg@google.com> <20230519204618.1507956-1-rushilg@google.com> From: Ferruh Yigit In-Reply-To: <20230519204618.1507956-1-rushilg@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0664.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN0PR12MB6004:EE_ X-MS-Office365-Filtering-Correlation-Id: 36f89380-3140-48cb-4c1c-08db5b778cd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i9e/8znr+OeeMuhTIWs0e8D5yP6qWHGGeYU+6iGV71PosZbZZaPX9YOqUVE+96RVwSNk1w9J79IITYKZJMnw4t/oJgdUazw5uLCmV5pu7G9ZGgjUiz8PHmIihAYzdIA8uSoMcn7aVSqGxMsbVCIuL8xp1FsHXvFVNJb75u53R5uBEBnk/ZCE2WyVPMUbk61+mEazy/E8IMaJdgNVJ+vxEdoaCf8Nmwdm2WeKAuKaPRingo4toy3yI/cBtLv4GvUBQscrUw0JC2huvlqM6DU6YeN0GYLadCxC5M+Nl2sn1Noh/6mxT9HMxv/rOIkLlSguKVDhNRi2DetkiYJnD25D6qexSVmxybwdRMSHwNqERt9rLjLuuAb36f5fjo7ssMGxq/a6Jl3JtvTAAbmzgQX78bnUy9YMgV4N6UvO9jYn1/l3cgVT6anvbbaRQTDu95pgAof1BjBEJu1rrDsMyv/6Gqk3S5Xv+32igmowyftp0009vWt3lXm3HC5P9B3EwvRSvKXTsiJoP+KUxPrK/lCxoAVWRjjTt1GYINskdpBCsCUo+RxsX3jFMLNTJ0Gbh8jpuq1y1m586erkxX5MGzSvLym8A6oklH7EQs3y1l0pTjB1mMDwAFZWdtIPt2ay8OtMCoYPfSPqKdrBOXHdy3A44w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(376002)(396003)(346002)(39860400002)(136003)(451199021)(31686004)(478600001)(66556008)(66476007)(66946007)(4326008)(6512007)(53546011)(38100700002)(186003)(2616005)(6506007)(36756003)(6666004)(6486002)(44832011)(2906002)(8936002)(8676002)(26005)(41300700001)(86362001)(5660300002)(4744005)(31696002)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?em9NNEZ5ZncwdjQ3UzNPMlhzeEpKWlNQSlVRR3pXeXFMVVA4MFFhR1puMGtv?= =?utf-8?B?UEl2VjZQUXdyR0djdXZ5d3NOOUxmTEhzVkdjazdaQkZDUGxTcktHeFFOT3ZK?= =?utf-8?B?WUxaUkQweXZyb3NXRGZVZCtGL1lWOVhXdXRucGE5c3VLVmk0dFB1MTcyQjZ5?= =?utf-8?B?S1RtWmJXcXhNRzg0YjMxUlpYRlNLK0pSaTNkbGY3VFFNVm9aSUZjMTc5NC95?= =?utf-8?B?OVdsTFdWK2V0QnRQVHFtNWpHbGx0NFphOUpUeHFhYjNESmZBME10THExUjJG?= =?utf-8?B?b1RCVm9WZHZGajZLUEEwVnM2SlVlbzhaeGVyZVdsTU5hRnRhTFUvUU1FeG01?= =?utf-8?B?QzNuNWo2cmJNcW1vNTVMNVh1bnd0UTQzZ1h3STdoVWo4NGVBTFo0MitQdWhH?= =?utf-8?B?NVlqbEgreFFua0NpSDFWVmp0dC9VTHFHTnRabmt5TmR6dEM0VktvUTFMNStm?= =?utf-8?B?TFY1Y2RCSysvTTN3NU1MSk1IVkhweHEwVDRGSVlwWXFNRXFzTG5OVHNYQk9E?= =?utf-8?B?Qy94UFpta3c2Y3ZxQ25JdTNwY01WVXV5Sm5Ld0EzdU5ibzhkUktYeUgvSGgv?= =?utf-8?B?YlNyR1BOY3gwRVhRbEoyY1JOWnJQYk95WGZJRWZNSy9TMzdlcnNzQ2FrcHc1?= =?utf-8?B?cG9EZjJ0UDVBQWtIZmdPL0tGdWExMzVaMGRZTTZ3M3BSeFg4OWJva0FNSW1C?= =?utf-8?B?TmNZbkxHK3VIRnlaeUVCMDZKeUVTR0preUpkcFBZK1lUNEowTVZQbjhPQmwv?= =?utf-8?B?L3lBeHE4OEQyOEFCNkxNM0tFY3Y3QnpiV3RwS0dMREhKc3RmNk1qNEdZYXJr?= =?utf-8?B?K0NyUFBQUXQwYTFUaEZYTGU3YWJHcTBFcGZqbUNGVHc5aHA1MUFiazZZa2Z3?= =?utf-8?B?M1cwcXkvdmtka1ZvK204bU84ZVYvRFpsZ2cyc3VnZldMZkFtdVRUaXo4akpN?= =?utf-8?B?SHhPakE3d3hJeEJud05GYzNObzc2bVIyVFcvUGJXTEJMSTJBNlFjNGFNcGs1?= =?utf-8?B?QzhuaERjakNnRHBBdENvTkdqcnk0cDEwR00zYjRyclpzdVY2cEhIbEtOaDVY?= =?utf-8?B?U0hLcC9NbjRyeFplWTdaQ1RvN1FXWTJHN1VrOWFqQVlyNmdOanJscFp2cEsx?= =?utf-8?B?N1RsUkdVYXViWklIcTNhRUtobERtUEFxSE9BcTFEdzJDRHhCR29UNXBreE05?= =?utf-8?B?VWdNRFc1dzNXYkZmdGIvU3YyRU4ycXZHUVR4cTI2RzBMNVhiZGJhVDhFblpL?= =?utf-8?B?UTBmcW04R2l4MzN4Q3FXZzI1d1FNZy9yeDFRNGdLeEMxVXhTZ0FWOUs2VWJQ?= =?utf-8?B?WUVqZmtQQTBXMzBSc3JlTlpiT1NERGRqbzlRUXFGWnhjUzFXbkkrY2NVTzlk?= =?utf-8?B?Nk5Ub0VYSVpMRTM2WXBOVEhaRDhZQjFuamdkdUd2REJKODl1akxkZmxwcGJE?= =?utf-8?B?YlFPNHBZa2NhRTIydGZadXo3UWJTcEFFQTdsaTZOWWhkakdoYVo1N3NKT3NR?= =?utf-8?B?eE5kTmRaOGd3REpLS2YxdXZBVTZyNWpnOFdtYnBKOC9wamZtT2NQM1JuQ0Vh?= =?utf-8?B?N1VsOFZ0YmgzRENDRXBwMyt5ajZRK0tiTktacEpCV0VXbUxjQTJ0Q2FtWDRt?= =?utf-8?B?QTRDdVZUc1pLWDNPT3NZZ3R5Zy9hbTFtWFdiakZsT2krUFZ2bnNRc3FsR2pG?= =?utf-8?B?UVdlQXZ4aDlreHRsUGdBMFNTclloQnBPZzE5T0xvNUk5VVNjY240a1JKTDNy?= =?utf-8?B?VzhyWkRoNWpXSmZOMG15MDdhTUNGVzdYMzRIUVdRa09VTndnRklHNUxpVUts?= =?utf-8?B?RFMxcXVGTFVrOXBMNi8yODlqWGZiL3B0SUNuWHUrcVFKMTZ5Yi9ydkpRVzJV?= =?utf-8?B?VTFNL2VFS21VUzNHWDR5L2pDYXhiWHJtelM0aDhZdnZCRDNCS2hmWGp0K2o3?= =?utf-8?B?VjRzM25UY0lMU0hCekRMTVgrTDlJemEyYUduUVJLTFB3cUFWV2czS2tJTGQv?= =?utf-8?B?aVowS3krWC9PT1ZiTkY4RFdnby9YQmU3QUZ0RGhtQnp3d2F2WEpXcFBnZFRZ?= =?utf-8?B?Z0paVXgrZklYR2ZQZW1pbk9NYkwycitXMENVTVhQM3VEMG9BM3N5U00xc0hC?= =?utf-8?Q?nKyViyjCZd2a93y/b6fc/ZqRZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36f89380-3140-48cb-4c1c-08db5b778cd2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 10:22:02.7674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ODB5oKl/ihri/Ngi98WdRuHEx5Od0KzuOkfzCYWxsC5zNA1+wK+prx5vQyCmB/6Y X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6004 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/19/2023 9:46 PM, Rushil Gupta wrote: > diff --git a/drivers/net/gve/base/gve_osdep.h b/drivers/net/gve/base/gve_osdep.h > index abf3d379ae..5e8ae1eac6 100644 > --- a/drivers/net/gve/base/gve_osdep.h > +++ b/drivers/net/gve/base/gve_osdep.h > @@ -21,9 +21,14 @@ > #include > #include > #include > +#include > > #include "../gve_logs.h" > > +#ifdef __linux__ > +#include > +#endif > + Can you please use 'RTE_EXEC_ENV_LINUX' macro instead of '__linux__'?