From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D95EA0542; Mon, 24 Oct 2022 17:09:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19297427F0; Mon, 24 Oct 2022 17:09:50 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2042.outbound.protection.outlook.com [40.107.220.42]) by mails.dpdk.org (Postfix) with ESMTP id DBC8440A8B for ; Mon, 24 Oct 2022 17:09:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NEAa+nQaBsufXk/Bqs3ffnt0WxdPY/GmxudZNFljekRtjLqMFGWMoY4SA1IBByQz2tDsgFAbZmv7Ec+/+OwJI4t3dru4urhvadUtkHrzH1ajFEkc9R3VgWtM2eEKiT+KJKM3syhKs5NYZ8pzQEFg6tfVBGWcrsKILINfhgtoVCtm/ZUsR2ZtoNXqzGJxOFYp6a7+nLw4xYdpoShyRrxSqsPIsOXqSWEwa5uHuPhmHRtLI3HII5QN8Gx/26qD0n9iN2MI9nVqS7cDVTF3xGCLB5MvQS3cx9/3Y6WBslpNkP59V8p+gylYKx0f8t820cnYd90MYafpTrGutjfx85KWSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZV5fTlOaq1HRAC3ZBVkz7nycEKacCQh1XXsK5AsNb5k=; b=NlM+54WWK315gmTtKoIcdf1ivcAQGLw6DywNKMsz6mBDQl1HR6mGY7MbCwJBzGaSEzNOnv2ifBBPliGvRfYhS3xkecnIPDYTdXJMPvh6mK3vl5iRN4tAushKccuxWxEZmzfM5zzuGsgcUgJIk4qqziqE8L2WZtAqaoZDGKBOfalh9b+4XFemDEIi4P/CkhMAA2cEExKGFkFqn85zlyb+WFHEmBFiFK3JIcM4OnNKtkHJjn4ZxP8JzlnGnA7TzhZKSwC5hmIggjsxhn89T7r4VIHg9tmVQIDdsfxsWxPAnX+liBB2lGHJckeB1IkRBqvgIzNj6QrOlohza3QUsI1JbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZV5fTlOaq1HRAC3ZBVkz7nycEKacCQh1XXsK5AsNb5k=; b=OFezRDRr1hFo6hghOT8u4RxpN+BblxNU+c+U4s1ybtVBY2abgu4UKH4E33WZ3H+AO2XoHzynG1cBDXCZkORMj/whFglNFQPA1OOJALO56mxlwEwpQdFxOe1ZV9Gygy6o8CJJ0r0rktCZmFyMm3U36gyeV2N7KGx1OpuJmM1Cxc4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DM4PR12MB7645.namprd12.prod.outlook.com (2603:10b6:8:107::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Mon, 24 Oct 2022 15:09:47 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Mon, 24 Oct 2022 15:09:47 +0000 Message-ID: Date: Mon, 24 Oct 2022 16:09:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 25/25] net/nfp: support new tunnel solution Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com References: <1666063359-34283-1-git-send-email-chaoyong.he@corigine.com> <1666427069-10553-1-git-send-email-chaoyong.he@corigine.com> <1666427069-10553-26-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1666427069-10553-26-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0070.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::10) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|DM4PR12MB7645:EE_ X-MS-Office365-Filtering-Correlation-Id: 83f97a98-b7f8-4fe2-b977-08dab5d1c9cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ocfJU1M1GuRYd8QcMagN/R9vOXJWvx4gvm6rS5rXljhnj2fDK5jJBpMjsE6rzpOKbh4CIXazd19byVnP1vpA+zm1yKMNch5Rc419LoRW8tAJzmDPamMaFqofI8SwvGiYO0AvYQy5+Is8JGSoFSqmwd7bYT6PMdXsBHXaPW3cR11J3pZaB9mgRuqEYe+AX/abmj5q0sa4ByEt0fkIGA5Z4dXFT/KCZq+4nDdpHO3q0xITpiFILIGKfHX52Mhmit8d9XSAbr5U5YIjlCJjCgxFn8XGy1mrc/5wq/EqB2T0Jb/1u0zdpWP7XK/q9YckBFYWfL8Qi3rtdbJ1BtP4P1a72sgMlffYnoY2wyyCkj3prymKFjhzH1RxxGDY6D397vrlRRQkExMasRZvXL/GT74X0ry/4C3TYXvG3U7pKHw2MGd5iJ/Luk5LbdMd6sKxr8k+FwIXGG3zLNIVyNr6Z15GZZmA3LHWhbGcDfJ1wmncB7kOkLteV9w4XU/F8J+P/GTIfIdVQbgqq4sQYlheIUAOLTnpjY/Of0f5l1TaUy2WXiwBHpQ8q8NXSKIzgYyjHvnrwEdH3eyC76s8LCEluDZtq5wW1la54MpCDn6o4Oh9gTaQzZWdkih7SwaAx3xRucVKaAsuDc5/HrukhXbKTmAmVQb07VTT/e3WgkDanFIqD8CDteN5PpKgtuRrv0TM3R7Pm/EaSvv79Af2NbQWiwTqcX3LM4TA+Lv9fsnVYrgw5xQKMjyxU6BXNwj0SaYTkaAozsIdf/MYIl/hG6ZRviuMlwnSlI5wmDamutRGanNVW04= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(451199015)(2906002)(186003)(31686004)(83380400001)(41300700001)(4326008)(6512007)(6506007)(53546011)(8676002)(26005)(86362001)(31696002)(36756003)(316002)(38100700002)(5660300002)(8936002)(66556008)(66476007)(44832011)(2616005)(478600001)(66946007)(6486002)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUZub1BtL3d6ZVRvOFRhbldxTmZYemlTWk1xeUNqSmxlOUtuWjgwQmY1UmFQ?= =?utf-8?B?bkFXRm5ENFVBaUxIVWwraCtLdjJwTTdGS21HYStIQzV2UVZnKzhJd2VYWjVD?= =?utf-8?B?aWJWZU5yTHBJMFpvZUY3cmdNeUVrRFBDWlZMU0Rya2g1S2txMkg0M1FGcHBZ?= =?utf-8?B?ZVVHd05heWlsckJXTnhOVExLa0tJSmMwdUQ1RWVrQ2pjL3ZIT0RZOW5iWnlC?= =?utf-8?B?REcyaWpXeC81VXlTYWhLa3dyanU0MnNVVkp6bkdGUDZUN2pnRmNDdWkxMGNT?= =?utf-8?B?YkNJbUl2S0trVmRoSnVENHY5c3ViNVFpWUNaU0taNFVoRzFCV1liKzU0Ym5j?= =?utf-8?B?V3UyT1hoeURpMWNlNDJXR2VhU3VYVXVZRTBVY3M0ZWlEZlVYSU1hOEFGcTJT?= =?utf-8?B?alh1bjNUWTEweU1yNUtUOTFpZUpxeWdUUFYrbHplOXlzckVjcU9nWVpoT3Jm?= =?utf-8?B?MUxQNE5URDJ2U2ZudUF2YmY5YnNyNUh6NVR0M3Q2QVdlckVCYk1tcmxaWERQ?= =?utf-8?B?ZGdNdmVlS283UmVHWi9ISFVVU3l4Ni9TNjk2bUM1Rk5RVXJxSlgxMkhiZ2Rn?= =?utf-8?B?YzhsNkkzREx2azFQS0YyVU53NndkRXc0Uml6VHNCUlI1c09aMDJab3NSK1pQ?= =?utf-8?B?eGxTU08xOHVtUXJzNEtXSHVEQTlGRXFPT2lwd3VSZ1dXT2xrZmI0SyswK0g0?= =?utf-8?B?RjM4c3pBSDh0SENtRXhNWUdBNGkzYzdEY1pIbmR1OWgyelM0NFRSWlhJNGhZ?= =?utf-8?B?UzFRUzcwTXZYRUoxVFVZaC84SWpPNjhxQW12bUR2ZFZvUDUveEVydW5zbHR5?= =?utf-8?B?WkFvSzAvNnRDQWZmajcyWC9YZk5XRVZSUGJlbktNRjZ1YjBXc3IrRWJlNkc4?= =?utf-8?B?MFRhZW56S3E4dEhLbXFTN1c1NUp3RUdUMDdoRGk5TmdpdDFaTUlLbjdYQTUv?= =?utf-8?B?dEhrZTdxdmFpVnNwRGFvcFluSGZzczNadDdQSndPa1ZZSkoySm5iNWlmRkRu?= =?utf-8?B?U09IODZGTGVHOWxKakk3dUtGOXRWMWFMSWcyWndDQ2NNL1BkRW5COUR5U2M1?= =?utf-8?B?ZDM3ZGIvY2IwSGtXbEVYSm0xTm5OUTJFVzRXQnoxaHY3ZnM2ZEx6MlFXUUlN?= =?utf-8?B?eVRMSHhadnNucG9OT1FEVWkxRk1HaXlFSTg1STJJWSt1QldqSk9MNzFabXlr?= =?utf-8?B?N2h3V1JyZTlOOURjVndEaVFUNWk1VTN6akF4VXVzYlVlQ1ZFVHE2VGdsU05r?= =?utf-8?B?R1ZZK0RMVkQ3MmYvdFZxc3pLeEg1SWZXWjIxWjZSSjlPUlkzSGFWOUZqL2JI?= =?utf-8?B?UGpKNElwRGYrdlB1bEs1Nml5ZXcwY0NqUXV2dVpXZXpnQmVjOFV3R3hWS0NI?= =?utf-8?B?WmdFY2JEa3ZXcnNHWDhaSGFXNy9jNDhzVGdaTG90aUpndjdTMWpHcjhPSWdV?= =?utf-8?B?a1VXUHJVSmFWZDlOMHhIcGZkdmpQZnMyZmlXUjh1OFZLSEE5dUtlcXpYWllS?= =?utf-8?B?OUNXeHdKL0hPN094K0FuR2E3bkpONWxoTENQaFYzZ3BsOFdwa1BMUkZ0ekxN?= =?utf-8?B?dGRYSEZoVDcwT08yRkUxUWNpWW5UdmpsTnNtY2RWMnd3N2VUd3lLK05hWUYv?= =?utf-8?B?a09BYkpTSHcrTFFucmo5SXhmRDFpNjR5cHdZRS83UUtvMVlVWE9XVlJqRDAx?= =?utf-8?B?RjJLTDk3ejBJaHBGWTlhMTd6SU5EbGtrKzZLSEN1OWRHMTljNExtcDVjY3hr?= =?utf-8?B?TTlLTHNWWHRHaUhRUkNMYXphbnJmM0o4eG53TGRtakxCbmVjUDBuaWphYjBF?= =?utf-8?B?MXRaeEptQ1NIYzVMOWk3Uk5UaXU3bllrR2xWUUxQZG8zMXBBTnIyYlBlRFNu?= =?utf-8?B?aU81NldCTUo3bGpRNHBaSGdIRjB3bm1EdHN3S0VlY3d1aWpGYXFYUkpId0lv?= =?utf-8?B?TnRGb0xlaXpBZFNUc1FMdTFGTkZ1UkJNczVETXM1UHVGc2pDZHQ4dnFaNkZY?= =?utf-8?B?UWFrNlVtYWNEL1c3Q2R5TlRod2MzNDVKVlUyaFkvRlFCOHZ1TzRwWVU1NXdU?= =?utf-8?B?OUE5amxmckxpZmE0Q013a3MwMlI3SE1aZFB2OEZ6NkxnaU1ydWlzUlZtQzB4?= =?utf-8?Q?nTNJ95I0ZYjap4Pz08FMckEuY?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83f97a98-b7f8-4fe2-b977-08dab5d1c9cf X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 15:09:46.9346 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jx2SMzgS0g1BS2dLHReY2X8cCQcS4dUXihwuWKPu8yLQmDPW4mwQgY0IOX9tfd98 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7645 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/22/2022 9:24 AM, Chaoyong He wrote: > The new version of flower firmware application add the support of > a new tunnel solution. > > It changes the structure of tunnel neighbor, and use a feature flag > to indicate which tunnel solution is used. > > Add the logic of read extra features from firmware, and store it in > the app private structure. > > Adjust the data structure and related logic to make the PMD support > both version of tunnel solutions. > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/flower/nfp_flower.c | 14 ++++ > drivers/net/nfp/flower/nfp_flower.h | 24 +++++++ > drivers/net/nfp/flower/nfp_flower_cmsg.c | 4 ++ > drivers/net/nfp/flower/nfp_flower_cmsg.h | 17 +++++ > drivers/net/nfp/nfp_flow.c | 118 +++++++++++++++++++++++++------ > 5 files changed, 157 insertions(+), 20 deletions(-) > > diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c > index 41b0fe2..aa8199d 100644 > --- a/drivers/net/nfp/flower/nfp_flower.c > +++ b/drivers/net/nfp/flower/nfp_flower.c > @@ -1074,6 +1074,8 @@ > nfp_init_app_fw_flower(struct nfp_pf_dev *pf_dev) > { > int ret; > + int err; > + uint64_t ext_features; > unsigned int numa_node; > struct nfp_net_hw *pf_hw; > struct nfp_net_hw *ctrl_hw; > @@ -1115,6 +1117,18 @@ > goto vnic_cleanup; > } > > + /* Read the extra features */ > + ext_features = nfp_rtsym_read_le(pf_dev->sym_tbl, "_abi_flower_extra_features", > + &err); > + if (err != 0) { > + PMD_INIT_LOG(ERR, "Couldn't read extra features from fw"); > + ret = -EIO; > + goto pf_cpp_area_cleanup; > + } Hi Chaoyong, It looks like there are two flavor of the flower firmware application, one with 'extra_features' other without it. Does this worth documenting in the driver documentation and the release notes?