From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76346A0A02; Fri, 26 Mar 2021 11:00:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A5F940685; Fri, 26 Mar 2021 11:00:11 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 9D77F4067B for ; Fri, 26 Mar 2021 11:00:09 +0100 (CET) IronPort-SDR: /4KKVlv3xIDOVyiRzwyfdVKVmkH2WnWh/JMRD6WegPmepW8SXgqqt7390aiNHbuvyDO+IyJ2Uf wagyfk1lntWQ== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="191148692" X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="191148692" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 03:00:08 -0700 IronPort-SDR: dmDa/eKUcMs2xvRD0Igk9XvLXQR7nhADxgVYv/CEuRric6NJfXtus3EsR0YvcUU6OiCpxtgA8W SWA4o7U9rgwQ== X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="409828223" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.0.58]) ([10.252.0.58]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 03:00:06 -0700 To: Ori Kam Cc: dpdk-dev , Bing Zhao , Ajit Khaparde References: <20210308223434.48768-1-ajit.khaparde@broadcom.com> <14c80ab0-217e-95b0-7997-2c4297f9ad1a@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 26 Mar 2021 10:00:03 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: fix formatting in testpmd user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/9/2021 10:00 PM, Ajit Khaparde wrote: > On Tue, Mar 9, 2021 at 4:52 AM Ferruh Yigit wrote: >> >> On 3/8/2021 10:34 PM, Ajit Khaparde wrote: >>> Fix formatting in testpmd user guide for hairpin operation. >>> >>> Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup") >>> Cc:stable@dpdk.org >>> >>> Signed-off-by: Ajit Khaparde >>> Cc: Bing Zhao >>> Cc: Ori Kam >>> --- >>> doc/guides/testpmd_app_ug/run_app.rst | 12 +++++++----- >>> 1 file changed, 7 insertions(+), 5 deletions(-) >>> >>> diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst >>> index 3035118cdc..8ec2300ee5 100644 >>> --- a/doc/guides/testpmd_app_ug/run_app.rst >>> +++ b/doc/guides/testpmd_app_ug/run_app.rst >>> @@ -531,11 +531,13 @@ The command line options are: >>> >>> * ``--hairpin-mode=0xXX`` >>> >>> - Set the hairpin port mode with bitmask, only valid when hairpin queues number is set. >>> - bit 4 - explicit Tx flow rule >>> - bit 1 - two hairpin ports paired >>> - bit 0 - two hairpin ports loop >>> - The default value is 0. Hairpin will use single port mode and implicit Tx flow mode. >>> + Set the hairpin port mode with bitmask, only valid when hairpin queues number is set:: >>> + >>> + bit 4 - explicit Tx flow rule >>> + bit 1 - two hairpin ports paired >>> + bit 0 - two hairpin ports loop >>> + The default value is 0. >>> + Hairpin will use single port mode and implicit Tx flow mode. >>> >> >> Not sure if the last line intended to be part of the list, what do you think >> only keep bit descriptions in the box but left the last sentences as regular >> paragraph. >> Ori please correct me if I am wrong with the original intention. > Ori, > Not just indentation. How about this modified text as well? > > - bit 0 - two hairpin ports loop > - The default value is 0. > - Hairpin will use single port mode and implicit Tx flow mode. > + bit 0 - two hairpin ports loop (default) > + > +.. Note:: > + > + When hairpin is used in single port mode, Tx flow rule will be implicit. > Does this statement look right? > Ping