From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 589D1A0565; Mon, 2 Mar 2020 04:10:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B562C1BFF9; Mon, 2 Mar 2020 04:10:21 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id EC6B91BFF8; Mon, 2 Mar 2020 04:10:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2020 19:10:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,506,1574150400"; d="scan'208";a="239405485" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 01 Mar 2020 19:10:18 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 1 Mar 2020 19:10:17 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 2 Mar 2020 11:10:15 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Mon, 2 Mar 2020 11:10:15 +0800 From: "Li, Xiaoyun" To: "Jiang, JunyuX" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] examples/vmdq: fix the output of pools/queues Thread-Index: AQHV7IDfgOC0X+YoykOM4DXXNY9WLag0pm0Q Date: Mon, 2 Mar 2020 03:10:15 +0000 Message-ID: References: <20200226075748.67911-1-junyux.jiang@intel.com> <20200226083525.68649-1-junyux.jiang@intel.com> In-Reply-To: <20200226083525.68649-1-junyux.jiang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/vmdq: fix the output of pools/queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Jiang, JunyuX > Sent: Wednesday, February 26, 2020 16:35 > To: dev@dpdk.org > Cc: Li, Xiaoyun ; Jiang, JunyuX ; > stable@dpdk.org > Subject: [PATCH v2] examples/vmdq: fix the output of pools/queues >=20 > To match the pools/queues configuration, the pools/queues output should s= tart > from VMDQ base queue. This patch fixed the issue. >=20 > Fixes: 6bb97df521aa ("examples/vmdq: new app") > Cc: stable@dpdk.org >=20 > Signed-off-by: Junyu Jiang > --- > examples/vmdq/main.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index > 011110920..dcba3a708 100644 > --- a/examples/vmdq/main.c > +++ b/examples/vmdq/main.c > @@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m, unsigned > dst_port) static void sighup_handler(int signum) { > - unsigned q; > - for (q =3D 0; q < num_queues; q++) { > - if (q % (num_queues/num_pools) =3D=3D 0) > - printf("\nPool %u: ", q/(num_queues/num_pools)); > + unsigned int q =3D vmdq_queue_base; > + for (; q < num_queues; q++) { > + if (q % (num_vmdq_queues / num_pools) =3D=3D 0) In your logic, this should be if ((q - vmdq_queue_base) % (num_vmdq_queues= / num_pools) =3D=3D 0) > + printf("\nPool %u: ", (q - vmdq_queue_base) / > + (num_vmdq_queues / num_pools)); > printf("%lu ", rxPackets[q]); > } > printf("\nFinished handling signal %d\n", signum); > -- > 2.17.1