From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC60C4341B; Fri, 1 Dec 2023 10:41:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B997B402B9; Fri, 1 Dec 2023 10:41:45 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2078.outbound.protection.outlook.com [40.107.244.78]) by mails.dpdk.org (Postfix) with ESMTP id 886DA402B6; Fri, 1 Dec 2023 10:41:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/+vOHg/5qQPqo7lg0YmOStVLp2xbIqKTTvE1anaA+wr+NFkEKXOgkltq8mlAbRodm8LnIsk+wFdq3YQIlWVHPmbIa7x3W+6WJmdd3CLDFyPw4cPGIcdEhJ8GeQqLOFdH1xEDj/ckgAFwhMSiCIUJiBLOtwebWSb6GtyDj3r5C+a011+i+Lyv6WdcTgBtyRdvxOTt/av4eTipzbWfP/hTblnG5m4wM6HshM7zyVcEYVfSDPOsjpa+4rEWG+QWI6SswANWarpl2fWOLB+ey1mqCtwYtkUvf209JDpO+7XQuW3d0hrERjBFYHpBBuQd9ffJ8eeHhfghNFm7kHuLuDzQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iLNhVnkhMP2eC3TjmAY0KEPQ9c7L0IaLoPCDT8q9Ko8=; b=BnYBUc9vQF2jb8e1jxgUgu1JeSu7INidSfz1h0gQGHjg9G89Gzy7MhwGJA93C3v+e1tINdsEhw1vXtvXbL2MGk0ZdTywimarwBJFw/g4v3wv9CS5HAfDNi4z1faCxzUhlQnjKZqz+B80I5zysYy7Je+EFUcxzxof4h+/xisSlar5ZQLnAq2jxR4DL51DMIC0DBMoXTXy4StLm7aV79P/Gs2RR29vPg6//eb2Ym1jzx3P8GdY/Rf2+mJhqMuyvT+sv26lSSueIkCfH7gzvZE3qmjIDndNtKhYqez9ZgylL7cxFTX7akdq9B5bsH95Kuc1rd9ONPxi3/rFYAaz9t69rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iLNhVnkhMP2eC3TjmAY0KEPQ9c7L0IaLoPCDT8q9Ko8=; b=aflgXi3sR+bsrextADNGd64nmQLBn4M2mFMBb7ryjKA4ytq9hVwaE0zWOMGlSyQpgx0VeoefHd75Wt862FuhHOGMy5HOCYC4BtbKIwfdm7VBEOJDCsBxpNnFLEz7Ly+R1wiBPqzRmDPEBUtWAau+Q3tfEfXNhi9ofATO4eQYolI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB8188.namprd12.prod.outlook.com (2603:10b6:610:120::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.24; Fri, 1 Dec 2023 09:41:41 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7046.027; Fri, 1 Dec 2023 09:41:41 +0000 Message-ID: Date: Fri, 1 Dec 2023 09:41:35 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] net/nfp: fix resource leak for exit of CoreNIC firmware Content-Language: en-US To: Chaoyong He , "dev@dpdk.org" Cc: oss-drivers , "stable@dpdk.org" , Long Wu , Nole Zhang References: <20231130085238.60290-1-chaoyong.he@corigine.com> <20231130085238.60290-6-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c9::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB8188:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a693045-d074-491e-7908-08dbf251b8e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eMuVxG3Xdwzq0wBzoKe3VAbHHfAkJJ7Pgwutqvam1RguHiJCXbw+KPNvKERQg0bYP/ZSOdMLhvGYGgglLuesNTjFc4WeO0+i8pwNiK4mq3YYqREuNy4DQtmQKME68osCQkDeYUaZ0lZZvCkgrntdIaTKRLljcisGAcBgIfX55gXkThN/rMZpep8UkT7a9CqnjpkVliUzRvK0adbHbaDDuto6pz6oWrjdexJcoXQG3OWq01XrDmw7WltayGENKH+L9/Pc4DEIqbYy1hxAW39BXLLypvtNDQLTHssv3kMbS/V4EUOjS4aUrlFYZ158utNzLnwno5wdndHqb9AkFS/dOdXSXaQYgtsEC6bUQjGaPrDzQ+E3kBHh4YdNeG/IAXDuUTX6bTLrdOWlDm6exftqUBNoKSlzptmkTlJY+kBgT3bie7TPO38HvViV0035GOeui5Gb/N26vp9y6LzXPfHS3jV3+8+9f2q06MtLmCfY4e+Q2UzROuShPN+GccZ+H8cJrA9+Znq3/7tTs4G9F4sBchujYtlf6nnH9b2AflYMqIuzGR80JcMGfR+gb0FcAYLOk2lnei1purKXVkpU7eQTi8vi//Rt3wVC8U2n+RXkZWndTNSI4/LgdMP2SeZY+3I0b5AUCyUD3hqIx0hRUx8pZw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(366004)(376002)(136003)(346002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(86362001)(31696002)(4326008)(26005)(8936002)(8676002)(44832011)(31686004)(38100700002)(41300700001)(83380400001)(6512007)(36756003)(5660300002)(2906002)(6486002)(66556008)(66946007)(2616005)(316002)(66476007)(478600001)(53546011)(6506007)(6666004)(54906003)(110136005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WStiMDRYeExPU0NSelJKR2NzMHVqN2prT0xjSjhkN05wY0NRUzZpMDRWakty?= =?utf-8?B?dG1kZzFRNW9BdDJKdC9adW5XZW9hZllMbFBnWFo1azhkcmNSUXh5YytiTyt2?= =?utf-8?B?cEc5SjFFUmZ4dzFnZGJ5eUk1c2RaL0x1dHdoM3ZDcmpYQXR0SEk2aE92SWY0?= =?utf-8?B?aTVVdSsySmZOUk9XWmRoQnF4Zmtrb202TitYbU50NG5Hd2x2TG90bzNEUWxV?= =?utf-8?B?RldhRTJVWWMvd1cvUG1oeVdIUlZ4R08xSTBkV0M4UDE4UWdjcHFXSXYxR01r?= =?utf-8?B?WGgwR1J1MEhhSnNzbWkxb3JkajdhZXpSN0pCTDBWeFVxS2R5N0dVQTFMNVAv?= =?utf-8?B?ME5uK001aTkyaG02SW03MTJuT3NRQ1hRRG1ZdytsVEdoTTRJT01rL0R4enlL?= =?utf-8?B?Wm1UTUpUTmJVZ29pN21JMXA3dXZXcHRieWZtVTcrWVFFOUpWSjUrdDkvWG5v?= =?utf-8?B?LzlzN1ZZZC9tcGxTaWlpNlo2bVdxUWZhamZwQWR4cnBHVTdHRlpBN2cwZWtH?= =?utf-8?B?azU5QkdkRU1lcUY2ZzA1Qm1sdUFGa3lseFlOMy9Ga3NOcXRKd0hLK1lhVks4?= =?utf-8?B?bDh4TkVFV3FmN3dRNkdrakxId2xnYU1lb2xzd1ltczl5MjVWeHZVRzBEbjRQ?= =?utf-8?B?M2pCSHFoZUc1SElscmE0aEJNZGswZEIzZHdXdXI0UnlPZHhoTVRTZUNTMHAv?= =?utf-8?B?MFc1YkpJS3dKUEtyU1lyWndzQlR5T0RFQnFENFBBU1dIaDFXVWZOS24rTjNx?= =?utf-8?B?M3M0NDNBd2Z0OUpRTGRSdVBCazI0OTNpdnBhSE5VSU1EcHV2KzN6VEUrOFZR?= =?utf-8?B?L2ZFMDJ1dFRsdi80WFc3UW14MWJqc0s2R05wTzdpbkpFeDVtKzdyNS9nK1dY?= =?utf-8?B?clpRNC9TcHJ2b2ZhN1JxaVFhc2Q2OFA0bU9XcUV2akdoK0U3Y3N4My8zek1Y?= =?utf-8?B?N2s0cU9IbzB1NDJBVjVRRHhiTWp3TVFub3R2QVhnd0ZvMU9SbTRjK0tmZVp6?= =?utf-8?B?NEZSbXFzbCtmZFVKTkpUYnhvS2EySS8zNXhnUkIyQUVuK1lWQTBNV2pkdUxH?= =?utf-8?B?WmVPeXpTZ0l0QWlaWXVBWWJPYnA1U3FyUy96WE9LZUo2YU9GYWVoSndvYlIw?= =?utf-8?B?MnFQVWRFbDIwZ1hwb25GenJuZUswU3RNUWIvcStNV2NxTkUwZmlaQUh1Tkpx?= =?utf-8?B?RUVqeEI2U0I1Y0ZicTJ2amRJZFZ5NjZzY0ZCcHo0MWx6Nkg3RXZjak5FYXRV?= =?utf-8?B?ZDRTeitjeEZtWi9OL2hhVnRnRDB3YmhKd21JTTZtMmkxL0dTOVUwOGR0akFi?= =?utf-8?B?YzJiN0I1dVgyN0VxRGp2MVdSUjZWdDdTWXdUMGEzY0tpeDZJVmN3VlA1K0dq?= =?utf-8?B?N1dSSFlYQUNNRnllVTRFMHY3aTV2M0UwVnlFQ29mYlloMGIyd3U3eEcyVllh?= =?utf-8?B?TUpmWG5uL0hMRWp2c1ZDQ1lURFBicjdDUlhKUlkzSnlUYmY4Y1ZjMUJoV2hI?= =?utf-8?B?d3hzSmFSR2V3WXgwWW44VHhwd1JzYWN6ZUN3cXVEb0lkZHFlQ0c2anNxRzlE?= =?utf-8?B?blZ5THJwdVZrdUtMZm9Ncmtzek9aYmZkRFl0NlBieG8zMk9zQmZIaS9lOE9z?= =?utf-8?B?d2FxUVV5V0VuMHNaNEVzOFlLS3lnMDV3TjViTHVJazBPS3RuQUhWWENVb1VE?= =?utf-8?B?SHFid0ZRS0ZnMHNEcGhGamdJMWwycjV1RStCZlc3WFhrcGtLTU43REx4M3ox?= =?utf-8?B?SEtsMDNDSHdKVWMwUk1sWEhsZHloSnR0RFRwWkdEelBFc2NaaDRYam1IQXBK?= =?utf-8?B?Q3ZxT0tydUNYaUsyMU1lWnRHUUlxbFVwckJKbFZLcmQ1Y2QxQnhYb1hmMDJI?= =?utf-8?B?WWU4NmFWcnJtMDBzVVUxc2xvRXBibW5JbndGY0hNVTNNS0pudFZJdTFxQUcv?= =?utf-8?B?QnJiMnE4akNEL0lRV3YrVUI0VXFaRlVzeWlzU2dkUzFoK2xsdFBVbitSK0Ey?= =?utf-8?B?YWI3eFkwV0ZKQjBIb1F3Ly9za1NSN2xNYktzeThnSG1OZnVrbk44SXF0TjhY?= =?utf-8?B?RjVrU0JYcFZ0S0tnSHJxRzNQemRQYjcyc0VDbzRaNE1Fb3MwQkRlR1F0VW9t?= =?utf-8?Q?PcSU=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a693045-d074-491e-7908-08dbf251b8e0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 09:41:41.5410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vKXhffCoM9HLjH/9TQ3BbgaU4IN418KYLtYucmIaGLVv0DKXtf85FC4+6OLrf0Gx X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8188 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/1/2023 3:00 AM, Chaoyong He wrote: >> On 11/30/2023 8:52 AM, Chaoyong He wrote: >>> Fix the resource leak problem in the exit logic of CoreNIC firmware. >>> >>> Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Chaoyong He >>> Reviewed-by: Long Wu >>> Reviewed-by: Peng Zhang >> >> <...> >> >>> +static int >>> +nfp_pf_secondary_uninit(struct nfp_pf_dev *pf_dev) { >>> + free(pf_dev->sym_tbl); >>> + rte_free(pf_dev); >>> + >>> + return 0; >>> +} >>> + >>> /* Reset and stop device. The device can not be restarted. */ static >>> int nfp_net_close(struct rte_eth_dev *dev) @@ -333,14 +381,25 @@ >>> nfp_net_close(struct rte_eth_dev *dev) >>> struct rte_pci_device *pci_dev; >>> struct nfp_app_fw_nic *app_fw_nic; >>> >>> - if (rte_eal_process_type() != RTE_PROC_PRIMARY) >>> - return 0; >>> - >>> hw = dev->data->dev_private; >>> pf_dev = hw->pf_dev; >>> pci_dev = RTE_ETH_DEV_TO_PCI(dev); >>> app_fw_nic = NFP_PRIV_TO_APP_FW_NIC(pf_dev->app_fw_priv); >>> >>> + /* >>> + * In secondary process, a released eth device can be found by its >> name >>> + * in shared memory. >>> + * If the state of the eth device is RTE_ETH_DEV_UNUSED, it means the >>> + * eth device has been released. >>> + */ >>> + if (rte_eal_process_type() == RTE_PROC_SECONDARY) { >>> + if (dev->state == RTE_ETH_DEV_UNUSED) >>> + return 0; >>> + >>> + nfp_pf_secondary_uninit(pf_dev); >>> + return 0; >>> + } >>> + >>> >> >> Mostly expectation is secondary process doesn't free shared resources, but >> init and free done by primary process. > > I agree. > Maybe the comment here make reader a little confused. > But the `nfp_pf_secondary_uninit()` does not free any shared resources, it only free two memory which private to each secondary process. > What freed is not process private, it is in the shared memory: hw = dev->data->dev_private; pf_dev = hw->pf_dev; rte_free(pf_dev); And when there are multiple secondaries, one of them frees `pf_dev`, how this is not effecting others that may use `pf_dev`? >> When there are multiple secondaries active, and if one of them closes the port, >> will system behave properly? Can you please double check above logic? > > Yes, the system behave properly. >