From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE4BCA054F; Wed, 17 Mar 2021 00:29:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 619D240689; Wed, 17 Mar 2021 00:29:57 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 6138040040 for ; Wed, 17 Mar 2021 00:29:55 +0100 (CET) IronPort-SDR: u8wLCTxvD387cm1T5k8iWEYS8e9ewc0RHD2sX2a13kELC/Daf+EX+RoQ7QesaKa8cN8+5OEUay R/AlLnI8V06A== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="189400185" X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="189400185" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 16:29:54 -0700 IronPort-SDR: RLh/rohZUzWQxqPr8P7Bum1oe7aQwatxrAVmQp8R7Yu9UEpiKCt8cfZ9LeUvSeVlSXmdpDFW+m POYcBz4n92Cw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="605459031" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga005.fm.intel.com with ESMTP; 16 Mar 2021 16:29:53 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 16 Mar 2021 16:29:52 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 17 Mar 2021 07:29:50 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Wed, 17 Mar 2021 07:29:50 +0800 From: "Zhang, Qi Z" To: "Richardson, Bruce" , Thomas Monjalon CC: Andrew Rybchenko , "Yigit, Ferruh" , "dev@dpdk.org" , "Wang, Xiao W" , "Wu, Jingjing" , "Xing, Beilei" , "Guo, Jia" , "Yang, Qiming" , "Wang, Haiyue" Thread-Topic: [PATCH v2 1/8] ether: refine debug compile option Thread-Index: AQHXFzhyN3xb0mtHtU+EkKyg9JkaFqqGFXqAgAAJb4CAAAlfgIABIa9A Date: Tue, 16 Mar 2021 23:29:50 +0000 Message-ID: References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210312121223.2028029-2-qi.z.zhang@intel.com> <93fd4fce-a961-8ccf-fd32-0386461e4e99@intel.com> <8879674.o8TafV64eK@thomas> <20210316141237.GA163@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20210316141237.GA163@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/8] ether: refine debug compile option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, March 16, 2021 10:13 PM > To: Thomas Monjalon > Cc: Zhang, Qi Z ; Andrew Rybchenko > ; Yigit, Ferruh ; > dev@dpdk.org; Wang, Xiao W ; Wu, Jingjing > ; Xing, Beilei ; Guo, Jia > ; Yang, Qiming ; Wang, Haiyue > > Subject: Re: [PATCH v2 1/8] ether: refine debug compile option >=20 > On Tue, Mar 16, 2021 at 02:39:05PM +0100, Thomas Monjalon wrote: > > 16/03/2021 14:05, Ferruh Yigit: > > > On 3/12/2021 12:12 PM, Qi Zhang wrote: > > > > PMDs use RTE_LIBRTE__DEBUG_RX|TX as compile option > to > > > > wrap data path debug code. As .config has been removed since the > > > > meson build, It is not friendly for new DPDK users to notice those = debug > options. > > > > > > > > The patch introduces below compile options for specific Rx/Tx data > > > > path debug, so PMD can choose to reuse them to avoid maintain their > own. > > > > > > > > - RTE_LIBRTE_ETHDEV_DEBUG_RX > > > > - RTE_LIBRTE_ETHDEV_DEBUG_TX > > > > > > > > Also, all the compile options are documented on the overview page, > > > > so users can easily find them. > > > > English question: is "compile option" correct, or should it be > > "compilation option"? > > Cc Bruce to have a native in the discussion :) > > >=20 > "compilation options" is better. > However, throughout this patch, I wonder if "build" might be a better ver= b to > use than "compile". OK, I will use "build" in v3, thanks!