From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrey Vesnovaty <andreyv@nvidia.com>, dev@dpdk.org
Cc: jer@marvell.com, jerinjacobk@gmail.com, thomas@monjalon.net,
stephen@networkplumber.org, bruce.richardson@intel.com,
orika@nvidia.com, viacheslavo@nvidia.com,
andrey.vesnovaty@gmail.com, mdr@ashroe.eu, nhorman@tuxdriver.com,
ajit.khaparde@broadcom.com, samik.gupta@broadcom.com,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: driver support for shared action
Date: Mon, 26 Oct 2020 16:38:09 +0000 [thread overview]
Message-ID: <bf15b052-53dd-d3c0-5b88-73e97ee6626d@intel.com> (raw)
In-Reply-To: <20201023102410.20317-5-andreyv@nvidia.com>
On 10/23/2020 11:24 AM, Andrey Vesnovaty wrote:
> Implement shared action create/destroy/update/query. The current
> implementation support is limited to shared RSS action only. The shared
> RSS action create operation prepares hash RX queue objects for all
> supported permutations of the hash. The shared RSS action update
> operation relies on functionality to modify hash RX queue introduced in
> one of the previous commits in this patch series.
>
> Implement RSS shared action and handle shared RSS on flow apply and
> release. The lookup for hash RX queue object for RSS action is limited
> to the set of objects stored in the shared action itself and when
> handling shared RSS action. The lookup for hash RX queue object inside
> shared action is performed by hash only.
>
> Current implementation limited to DV flow driver operations i.e. verbs
> flow driver operations doesn't support shared action.
>
> Signed-off-by: Andrey Vesnovaty <andreyv@nvidia.com>
<...>
> +static uint32_t
> +__flow_dv_rss_get_hrxq(struct rte_eth_dev *dev, struct rte_flow *flow,
> + struct mlx5_flow *dev_flow,
> + struct mlx5_hrxq **hrxq)
> +{
> + struct mlx5_priv *priv = dev->data->dev_private;
> + uint32_t hrxq_idx;
> +
> + if (flow->shared_rss) {
> + hrxq_idx = __flow_dv_action_rss_hrxq_lookup
> + (flow->shared_rss, dev_flow->hash_fields,
> + !!(dev_flow->handle->layers &
> + MLX5_FLOW_LAYER_TUNNEL));
> + if (hrxq_idx) {
> + *hrxq = mlx5_ipool_get(priv->sh->ipool[MLX5_IPOOL_HRXQ],
> + hrxq_idx);
> + rte_atomic32_inc(&(*hrxq)->refcnt);
I remember adding more 'rte_atomicNN_xxx' to driver has been discussed before,
and it has been mentioned that a seperate commit will be done to replace all
instances, I would like to remind it, and is that work planned for the -rc2?
next prev parent reply other threads:[~2020-10-26 16:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 12:18 [dpdk-dev] [PATCH 0/4] Shared action RSS PMD impl Andrey Vesnovaty
2020-10-08 12:18 ` [dpdk-dev] [PATCH 1/4] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty
2020-10-08 12:18 ` [dpdk-dev] [PATCH 2/4] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty
2020-10-08 12:18 ` [dpdk-dev] [PATCH 3/4] net/mlx5: shared action PMD Andrey Vesnovaty
2020-10-08 12:18 ` [dpdk-dev] [PATCH 4/4] net/mlx5: driver support for shared action Andrey Vesnovaty
2020-10-23 10:24 ` [dpdk-dev] [PATCH v2 0/4] Shared action RSS PMD impl Andrey Vesnovaty
2020-10-23 10:24 ` [dpdk-dev] [PATCH v2 1/4] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty
2020-10-23 14:16 ` Slava Ovsiienko
2020-10-23 10:24 ` [dpdk-dev] [PATCH v2 2/4] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty
2020-10-23 14:17 ` Slava Ovsiienko
2020-10-23 10:24 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: shared action PMD Andrey Vesnovaty
2020-10-23 14:17 ` Slava Ovsiienko
2020-10-23 10:24 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: driver support for shared action Andrey Vesnovaty
2020-10-23 14:17 ` Slava Ovsiienko
2020-10-26 16:38 ` Ferruh Yigit [this message]
2020-10-26 16:40 ` Thomas Monjalon
2020-10-26 22:33 ` Asaf Penso
2020-10-26 16:40 ` Slava Ovsiienko
2020-10-25 12:43 ` [dpdk-dev] [PATCH v2 0/4] Shared action RSS PMD impl Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf15b052-53dd-d3c0-5b88-73e97ee6626d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrey.vesnovaty@gmail.com \
--cc=andreyv@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jer@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=orika@nvidia.com \
--cc=samik.gupta@broadcom.com \
--cc=shahafs@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).