From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07456A04DD; Mon, 26 Oct 2020 17:39:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 171922BFF; Mon, 26 Oct 2020 17:38:27 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 444B52BDB for ; Mon, 26 Oct 2020 17:38:19 +0100 (CET) IronPort-SDR: S9qt2pp/oPTNxemuwCJmT0ZQii7bH9l3EiWi6Db2luD0cQU9gtvDgjmg7XdzjofDzPHkSRlc75 6SLw5e15K+rQ== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="155731603" X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="155731603" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 09:38:17 -0700 IronPort-SDR: oQlemw6VVjm/07zGFKZ/azvvqEJwuLK36gZlEFwp9ESRtXAJ5n+vtWBkYgl9NY112jQFOQTRvY p5fiXdi3Wn1g== X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="525556913" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.225.151]) ([10.213.225.151]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 09:38:13 -0700 To: Andrey Vesnovaty , dev@dpdk.org Cc: jer@marvell.com, jerinjacobk@gmail.com, thomas@monjalon.net, stephen@networkplumber.org, bruce.richardson@intel.com, orika@nvidia.com, viacheslavo@nvidia.com, andrey.vesnovaty@gmail.com, mdr@ashroe.eu, nhorman@tuxdriver.com, ajit.khaparde@broadcom.com, samik.gupta@broadcom.com, Matan Azrad , Shahaf Shuler References: <20201008121848.15330-1-andreyv@nvidia.com> <20201023102410.20317-1-andreyv@nvidia.com> <20201023102410.20317-5-andreyv@nvidia.com> From: Ferruh Yigit Message-ID: Date: Mon, 26 Oct 2020 16:38:09 +0000 MIME-Version: 1.0 In-Reply-To: <20201023102410.20317-5-andreyv@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: driver support for shared action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/23/2020 11:24 AM, Andrey Vesnovaty wrote: > Implement shared action create/destroy/update/query. The current > implementation support is limited to shared RSS action only. The shared > RSS action create operation prepares hash RX queue objects for all > supported permutations of the hash. The shared RSS action update > operation relies on functionality to modify hash RX queue introduced in > one of the previous commits in this patch series. > > Implement RSS shared action and handle shared RSS on flow apply and > release. The lookup for hash RX queue object for RSS action is limited > to the set of objects stored in the shared action itself and when > handling shared RSS action. The lookup for hash RX queue object inside > shared action is performed by hash only. > > Current implementation limited to DV flow driver operations i.e. verbs > flow driver operations doesn't support shared action. > > Signed-off-by: Andrey Vesnovaty <...> > +static uint32_t > +__flow_dv_rss_get_hrxq(struct rte_eth_dev *dev, struct rte_flow *flow, > + struct mlx5_flow *dev_flow, > + struct mlx5_hrxq **hrxq) > +{ > + struct mlx5_priv *priv = dev->data->dev_private; > + uint32_t hrxq_idx; > + > + if (flow->shared_rss) { > + hrxq_idx = __flow_dv_action_rss_hrxq_lookup > + (flow->shared_rss, dev_flow->hash_fields, > + !!(dev_flow->handle->layers & > + MLX5_FLOW_LAYER_TUNNEL)); > + if (hrxq_idx) { > + *hrxq = mlx5_ipool_get(priv->sh->ipool[MLX5_IPOOL_HRXQ], > + hrxq_idx); > + rte_atomic32_inc(&(*hrxq)->refcnt); I remember adding more 'rte_atomicNN_xxx' to driver has been discussed before, and it has been mentioned that a seperate commit will be done to replace all instances, I would like to remind it, and is that work planned for the -rc2?