From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC6F4A04A3; Wed, 26 Jan 2022 17:52:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E4C542744; Wed, 26 Jan 2022 17:52:40 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 4C05542738 for ; Wed, 26 Jan 2022 17:52:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643215959; x=1674751959; h=message-id:date:to:references:from:subject:in-reply-to: content-transfer-encoding:mime-version; bh=Ls/SIw1xBSW+EI7e15BFBOwpNi6ehfRyzhGVDCUNPps=; b=K5IsJIPz3OsLaY5zE0xAvmrC7Hu5TKHhC3JvK2lqv9FHRokWWYa4so61 BMBzXGN17QTi+D3V2VHTM3YULZekRQB2lNk1M0PcJiMztYMtFT3mPnVTb 5K7K56pC+/6e35chJnobkP3A+OW6iJOruUGSQbEtXYsQ81NtwMLo1a4kY DPu1B8By81KrZuhvvkbuvLeyx7eUeryoxK3DFErUCXu8lA8Tjwy77H2ex ESRIBYXqqB/JPWwZxmtbcFXkPXw1bH0cMUtC3EJVlh/9GJvH5PrP6cBTP jgr08NTZboLyOL9sQ6xqasMimfNHs8M5D2rvlF43lbrHn9D1zTndjGHs2 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="227265289" X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="227265289" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 08:52:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="597516310" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 26 Jan 2022 08:52:38 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 26 Jan 2022 08:52:37 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 26 Jan 2022 08:52:37 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 26 Jan 2022 08:52:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bcIevZRUPu3VUuiO9uowvGn8upOpX3k5hAr8QKa5nzUKYsSZx6+esEJX2TfYQvNornIsSQj0nqeDX495z++y7dtePhncslRk6MeLbNI5afY36vtlTLUclObSfa/Hf68OfkVpmk8mI0qGHZxYTrnrs8KFItkSQjp6Rr0e6keeDTb/1L51nTkJZS9saX8Nskk7du+edgHQjyGRrRFLhbJE1VS8qJang+Hg52OfD5OOvvghpSc1mkya2Bhd8GnTFr8HDnopofyrMP5BsKeh2K9wZfB9IyE2ZRpE+1MolPuTnQj/47q52+ZEsS6fM+Bj2Y+DGWMRmDCeKJmpV+kcnhtpVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dXXSjABDDwlyFFStLbHk8jLjjgvbTDZfywmg1fRgN7s=; b=RCk+GuMLNF43R6I3pa0gWEOQJZoHRa1kXNTnlFgWPBoyuFB0s0jkEnd3vXQW5YZFIUopIpo1tn7NaOJbxGUX4RIHIngheJ9ZGSjizcfqACI/g62I0g2dhdj18vBL9JKWpCK4D9srs4PVL5ZVX0n8HQWSDfQGTPefK1BNpdBOjow2Wqxeec17GdG+4t+vy/HWMf/RES8C++pUU297zeDc5X77hc+xcClFk9rpFlJK12q/dlXjdSoKI6ZhhEaC/hpMFNu/5lqJNZyHb1zGk5ivwqq4mCVJ3GN++Q/ZOM4uxN9TyIgLvNP3d34wKD5em2LAcyXa1ECCH/8Ok997zYnjIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Wed, 26 Jan 2022 16:52:35 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.019; Wed, 26 Jan 2022 16:52:35 +0000 Message-ID: Date: Wed, 26 Jan 2022 16:52:31 +0000 Content-Language: en-US To: John Miller , References: <20220119191255.273988-1-john.miller@atomicrules.com> <20220119191255.273988-4-john.miller@atomicrules.com> From: Ferruh Yigit Subject: Re: [PATCH 4/4] net/ark: support chunk DMA transfers X-User: ferruhy In-Reply-To: <20220119191255.273988-4-john.miller@atomicrules.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8P191CA0025.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0aea1e6-8738-4941-fab8-08d9e0ec40d3 X-MS-TrafficTypeDiagnostic: DM6PR11MB3625:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OhhhROOifHy3VGr0sRSuBIFjX73z0y2uUZ791n1OkQAzEqH3gzMogk0VE9ldvi03qaHOwZlKHaqiei95yU5CKvd68/eHzVO/k3gPHJJ5vlke2CsjRu2ou+JvEFP3T952bviGR3k2IksFvLBZdO+pu2QBBDuy6Toke5a6qcoP9QzJN0P2pBU6SdlmakeRPabHrDD1lSAcNcppiMq+cJPPL1vJxfZWOn7rsOnDgJ/itANHGx3NPgTYcs2VkRWTS42m8OXoRQl0IxABwj+FMogrwlLdtYcdE+IZBLpBNhctKxW0Q0xFVTm06VyclAgElR1B9rU2LmQt73ZRVTSxxGrXw+bosSEW6/ociq/vOrN3So6XCgeZM7y6xbHqMQLycPSFygKC64sSgwIXCtI/GYDVRAL2k0XrrLu81IGhyj16v2OpC/lo7YCQnJ0DZZgYnvjFXIaQlZ2lTNVFtF71IpMUWeVUcdHQUKDHJlTsUUt9YqhT5OHUDqOj8RaWVG5IgW0kHiuBV1jQ52oEFv7lCNAGLZg8NWcTxAfs1siF4KyxGiZ7U4ntRM0EGTPV01dHPNHF8jrZMEHIzHjEgOjnkIVAwOJg+/HWDXZMEqHvjQar4av3wR+najRSFeDpVzsDrIHfkT0J7ZC+ZeNTUF8UtSG8fvx84wjeWykk5Gr5cKN05d48VwTTtsBjjIElFmUU63n6tqJ0tkRNtNFyEolzgvtrDw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(82960400001)(316002)(66946007)(6506007)(6512007)(6666004)(508600001)(44832011)(66476007)(66556008)(5660300002)(53546011)(8936002)(8676002)(31696002)(36756003)(6486002)(31686004)(2906002)(83380400001)(186003)(2616005)(38100700002)(26005)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHdJK3FaamZUZHFGemtUekJKUi9UczJkcjkyVnlMVHZHZDZpZ0Z5aEF6MjBz?= =?utf-8?B?Q3ZhN0lCalRwSFdZb045bUxHbkxjOStSYTVtVFNpNmY2Smh1dTVrK1BNY2k3?= =?utf-8?B?UEN2M0RYTEtINFNKWm5qUXk5ZWthNjNpQVd6WFBmSCtpRERFYkhPamdzOVJp?= =?utf-8?B?QmdDNGU5T2JCNUxoNTVDQndJVjNNL1NqQzQxU3hiQUgzYk1DZytKWmI3b1Ja?= =?utf-8?B?RTFPbkpiZHdQUHQ0ZlFpeXR6UXM5NCtXczVKemdnQW1vdFJkOVpoNWxGWHEv?= =?utf-8?B?NmY4WUU5K0tuVXJjdkhtZGU3Q1hnUTQ1enB2alBaRHduMUNFS21TcXdteFJW?= =?utf-8?B?VkRPT0tpRUxMZ055NHQxM0t3MHRuNkdsWmdKNklkUWMyRE14bDBETU53Tmda?= =?utf-8?B?M2VHT1VXRVVtaWpTa0JsNytTTW5IKzB6YzBrQ2FIK3FicEdSMHR5OW80WTV2?= =?utf-8?B?VVhjdUlXSnB3NGgzcVFmeEY3bjI0dTh0dHFTQWVYbjBTVUJWNGgyTTJQSlRa?= =?utf-8?B?ekhmVUE3V0hDQ0lkNUdRK2pxdlVlUnFoakV5N2h3UjdtUHlkenIrZnZQS1ht?= =?utf-8?B?L0ZlaFJ1bHM3SWZ5WkpWMGc4eDN4V3I3RnRvNm8zbEhyZDc3WGRIcUhIS0Vo?= =?utf-8?B?TitFZkw3dURQc214dnF4M0h3QkhPOFJDVFhFWFFCWjIvS3J2ZVg5ZUM1R1ZX?= =?utf-8?B?TUd4azhFR0p5UWxWb1lvTnhEM2lRV01uSTJqOGdZMld5MGxOQmlCbCtVQjZM?= =?utf-8?B?U2lQZTE4YzYwMDYzMEtCUEpkZWVDalNkWHZUVEIxUFBkVWdSTStxemNTMVV4?= =?utf-8?B?RWxtWjVJWjVBOE1keW5MZTIzS3NWVG5FMkVMWEpuTEpVRjBSNFJXTHpzRTB5?= =?utf-8?B?WFJUR1V3d2hBTGJ3RUtLbDkvSWNERE14d2YxMHVvZy95Z0RQUDM1TUE1dUxC?= =?utf-8?B?QWFBcXIzZHZoKzh1Z1RRM1JBaUVxMktxSlIrV2tCV0c4NExHMlBtNHB2b2dK?= =?utf-8?B?RFNqS2NpdUlGdXFPb1pqVms1WmdWMlZRY3pBWGMzZHQwOGkyeU1lZ0FOUzBh?= =?utf-8?B?djhxdXlPOG1BVlZzZzlsREw1b1E4UUNIaE1jMnJMbmxVemlJbTY3ZXFGNWYy?= =?utf-8?B?Z01JNDBPYnZUZG5PM3BMN0dFcXVaKy90Wlk3R3puaEVaMGJIMTN1ekhKMWhR?= =?utf-8?B?NE50dGN2Slh5OHRzQURiaU9kNWthUWEvbEgrZ1dZWUxTV3Z2RE9rZ2dOd2p0?= =?utf-8?B?ajZidUxpWFE1VElubkI1Z0E5L0RjVjlXRklHYTdGNEMyNzc5TGxnak9UMWFN?= =?utf-8?B?TVk2bW5CSmtvUWhzNXhqQzFYZ1EraVM0SVlDNDlGeXpGUXNvTk44eUpHL1Mx?= =?utf-8?B?aDVTTTFPbFc1VElMWnN6NExGNGdackhsSzNMckYxYjIwby9vVFZ1WW9zOWZ3?= =?utf-8?B?MUhTRjBEWVFWOTBHb3RJdmlxRlVzQkpzV2FVTzQyWWVGZlVSWU1NcTUvM3Fh?= =?utf-8?B?c3ZENXI1TzVlMXJyaXViTnVaald5UURiZEtSaWJuZ3JMK3VNU0FIMjlJT1pZ?= =?utf-8?B?VXB2a3hOYmk1YUwwSmRhUVFtYmVRU3kwVWR6RklLMGROSEdGMDIzb015czgy?= =?utf-8?B?UDJLNDE5bW1HaWZtOExZTy9kVERyaExDSWZQQ1VJZ1lJMkdZM1BHVGFEMWoy?= =?utf-8?B?cFNjV0diaDR5aXhnQVdyTmh2OU1oaGdqNTgxcXpWNWhWbFdJbTgzZGFVcGxB?= =?utf-8?B?RWppL0hHMjZxUEZvdTVkTWFNVzhpcXFxNGZzUEJmQS9jaXAwRnRocUJ0NnVE?= =?utf-8?B?YkUxTUd4SDFqK2d0bnovdnhvZlR4elRobHp4N2R2WC80VXhlams3MlUrbWNk?= =?utf-8?B?azZFcVAzbGpiQlF6RXFoa0dNRjBhYTRHR0N2YXJsQU9mU2U1R09FWkZKeWdJ?= =?utf-8?B?UXR5ME42K25NZmV2REgwZjBvYkpoT0JCekJTdWRsVmhIRkd3emZDQzZBTG9p?= =?utf-8?B?ZitvdGNNSXZrcUZkUitKVEQvdENrN1JhMW1KRHprdFlkdG1ZejRERjl1K3dY?= =?utf-8?B?dkVyeEh2WG52cGFaTEZWenJqY0lHNGNLU3RjOGtKMXQrMWhKVW1CKzVUdDhR?= =?utf-8?B?N1pCNE1pN05RQnR2TzFKNm1VYlJnbTcra1ZWVG54M21ZcmRhSXZ3cW9CNWZ0?= =?utf-8?Q?iKvW3yz74yvfB88xD5yUk7c=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0aea1e6-8738-4941-fab8-08d9e0ec40d3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2022 16:52:35.6516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mEsgwd5XygayhGK/NZmlkA5n+ecNaY46FaSWj/MOzw0S4lCR0uTZ4TVIAEcgEmEAH2CmbneS9weSUc4qXKY3zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3625 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/19/2022 7:12 PM, John Miller wrote: > Add support for chunk DMA transfers. > > Signed-off-by: John Miller > --- > drivers/net/ark/ark_ddm.c | 1 + > drivers/net/ark/ark_ethdev_rx.c | 16 +++++++++------- > drivers/net/ark/ark_mpu.c | 1 + > drivers/net/ark/ark_pktchkr.c | 2 +- > drivers/net/ark/ark_pktgen.c | 2 +- > drivers/net/ark/ark_udm.c | 3 +++ > 6 files changed, 16 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ark/ark_ddm.c b/drivers/net/ark/ark_ddm.c > index 2321371572..b16c739d50 100644 > --- a/drivers/net/ark/ark_ddm.c > +++ b/drivers/net/ark/ark_ddm.c > @@ -55,6 +55,7 @@ ark_ddm_stop(struct ark_ddm_t *ddm, const int wait) > int cnt = 0; > > ddm->cfg.command = 2; > + rte_wmb(); Is the new memory barrier related to the chunk DMA transfer? > while (wait && (ddm->cfg.stop_flushed & 0x01) == 0) { > if (cnt++ > 1000) > return 1; > diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c > index 1000f50be0..49134ea08f 100644 > --- a/drivers/net/ark/ark_ethdev_rx.c > +++ b/drivers/net/ark/ark_ethdev_rx.c > @@ -12,6 +12,7 @@ > > #define ARK_RX_META_SIZE 32 > #define ARK_RX_META_OFFSET (RTE_PKTMBUF_HEADROOM - ARK_RX_META_SIZE) > +#define ARK_RX_MPU_CHUNK (64U) > > /* Forward declarations */ > struct ark_rx_queue; > @@ -104,7 +105,7 @@ static inline void > eth_ark_rx_update_cons_index(struct ark_rx_queue *queue, uint32_t cons_index) > { > queue->cons_index = cons_index; > - if ((cons_index + queue->queue_size - queue->seed_index) >= 64U) { > + if ((cons_index + queue->queue_size - queue->seed_index) >= ARK_RX_MPU_CHUNK) { > eth_ark_rx_seed_mbufs(queue); > ark_mpu_set_producer(queue->mpu, queue->seed_index); > } > @@ -179,12 +180,12 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev, > queue->reserve_q = > rte_zmalloc_socket("Ark_rx_queue mbuf", > nb_desc * sizeof(struct rte_mbuf *), > - 64, > + 512, > socket_id); > queue->paddress_q = > rte_zmalloc_socket("Ark_rx_queue paddr", > nb_desc * sizeof(rte_iova_t), > - 64, > + 512, > socket_id); > > if (queue->reserve_q == 0 || queue->paddress_q == 0) { > @@ -455,7 +456,8 @@ eth_ark_rx_stop_queue(struct rte_eth_dev *dev, uint16_t queue_id) > static inline int > eth_ark_rx_seed_mbufs(struct ark_rx_queue *queue) > { > - uint32_t limit = queue->cons_index + queue->queue_size; > + uint32_t limit = (queue->cons_index & ~(ARK_RX_MPU_CHUNK - 1)) + > + queue->queue_size; > uint32_t seed_index = queue->seed_index; > > uint32_t count = 0; > @@ -618,14 +620,14 @@ eth_ark_udm_force_close(struct rte_eth_dev *dev) > > ark_mpu_start(queue->mpu); > /* Add some buffers */ > - index = 100000 + queue->seed_index; > + index = ARK_RX_MPU_CHUNK + queue->seed_index; 100000 is replaced by '64', the diff is huge, just double checking if this is what intended? > ark_mpu_set_producer(queue->mpu, index); > } > /* Wait to allow data to pass */ > usleep(100); > > - ARK_PMD_LOG(DEBUG, "UDM forced flush attempt, stopped = %d\n", > - ark_udm_is_flushed(ark->udm.v)); > + ARK_PMD_LOG(NOTICE, "UDM forced flush attempt, stopped = %d\n", > + ark_udm_is_flushed(ark->udm.v)); > } > ark_udm_reset(ark->udm.v); > } > diff --git a/drivers/net/ark/ark_mpu.c b/drivers/net/ark/ark_mpu.c > index 8160c1de7b..b8e94b6ed3 100644 > --- a/drivers/net/ark/ark_mpu.c > +++ b/drivers/net/ark/ark_mpu.c > @@ -68,6 +68,7 @@ ark_mpu_reset(struct ark_mpu_t *mpu) > int cnt = 0; > > mpu->cfg.command = MPU_CMD_RESET; > + rte_wmb(); > > while (mpu->cfg.command != MPU_CMD_IDLE) { > if (cnt++ > 1000) > diff --git a/drivers/net/ark/ark_pktchkr.c b/drivers/net/ark/ark_pktchkr.c > index 84bb567a41..12a5abb2f7 100644 > --- a/drivers/net/ark/ark_pktchkr.c > +++ b/drivers/net/ark/ark_pktchkr.c > @@ -113,7 +113,7 @@ ark_pktchkr_stopped(ark_pkt_chkr_t handle) > struct ark_pkt_chkr_inst *inst = (struct ark_pkt_chkr_inst *)handle; > uint32_t r = inst->sregs->pkt_start_stop; > > - return (((r >> 16) & 1) == 1); > + return (((r >> 16) & 1) == 1) || (r == 0); > } > > void > diff --git a/drivers/net/ark/ark_pktgen.c b/drivers/net/ark/ark_pktgen.c > index 515bfe461c..6195ef997f 100644 > --- a/drivers/net/ark/ark_pktgen.c > +++ b/drivers/net/ark/ark_pktgen.c > @@ -107,7 +107,7 @@ ark_pktgen_paused(ark_pkt_gen_t handle) > struct ark_pkt_gen_inst *inst = (struct ark_pkt_gen_inst *)handle; > uint32_t r = inst->regs->pkt_start_stop; > > - return (((r >> 16) & 1) == 1); > + return (((r >> 24) & 1) == 1) || (((r >> 16) & 1) == 1) || (r == 0); Overall I am having difficulties to match changes to the commit log, are these related changes? Can you please give more details in the commit log what is done, to help the review? > } > > void > diff --git a/drivers/net/ark/ark_udm.c b/drivers/net/ark/ark_udm.c > index 28c4500a2c..9ebed89627 100644 > --- a/drivers/net/ark/ark_udm.c > +++ b/drivers/net/ark/ark_udm.c > @@ -33,7 +33,9 @@ ark_udm_stop(struct ark_udm_t *udm, const int wait) > { > int cnt = 0; > > + udm->setup.r0 = 0; ditto > udm->cfg.command = 2; > + rte_wmb(); > > while (wait && (udm->cfg.stop_flushed & 0x01) == 0) { > if (cnt++ > 1000) > @@ -70,6 +72,7 @@ ark_udm_reset(struct ark_udm_t *udm) > void > ark_udm_start(struct ark_udm_t *udm) > { > + udm->setup.r0 = 0x100; > udm->cfg.command = 1; > } >