From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>,
Shahed Shaikh <shahed.shaikh@cavium.com>,
Tetsuya Mukawa <mtetsuyah@gmail.com>,
Yuanhan Liu <yliu@fridaylinux.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
Yongseok Koh <yskoh@mellanox.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] drivers/net: update link status
Date: Fri, 13 Apr 2018 22:53:55 +0100 [thread overview]
Message-ID: <bf29cef8-7340-d8d5-6508-e4ed8625a177@intel.com> (raw)
In-Reply-To: <20180410154102.uv7og3ff4y5ylc3m@debian>
On 4/10/2018 4:41 PM, Tiwei Bie wrote:
> On Tue, Mar 13, 2018 at 06:05:34PM +0000, Ferruh Yigit wrote:
>> Update link status related feature document items and minor updates in
>> some link status related functions.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> doc/guides/nics/features/fm10k.ini | 2 ++
>> doc/guides/nics/features/fm10k_vf.ini | 2 ++
>> doc/guides/nics/features/i40e_vf.ini | 1 +
>> doc/guides/nics/features/igb_vf.ini | 1 +
>> doc/guides/nics/features/qede.ini | 1 -
>> doc/guides/nics/features/qede_vf.ini | 1 -
>> doc/guides/nics/features/vhost.ini | 2 --
>> doc/guides/nics/features/virtio_vec.ini | 1 +
>> drivers/net/e1000/em_ethdev.c | 2 +-
>> drivers/net/ena/ena_ethdev.c | 2 +-
>> drivers/net/fm10k/fm10k_ethdev.c | 6 ++----
>> drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>> drivers/net/mlx4/mlx4_ethdev.c | 2 +-
>> drivers/net/mlx5/mlx5_ethdev.c | 2 +-
>> 15 files changed, 15 insertions(+), 14 deletions(-)
> [...]
>> diff --git a/doc/guides/nics/features/vhost.ini b/doc/guides/nics/features/vhost.ini
>> index dffd1f493..31302745a 100644
>> --- a/doc/guides/nics/features/vhost.ini
>> +++ b/doc/guides/nics/features/vhost.ini
>> @@ -4,8 +4,6 @@
>> ; Refer to default.ini for the full list of available PMD features.
>> ;
>> [Features]
>> -Link status = Y
>> -Link status event = Y
>
> I think vhost PMD supports above features.
I am not able to find where it is supported.
Some virtual PMDs report fixed link, with empty link_update() dev_ops, and they
are not reported as supporting Link status, as far as I can see vhost also one
of them.
And for Link status event, PMD needs to support LSC interrupts and should
register interrupt handler for it, which I can't find for vhost.
I will send next version without updating above one, please point me where these
support added if I missed them.
>
>> Free Tx mbuf on demand = Y
>> Queue status event = Y
>> Basic stats = Y
>> diff --git a/doc/guides/nics/features/virtio_vec.ini b/doc/guides/nics/features/virtio_vec.ini
>> index c06c860d4..e60fe36ae 100644
>> --- a/doc/guides/nics/features/virtio_vec.ini
>> +++ b/doc/guides/nics/features/virtio_vec.ini
>
> The doc/guides/nics/features/virtio.ini also needs to be updated.
Done.
>
> Thanks for work!
>
>> @@ -6,6 +6,7 @@
>> [Features]
>> Speed capabilities = P
>> Link status = Y
>> +Link status event = Y
>> Rx interrupt = Y
>> Queue start/stop = Y
>> Promiscuous mode = Y
> [...]
>
next prev parent reply other threads:[~2018-04-13 21:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 18:05 Ferruh Yigit
2018-03-14 8:14 ` Nélio Laranjeiro
2018-03-20 15:21 ` Ferruh Yigit
2018-04-06 17:42 ` Ferruh Yigit
2018-04-10 15:41 ` Tiwei Bie
2018-04-13 21:53 ` Ferruh Yigit [this message]
2018-04-14 10:55 ` Tiwei Bie
2018-04-16 16:10 ` Ferruh Yigit
2018-04-17 4:54 ` Tiwei Bie
2018-04-17 11:26 ` Ferruh Yigit
2018-04-18 6:49 ` Tan, Jianfeng
2018-04-18 10:42 ` Ferruh Yigit
2018-04-18 11:36 ` Tiwei Bie
2018-04-18 11:44 ` Ferruh Yigit
2018-04-18 12:08 ` Tiwei Bie
2018-04-18 12:17 ` Ferruh Yigit
2018-04-13 22:02 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-04-16 14:26 ` Adrien Mazarguil
2018-04-17 11:30 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2018-04-19 23:53 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf29cef8-7340-d8d5-6508-e4ed8625a177@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=harish.patil@cavium.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mk@semihalf.com \
--cc=mtetsuyah@gmail.com \
--cc=mw@semihalf.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=qi.z.zhang@intel.com \
--cc=rasesh.mody@cavium.com \
--cc=shahed.shaikh@cavium.com \
--cc=tiwei.bie@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=yliu@fridaylinux.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).