From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5FC3F28C3 for ; Fri, 11 Aug 2017 07:25:42 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2017 22:25:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,356,1498546800"; d="scan'208";a="138374615" Received: from nikhilr-mobl.amr.corp.intel.com (HELO [10.106.152.141]) ([10.106.152.141]) by fmsmga005.fm.intel.com with ESMTP; 10 Aug 2017 22:25:39 -0700 To: Jerin Jacob Cc: gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, narender.vangati@intel.com, Abhinandan Gujjar References: <02aef899-da84-9281-e4a4-2871237ea20e@intel.com> <20170707150317.GA2007@jerin> <20170707155707.GA6245@jerin> <3d2d78cc-9572-bf95-6d25-9b350da62827@intel.com> <20170710104126.GA13609@jerin> <4197b5f1-9a15-5892-12d2-6bd142bc4d85@intel.com> <20170713184445.GA3659@jerin> <123ed8d6-4fd9-8bee-d86e-d270a092169e@intel.com> <20170729151252.GA25166@jerin> <7b9ca757-f428-3675-b997-794ec6e96f2a@intel.com> <20170801164242.GA6467@jerin> From: "Rao, Nikhil" Message-ID: Date: Fri, 11 Aug 2017 10:55:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170801164242.GA6467@jerin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Aug 2017 05:25:43 -0000 On 8/1/2017 10:12 PM, Jerin Jacob wrote: >> I have had the application specify the name. so that it can call >> >> struct rte_service_spec *rte_service_get_by_name(const char *name); > > OK. I was thinking like there will be fixed name for the rx_adapter > service like "eth_rx_adapter_%d"(%d for adapter id) which be exposed in > rte_event_eth_rx_adapter.h. > It can help in removing cfg.service_name. I am fine with either way. > OK, I will use a fixed name. >>> eventdev PMD op api(not as adapter PMD as discussed earlier) >>> ------------------- >>> >>> 1) typedef uint64_t (*eventdev_rx_adap_capa)(struct rte_eventdev *dev, uint8_t ethdev_id) >>> >>> Return the adapter capability of a given eventdev when it needs to >>> connected to a specific ethdev_id >>> >> >> Doesn't the capability of a also need to be made >> available to the application as an adapter API ? > > Yes. Make sense to expose as adapter API also. > Correcting myself, Isn't this really an eventdev API ? An adapter API would take an adapter id argument which is unnecessary in this case. Nikhil