From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09DD0A0C4A; Thu, 8 Jul 2021 11:39:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC4D5415C2; Thu, 8 Jul 2021 11:39:51 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id E3975410DF for ; Thu, 8 Jul 2021 11:39:49 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7A6787F528; Thu, 8 Jul 2021 12:39:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7A6787F528 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625737189; bh=Cm0X6aQFN2X2mr77IT45gYnXFETbecUsKHoD50dJDb0=; h=Subject:To:References:Cc:From:Date:In-Reply-To; b=Q+9b79nX4gnKtL+MpTSoZ+TSh8U1PyT8QWXzoIr5kvfmOEHjQRTi9H3UKG5Km+8Py mT0czcmYHq9bqX1OJZ/J744UGastXyzDyZl1dH56+jNd9eKL5n9fnkmgGpMjYpINPe AcDqHz1ROl76eQvtIRhMNe3hl8NzKpMqLt9PNzzw= To: Raslan Darawsheh , Thomas Monjalon References: <20210617091716.2354978-1-rasland@nvidia.com> <9af41a93-ae9a-2aeb-0dcd-ae0129bf55b2@intel.com> Cc: "Singh, Aman Deep" , "dev@dpdk.org" , "david.marchand@redhat.com" , Olivier Matz From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Thu, 8 Jul 2021 12:39:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/8/21 12:27 PM, Raslan Darawsheh wrote: > Thank you for the review, > > Basically it's not used yet since it will break the abi > The main usage was in rte_flow item of gtp_psc > To replace the current structure with the header definition. And since > this will break the abi I'm adding the header definition now but will be > used later in rte_flow. @Thomas If so, should we accept it in the current release cycle or should it simply wait for the code which uses it? > Kindest regards, > Raslan Darawsheh > > ------------------------------------------------------------------------ > *From:* Andrew Rybchenko > *Sent:* Thursday, July 8, 2021, 12:23 PM > *To:* Raslan Darawsheh; Singh, Aman Deep; dev@dpdk.org > *Subject:* Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc > > Hi Raslan, > > On 7/6/21 5:24 PM, Raslan Darawsheh wrote: >> Hi Guys, >> >> Sorry for missing this mail, for some reason it was missed in my inbox, >> This is the link to this rfc: >> https://www.3gpp.org/ftp/Specs/archive/38_series/38.415/38415-g30.zip > > > Thanks for the link. The patch LGTM, but I have only one question left. > Where is it used? Are you going to upstream corresponding code in > the release cycle? > > Andrew. > >> Kindest regards, >> Raslan Darawsheh >> >>> -----Original Message----- >>> From: dev On Behalf Of Andrew Rybchenko >>> Sent: Thursday, July 1, 2021 5:06 PM >>> To: Singh, Aman Deep ; dev@dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc >>> >>> Hi Raslan, >>> >>> could you reply, please. >>> >>> Andrew. >>> >>> On 6/22/21 10:27 AM, Singh, Aman Deep wrote: >>>> Hi Raslan, >>>> >>>> Can you please provide link to this RFC 38415-g30 I just had some >>>> doubt on byte-order conversion as per RFC 1700 >>>> > >>>> >>>> Regards >>>> Aman > >