From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C8B5A0C55; Wed, 13 Oct 2021 21:23:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8896641293; Wed, 13 Oct 2021 21:23:46 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id B13DB4111B for ; Wed, 13 Oct 2021 21:23:44 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="291003448" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="291003448" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 12:23:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="717458133" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 13 Oct 2021 12:23:43 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 12:23:42 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 12:23:42 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 12:23:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Couxillgw17ff3jK/xUkctihbaVBiEcMgTilupZFIC1lVkPQp84ApcINwGVhM7qu4qkcNsGE3czyDkbeHRVeBmoyrqF7TxmwVqsjSdcwDEj0LI0BGJ6ZAdAUmYRDJj0lRg6XXIkxi5SqI5yXy7FW72LxtbJuRpmJUxIL4mumKPntBw/rMvxPCZuqtptLSnp+B2k0M77K9AtLxkVK9OmP+09dXOTRvHACv6gVn9N1q1jhgc9kopbQLWAxwev1tDZRM6NPYHqIQlehXIVBHIcV81MBQmTSRAGCkqBY3Q3TEp3mW38wg5LCGfJPWU3foJV89qkN+aDyHtYXSUgLo1FBdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lB0wtPjfi7Vle4OrCWiIsOgZxc+0j2JgXlmE0CNsWA8=; b=BXik78Lh3IgTxsVuGd+dJaUDOb7LR6meFcb7aco3VHVMQWjE93Qwgicw6fMhBwLrHju9eVPacL7ltbzX9uPx19y807JiwDUlx8DXyFqnl6V23we8/Iffxo9cbVFpIw9fu+S/siZYEBo6+vQVR0cn7nRKoJ5U5boYFOXuDIxmb8B7VrgpmEb6ltzHc36+bH6LpJ6k07qyemlT/tOkTYkwAOAtDzVCJRjn4oBngjpLA5AyzT2LUi9n+Zz38/ORVxO9QAkKpaGIKGOJ8BJ60Dvm7en8qghaM+R20z9k3RglSJ71YFvALX6t32iSIjhxAk2IbKmseIat4FQ+NB9vszCeSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lB0wtPjfi7Vle4OrCWiIsOgZxc+0j2JgXlmE0CNsWA8=; b=y3L3/Revb5pRuLi5SurE+zd9ZOn9lamEq7/eemvz+auKB1qk2NKg6e7agCGIOF0SvWdkXBupQIWNVDAdo/yNrPQ/sNzJbCjzbVp007lDupDnVIQ9SuS5oajnnQX7lkkHidsAu6Vnz8FZQdqK6XtZ9+Wqresu8SjElwdBWSVjE+g= Authentication-Results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4837.namprd11.prod.outlook.com (2603:10b6:510:41::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct 2021 19:23:41 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 19:23:41 +0000 Message-ID: Date: Wed, 13 Oct 2021 20:23:34 +0100 Content-Language: en-US To: Ajit Khaparde CC: Somnath Kotur , dpdk-dev References: <20211013163101.2811453-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0089.eurprd07.prod.outlook.com (2603:10a6:6:2b::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0089.eurprd07.prod.outlook.com (2603:10a6:6:2b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend Transport; Wed, 13 Oct 2021 19:23:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb42ca43-cda0-4630-bf65-08d98e7ef737 X-MS-TrafficTypeDiagnostic: PH0PR11MB4837: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XQcb+r6V//xDHoS20m3DIOD1Rnk+bjTzUK4dBsVoW4IX6ltVJWtAqoK5BvYEiW8s/vCiery43ZLLyhfo1cJS87/7TDgBNOgvc9Iljuwsx08X6zunQ6JBxsSanwlH5zzMuBybeq3tw50bJx8tbS0pnXtNznukFEHjvQY77hIPZVRZrkemCb04fZHFRhkx5yz+HQQSSZGm8T1U51pk0pFtMLESDvI3cizu0h01EZwvZgtkKWr8bY6uQ6QtLXOZ4mH14xObt7xW4CC1capzir2YEX5VZBAWMoMpHsPQxR5iafj127Ib6Bnq65D6lVmlIv+O4mF48kU/8sdXWmyyZD6P1PkSywA4/LBiq3Kfmd0GC3j91iUMEbIVF0SrEmwBLXulBH9v3l+oFRjWmC44JyVqu6NsXoQpMVUYtvHm7m+SD4oqx19qqIUTztS+RnxSMsJ544cVsKXNSp62R9RwmcRP+9E0Z5fYFLqbiVoPDngPME5UCFS6DgVgjDrNcyqgoep36QRnn29gJw++7JDucRU99Dx8hDjr++jejsROL5Fn23acwuSRCMr84jJ+XcLbzpVkUT8UyOD7g4nNLp0RL596iRtgw1eTKp1Dn0i36ld3HS14BSZ/NkrohA9cMcqKdIeoD2jQudY7D1esRPK/anCdQDmt8hZVx+bys4RCbOdU0uft6bGJ6yM3H1avrl1qZO5mykQmRkdOH1K6BKKNbI0pRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(5660300002)(186003)(38100700002)(26005)(16576012)(2616005)(316002)(8676002)(508600001)(6666004)(53546011)(31686004)(6486002)(2906002)(86362001)(31696002)(82960400001)(8936002)(54906003)(956004)(6916009)(4744005)(4326008)(66946007)(66476007)(44832011)(66556008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REJ3V1ptdkdZQ3NOTGZqcmE3MzVEVGo3bnl4UUtEUmNMbURtZ0dJWkRaOEw0?= =?utf-8?B?dW9NVGxyUW9DNEhxdE53eXRMNGxJd1pHRzZZdkN6dlYzYktOMm5HVHNnK0ZB?= =?utf-8?B?M2lwYU5tRG04SXFKU3JpL1pwYm9iNHA1bW0wQkp2UEFEYzhJQWxZUXhsMElF?= =?utf-8?B?UGZnNkdkay8zNnBVMmZGU2FoS3lrYUNtd3F3UUxDQXhxNEp3YjJOZmZGZWF0?= =?utf-8?B?Sm9wSTVPdWhKdllueUwwc2prZWV5d3VQRmpQZWdtTldZQkNUSVpTcUl2M0Nj?= =?utf-8?B?VDNzUTluWXdzNm94OWtXNGIwQVBGVGh1ZUhGMmZYTFVNRTk2am5TQUNWckVY?= =?utf-8?B?MDNHVlJ3OS9JdThvTmNGeWhjS3NTaGJsbGREd1Z6TTdRNVRKN21KVitVbGt2?= =?utf-8?B?U2VsdW1rMkRpV2pXR0NPUE5EYk1QL0hwNGRIYmg0ZWlZMFNIL0hFUEdSZUU4?= =?utf-8?B?TlpMUTd6MTQ2VDRIZFkvZ1hyamhDekJxZHpKdXpEV253VC81TW9nNlBneDNP?= =?utf-8?B?c3ZoeDFmcERNU2JMZnRCSHg0MnRDRFBuM0ZuNFdZTkpoMjUvaXBQOGpZUmRE?= =?utf-8?B?NmlHOEdBRlYyMnIxSWlvS21BOEk0SlM0cGJHbVhUeE5RNXp5NWtTaHQvSkc1?= =?utf-8?B?WFBvRklqTFJlWnM4eHpGN28xVUEybkh0L0FqZFZLTFVFZDZyMXVmeFB2azNF?= =?utf-8?B?YmFoVjIrUXkrTFh5QzRyM0szdjJnT0E1L0RYWUZsTWRpVTgzTVlINE1wRVpB?= =?utf-8?B?VGJDaUZmckp0MUdMT1poOWJBZ1pWRTYxb0E5WFI3ZkhzWmhJZGhKb3N0SDBv?= =?utf-8?B?SVUrZ0FqV0NRdGdrZ2VMWWo2U2lBUWRBVCtJME1pMm0wdW9taDdDS21aMVh3?= =?utf-8?B?WWJDVENJeHlYY09KRElEaC9sSTZJUU5RVXkxODF0UmFSRkdBRnNmOTRLSEhJ?= =?utf-8?B?alFnT09oZEprTXpZcEg4ei9RZVhydm55QlZzYmRKUUlKQkRvT3FRK0w1UEoy?= =?utf-8?B?SVdXWWVFR1FjVVdyR1p6VHFTMS9tUEVXQVlzd21uVE5PWlBmTmw3RGorU1BB?= =?utf-8?B?aytqTGY5TkRSY3U4czRCT2Zza3FwUFo5ZUY0YUtWWVhKYVFsbEZEL0FSN3ZJ?= =?utf-8?B?R1Eya2RJejB3MzNkMU03d2JKbjZONzl2RXkydWQyMkYxbkMvMmtzRXIwWEM4?= =?utf-8?B?L0NCSmRsNlpqUVJoSkFyMllCTzNuU2VKNGtOTjhBd3FjeHV2bmNCZ1Y1ZWVj?= =?utf-8?B?VXdUWFRCeERoVUF1emVyK3kybjN4dDcvS2tCYTM4NDQxVVpyM3VkY0lJbTdM?= =?utf-8?B?M0JmV041UjhJbG5oM3Qvekc1ejhiTlNnTUtCQnhveWtjWU84VVNpWGp1YzVa?= =?utf-8?B?QjJLL0NuQThIcmNCM2lVVVcrQmlzbnZkbzkrOEJEeDdRNnZSRTFRakZRMW5t?= =?utf-8?B?bVQxM0ZTZk1PYm1PMGM4bGVrUk9hTlZoaWttUVNzZGRudzNGR05udHpQOGJ4?= =?utf-8?B?ZEIwUUlIUXRhVDRhYjlJK213RXdpakpPZXdUV2txOVVjZ3hJODRqNXREeGxw?= =?utf-8?B?bHFWbjNGSWsvUTBFQWVaWThHZCtoSWltTFdnU3RaaWVaK0d4dkI4Z003V3ZG?= =?utf-8?B?SFJSTHlaMzRJNzErTm0rRVEySU10bThveG5LZWZrUm5zRmFHbEIwSkV3VUpj?= =?utf-8?B?T3VwSGVtalhFNm40RkFQODR2KytTc09oeGlLQlpLdUlaTzZ4Rm5jeW4vSUh4?= =?utf-8?Q?DU9s47q7fgLxKXajAZsEugOGjpwUdBenurZ2lvf?= X-MS-Exchange-CrossTenant-Network-Message-Id: fb42ca43-cda0-4630-bf65-08d98e7ef737 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 19:23:41.5400 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tS9sYSpAvf3Dv5nkea9EeqB6nMWCIejmg1ydsEnfmVmbjpYVSIBwEg1sgC2qGjJ5+tOo+ZBUpbYJAkUhtzUVkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4837 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 6:34 PM, Ajit Khaparde wrote: > On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit wrote: >> >> Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error, >> removing it. >> >> Also with meson build system compile time debug macros should be >> documented in driver documentation, since there is not other way to > s/not/no > >> figure out their existence. >> >> Signed-off-by: Ferruh Yigit > With thanks and above nit, :-) > > Reviewed-by: Ajit Khaparde > Other option is to fix the build error when macro is set, would you like to go with that option? And can you please send a separate patch to document the remaining compile time macros in the driver guide?