From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 3FDBE1B3A8 for ; Fri, 5 Oct 2018 17:56:55 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id E8190480076; Fri, 5 Oct 2018 15:56:52 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 5 Oct 2018 16:56:38 +0100 To: Ferruh Yigit , Reshma Pattan , Hemant Agrawal , "Shreyansh Jain" , Ashish Gupta , "Fiona Trahe" , Pablo de Lara , Akhil Goyal , "Declan Doherty" , Fan Zhang , Rahul Lakkireddy , Gaetan Rivet , Qi Zhang , Xiao Wang , Beilei Xing , Wenzhuo Lu , Konstantin Ananyev , Rasesh Mody , Harish Patil , Shahed Shaikh , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , "Nipun Gupta" , Anatoly Burakov , Thomas Monjalon , Jerin Jacob , Olivier Matz CC: References: <20181004034047.26824-1-ferruh.yigit@intel.com> <20181005162612.31906-1-ferruh.yigit@intel.com> From: Andrew Rybchenko Message-ID: Date: Fri, 5 Oct 2018 18:55:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181005162612.31906-1-ferruh.yigit@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24136.003 X-TM-AS-Result: No-8.784100-8.000000-10 X-TMASE-MatchedRID: VfovoVrt/oYOwH4pD14DsPHkpkyUphL9I7OxeNfmD+yKS8s/FMqmOE4S 6ORp/aWjvvJoxo0uTMTpe8MA9EHtlsRBLZ5x+SkXR/j040fRFpKVKmGUZ/WnkbhYGdhSVbOMu0m nSBAOWhsWlr0BkxrVx+jw1puDYhUcNXL5zPaYY+Gcnm0v4tsY43zIY7d2+Tz9AnW+Tu2Fi4ZR18 QpzXStTi9BUTTI4YWlioFl5UK3cJ/SduMc6RnI+T5bo3ZLMFMHB+dff70WbjlCI7pNLiSjfcUzz dIu4oxh92grUwQgYZd5OPD8XJFfpE1+zyfzlN7ygxsfzkNRlfJq8/xv2Um1arVV9mtf2bFYVwwl Uw6OBnKqhU1EnX7Xc8Tns8rFGl4HKdGVw7R3oIT7e4Awl24J4/hc1uvQVrJgKlFmBFTfzUeTChk CioZdkUpErKrHg4Tc X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--8.784100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24136.003 X-MDID: 1538755014-4Fh942H1duNS Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 15:56:55 -0000 On 10/5/18 7:26 PM, Ferruh Yigit wrote: > Some global variables can indeed be static, add static keyword to them. > > Signed-off-by: Ferruh Yigit > --- <...> > diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c > index 000cd0b20..e71ddd001 100644 > --- a/drivers/net/sfc/sfc_rx.c > +++ b/drivers/net/sfc/sfc_rx.c > @@ -1126,7 +1126,7 @@ sfc_rx_qfini(struct sfc_adapter *sa, unsigned int sw_index) > /* > * Mapping between RTE RSS hash functions and their EFX counterparts. > */ > -struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = { > +static struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = { I'd prefer "static const" in fact > { ETH_RSS_NONFRAG_IPV4_TCP, > EFX_RX_HASH(IPV4_TCP, 4TUPLE) }, > { ETH_RSS_NONFRAG_IPV4_UDP, <...> Acked-by: Andrew Rybchenko