From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: stephen@networkplumber.org, mb@smartsharesystems.com,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v3] ethdev: add Linux ethtool link mode conversion
Date: Mon, 4 Mar 2024 15:58:50 +0000 [thread overview]
Message-ID: <bfa2f0c1-d8a3-4aed-a81c-3c9b0b9df9b0@amd.com> (raw)
In-Reply-To: <20240303095812.2235050-1-thomas@monjalon.net>
On 3/3/2024 9:56 AM, Thomas Monjalon wrote:
> Speed capabilities of a NIC may be discovered through its Linux
> kernel driver. It is especially useful for bifurcated drivers,
> so they don't have to duplicate the same logic in the DPDK driver.
>
> Parsing ethtool speed capabilities is made easy thanks to
> the functions added in ethdev for internal usage only.
> Of course these functions work only on Linux,
> so they are not compiled in other environments.
>
> In order to ease parsing, the ethtool macro names are parsed
> externally in a shell command which generates a C array
> included in this patch.
> It also avoids to depend on a kernel version.
> This C array should be updated in future to get latest ethtool bits.
> Note it is easier to update this array than adding new cases
> in a parsing code.
>
> The types in the functions are following the ethtool type:
> uint32_t for bitmaps, and int8_t for the number of 32-bitmaps.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2024-03-04 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 12:34 [PATCH v1] " Thomas Monjalon
2024-02-29 15:42 ` [PATCH v2] " Thomas Monjalon
2024-02-29 16:45 ` Stephen Hemminger
2024-02-29 16:58 ` Morten Brørup
2024-02-29 17:38 ` Stephen Hemminger
2024-03-01 10:27 ` Thomas Monjalon
2024-03-01 13:12 ` Ferruh Yigit
2024-03-01 13:37 ` Thomas Monjalon
2024-03-01 15:08 ` Ferruh Yigit
2024-03-01 15:20 ` Thomas Monjalon
2024-03-01 17:16 ` Ferruh Yigit
2024-03-01 18:00 ` Stephen Hemminger
2024-03-03 9:36 ` Thomas Monjalon
2024-03-03 9:56 ` [PATCH v3] " Thomas Monjalon
2024-03-04 15:58 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa2f0c1-d8a3-4aed-a81c-3c9b0b9df9b0@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).