From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E00731E2F for ; Tue, 30 Oct 2018 11:10:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2018 03:10:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,444,1534834800"; d="scan'208";a="103731233" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.72]) ([10.237.220.72]) by fmsmga001.fm.intel.com with ESMTP; 30 Oct 2018 03:10:12 -0700 To: Alejandro Lucero , Yongseok Koh Cc: lei.a.yao@intel.com, Thomas Monjalon , dev , "Xu, Qian Q" , xueqin.lin@intel.com, Ferruh Yigit References: <1538743527-8285-1-git-send-email-alejandro.lucero@netronome.com> <2DBBFF226F7CF64BAFCA79B681719D954502B94F@shsmsx102.ccr.corp.intel.com> <3483377.PMXnpSGLS9@xps> <621BE501-6B10-4053-AC33-50ABE0231A44@mellanox.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 30 Oct 2018 10:10:11 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 10:10:17 -0000 On 29-Oct-18 7:37 PM, Alejandro Lucero wrote: > > > On Mon, Oct 29, 2018 at 6:54 PM Yongseok Koh > wrote: > > > > On Oct 29, 2018, at 7:18 AM, Thomas Monjalon > wrote: > > > > 29/10/2018 14:40, Alejandro Lucero: > >> On Mon, Oct 29, 2018 at 1:18 PM Yao, Lei A > wrote: > >>> *From:* Alejandro Lucero [mailto:alejandro.lucero@netronome.com > ] > >>> On Mon, Oct 29, 2018 at 11:46 AM Thomas Monjalon > > > >>> wrote: > >>> > >>> 29/10/2018 12:39, Alejandro Lucero: > >>>> I got a patch that solves a bug when calling rte_eal_dma_mask > using the > >>>> mask instead of the maskbits. However, this does not solves the > >>> deadlock. > >>> > >>> The deadlock is a bigger concern I think. > >>> > >>> I think once the call to rte_eal_check_dma_mask uses the > maskbits instead > >>> of the mask, calling rte_memseg_walk_thread_unsafe avoids the > deadlock. > >>> > >>> Yao, can you try with the attached patch? > >>> > >>> Hi, Lucero > >>> > >>> This patch can fix the issue at my side. Thanks a lot > >>> for you quick action. > >> > >> Great! > >> > >> I will send an official patch with the changes. > > > > Please, do not forget my other request to better comment functions. > > Alejandro, > > This patchset has been merged to stable/17.11 per your request for > the last release. > You must send a fix to stable/17.11 as well, if you think there's a > same issue there. > > > The patchset for 17.11 was much more simpler. There have been a lot of > changes to the memory code since 17.11, and this problem should not be > present in stable 17.11. > > Once I have said that, if there are any reports about a problem with > this patchset in 17.11, I will work on it as a priority. > > Thanks. > 17.11 will definitely be immune to the deadlock issue since there are no memseg walks there :) It however may still have incorrect mask handling. -- Thanks, Anatoly