[PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

[PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

[Stephen Hemminger]

The zero length array warning can be re-enabled.
The zero length marker fields are now removed by
commit 9e152e674c77 ("mbuf: remove marker fields")
in DPDK 24.03.

This reverts commit cfacbcb5a23bc26cb913528c372adddabbb33ca1.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 config/meson.build | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/config/meson.build b/config/meson.build
index 8c8b019c25..38f25f9ce3 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -330,10 +330,7 @@ warning_flags = [
         '-Wno-packed-not-aligned',
         '-Wno-missing-field-initializers',
 ]
-if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0')
-# FIXME: Bugzilla 396
-    warning_flags += '-Wno-zero-length-bounds'
-endif
+
 if not dpdk_conf.get('RTE_ARCH_64')
 # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!!
     warning_flags += '-Wno-pointer-to-int-cast'
-- 
2.45.2

RE: [PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

[Morten Brørup]

More warnings enabled is always good.
And even better when the code builds without those warnings. :-)

Acked-by: Morten Brørup <mb@smartsharesystems.com>

Re: [PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

[Bruce Richardson]

On Fri, Oct 11, 2024 at 10:57:10AM -0700, Stephen Hemminger wrote:
> The zero length array warning can be re-enabled.
> The zero length marker fields are now removed by
> commit 9e152e674c77 ("mbuf: remove marker fields")
> in DPDK 24.03.
> 
> This reverts commit cfacbcb5a23bc26cb913528c372adddabbb33ca1.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

[Kevin Traynor]

On 11/10/2024 18:57, Stephen Hemminger wrote:
> The zero length array warning can be re-enabled.
> The zero length marker fields are now removed by
> commit 9e152e674c77 ("mbuf: remove marker fields")
> in DPDK 24.03.
> 
> This reverts commit cfacbcb5a23bc26cb913528c372adddabbb33ca1.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  config/meson.build | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 

Acked-by: Kevin Traynor <ktraynor@redhat.com>

Re: [PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

[Thomas Monjalon]

14/10/2024 09:58, Bruce Richardson:
> On Fri, Oct 11, 2024 at 10:57:10AM -0700, Stephen Hemminger wrote:
> > The zero length array warning can be re-enabled.
> > The zero length marker fields are now removed by
> > commit 9e152e674c77 ("mbuf: remove marker fields")
> > in DPDK 24.03.
> > 
> > This reverts commit cfacbcb5a23bc26cb913528c372adddabbb33ca1.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.